New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated change log(+368) #11826

Closed
wants to merge 2 commits into
base: release_notes_0.300
from

Conversation

Projects
None yet
4 participants

@JHJ93 JHJ93 referenced this pull request Jan 11, 2019

Closed

Help needed to prepare the 0.300 release #11741

40 of 40 tasks complete
@@ -423,6 +424,16 @@ Benner and Paweł Siudak):
- Renamed =spacemacs/mplist-get= function to =spacemacs/mplist-get-values=,
renamed =spacemacs/plist-get= function to =spacemacs/mplist-get-value=, and
refactored the latter function (thanks to Benjamin Reynolds)
- Fixed pdumper enabled on ~SPC f e R~ no matter what (thanks to Sylvain Benner)

This comment has been minimized.

@Miciah

Miciah Jan 11, 2019

Because dump suport is a new feature since the last release, fixes to this new feature by its original author (Sylvain) probably don't need an entry.

@@ -423,6 +424,16 @@ Benner and Paweł Siudak):
- Renamed =spacemacs/mplist-get= function to =spacemacs/mplist-get-values=,
renamed =spacemacs/plist-get= function to =spacemacs/mplist-get-value=, and
refactored the latter function (thanks to Benjamin Reynolds)
- Fixed pdumper enabled on ~SPC f e R~ no matter what (thanks to Sylvain Benner)
- Display time spent in =user-config= in home buffer (thanks to Sylvain Benner)
- Don't call =user-load= unless we are dumping (thanks to Sylvain Benner)

This comment has been minimized.

@Miciah

Miciah Jan 11, 2019

The user-load function was added as part of the dump support, so fixes related to it probably can be skipped. Although maybe we should have an entry like "New dotfile function =dotspacemacs/user-load=", similar to the entry you added for dotspacemacs/user-env.

- Display time spent in =user-config= in home buffer (thanks to Sylvain Benner)
- Don't call =user-load= unless we are dumping (thanks to Sylvain Benner)
- Removed dotspacemacs variable =dotspacemacs-import-env-vars-from-shell= (thanks to Sylvain Benner)
- Removed dotspacemacs variable =dotspacemacs-improt-env-vars-shell-file-name= (thanks to Sylvain Benner)

This comment has been minimized.

@Miciah

Miciah Jan 11, 2019

The dotspacemacs-import variables were added since the last release, so it isn't necessary to add entries for their removal.

- Removed dotspacemacs variable =dotspacemacs-import-env-vars-from-shell= (thanks to Sylvain Benner)
- Removed dotspacemacs variable =dotspacemacs-improt-env-vars-shell-file-name= (thanks to Sylvain Benner)
- Rename environment file from =spacemacs.env= to =.spacemacs.env= (thanks to Sylvain Benner)
- Move location of =.spacemacs.env= file to home or dotdirectory (thanks to Sylvain Benner)

This comment has been minimized.

@Miciah

Miciah Jan 11, 2019

Environment variable caching is a new feature since the last release (there's an entry under "Hot new feature"), so these fixes probably should be omitted.

@@ -435,6 +446,7 @@ Benner and Paweł Siudak):
- The new =spacemacs-modeline= layer configures packages for the mode line.
- The new =spacemacs-project= layer configures =projectile=.
- Merge =spacemacs-ui= and =spacemacs-ui-visual= into layer =spacemacs-visual=
- Remove =spacemacs-environment= from =spacemacs-bootstrap= layer

This comment has been minimized.

@Miciah

Miciah Jan 11, 2019

The spacemacs-environment layer was not in the last release, so this entry can probably be omitted.

- ~SPC f y C~ to show and copy current file path relaitve to the project root with line and column number
- ~SPC f y D~ to show and copy current directory path relaitve to the project root
- ~SPC f y L~ to show and copy current file path relaitve to the project root with line number
- ~SPC f y Y~ to show and copy current file path relaitve to the project root

This comment has been minimized.

@Miciah

Miciah Jan 11, 2019

The above four lines all have a typo: "relaitve" (the typo was present in the documentation too but has been fixed).

@@ -1054,6 +1087,7 @@ Benner and Paweł Siudak):
- Fixed "Invalid face reference" error in Helm transient state (thanks to
duianto)
- Hide lighter (thanks to Sylvain Benner)
- Move helm variable from helm layer to spacemacs-completion layer (thanks to Kalle Lindqvist)

This comment has been minimized.

@Miciah

Miciah Jan 11, 2019

This can be omitted because there is already an entry that covers the change (look for "Renamed helm variables and made them layer variables"). I added that entry earlier because there were a lot of related changes, and once I had sorted those changes out, I just added a single entry for all of them. Sorry for the confusion!

@@ -1599,6 +1640,7 @@ Benner and Paweł Siudak):
- Key bindings:
- ~SPC m E e~ is for =tide-fix= which was originally added as ~SPC m r f~
(thanks to Simon Altschuler)
- ~SPC m E d~ to add =tslitn-disable-next-line= at point (thanks to Daniel Perez Alvarez)

This comment has been minimized.

@Miciah

Miciah Jan 11, 2019

Typo: "tslitn" should be "tslint". ...Although I see that the documentation has the same typo.

@Miciah

This comment has been minimized.

Copy link

Miciah commented Jan 11, 2019

Commit aba51af "Multiple ways to copy a file path" also added the column-indexing toggle (which was later renamed to zero-based-column-indexing). This probably warrants an entry, e.g.: "Added ~SPC t z~ to toggle zero-based column indexing in the mode line" under "Distribution changes".

@sdwolfz sdwolfz self-assigned this Jan 12, 2019

@sdwolfz

This comment has been minimized.

Copy link
Collaborator

sdwolfz commented Jan 12, 2019

Thank you ❤️!
And congratulations on your first Spacemacs PR 🎉!
Cherry-picked into release_notes_0.300 branch, you can safely delete your branch.
Commit: 51993ba

@sdwolfz sdwolfz closed this Jan 12, 2019

@JHJ93 JHJ93 deleted the JHJ93:release_notes_0.300 branch Jan 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment