Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidity Layer #11907

Closed
wants to merge 1 commit into from
Closed

Solidity Layer #11907

wants to merge 1 commit into from

Conversation

@expede
Copy link
Contributor

@expede expede commented Jan 27, 2019

TL;DR

About

  • Wrote to scratch my own itch
  • This is a first pass, and much more functionality could be added
  • This layers aims to make it practical to use Spacemacs for Ethereum development

Includes

  • Syntax highlighting
  • Syntax checking
  • Naive autocomplete

Does Not (yet) Include

  • Smart autocomplete
  • Test commands
  • Truffle (or similar) integration
@expede expede force-pushed the solidity-layer branch from ba26078 to 63fc409 Jan 27, 2019
@sdwolfz sdwolfz added this to the Future Release 0.301.0 milestone Jan 28, 2019
@expede expede mentioned this pull request Jan 31, 2019
7 tasks
@wurosh
Copy link
Contributor

@wurosh wurosh commented Apr 12, 2019

I have some configs that address some of those not yet included features. Should I add it now, or wait until the core layer is incorporated into spacemacs so there are more eyes on what we're doing?

@expede
Copy link
Contributor Author

@expede expede commented Apr 13, 2019

Hey @jjzmajic -- that's great to hear! What I have so far are the bare essentials to scratch my own itch. Feel free to PR against expede:solidity-layer. At absolute worst, we delay until this is merged upstream, but I'm not sure what the timeline for that will actually be.

@duianto
Copy link
Collaborator

@duianto duianto commented May 9, 2019

It's unrelated to this Leyer, but flymake-solidity seems to assume a non-windows setup:

Not enabling flymake: ’/usr/local/bin/solc’ program not found [2 times]

I don't know if the following messages are related to the above issue, but jit-lock error messages appear when a .sol example file is opened or edited:

Error during redisplay: (jit-lock-function 1) signaled (error "No match 4 in highlight (4 font-lock-variable-name-face)")
Error during redisplay: (jit-lock-function 501) signaled (error "No match 4 in highlight (4 font-lock-variable-name-face)")
Error during redisplay: (jit-lock-function 1001) signaled (error "No match 4 in highlight (4 font-lock-variable-name-face)")
Error during redisplay: (jit-lock-function 1501) signaled (error "No match 4 in highlight (4 font-lock-variable-name-face)")

The file is the first example on this page:
https://solidity.readthedocs.io/en/latest/solidity-by-example.html

@sei40kr sei40kr mentioned this pull request Nov 11, 2019
@duianto
Copy link
Collaborator

@duianto duianto commented Nov 22, 2019

The following PRs (possibly modified) changes are now on the develop branch:
Add Solidity layer #12922

@duianto duianto closed this Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants