Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change org-roam keybindings to use new v2 format #14939

Closed

Conversation

komali2
Copy link

@komali2 komali2 commented Jul 20, 2021

org-roam v2 is out, and has replaced org-roam v1 on melpa

Users that update packages will be brought to org-roam v2 now, and their
keybindings will refer to nonexistent functions, or depreciated functions. This
change should update all functions that have v2 versions.

Also, org-roam-server isn't yet supported, so I removed it.

I wasn't sure how to update the changelog, but it's not too important to me. I didn't see other PRs do it, anyway :P

Copy link
Contributor

@snuffop snuffop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org-roam-find-node should be org-roam-node-find?

@komali2 komali2 force-pushed the update-org-roam-keybindings-v2 branch from ecf10eb to 2db02dc Compare July 21, 2021 00:38
@komali2
Copy link
Author

komali2 commented Jul 21, 2021

org-roam-find-node should be org-roam-node-find?

Ah! Sorry, updated!

@jason--liu
Copy link

The Readme file should alse be updated, like the key bindings in the file.

org-roam v2 is out, and has replaced org-roam v1 on melpa

Users that update packages will be brought to org-roam v2 now, and their
keybindings will refer to nonexistent functions, or depreciated functions. This
change should update all functions that have v2 versions.

Also, org-roam-server isn't yet supported, so I removed it.
@komali2
Copy link
Author

komali2 commented Jul 22, 2021

Cheers for the shout outs, updated again!

@komali2 komali2 force-pushed the update-org-roam-keybindings-v2 branch from 2db02dc to 5c6fe7b Compare July 22, 2021 13:46
@jason--liu
Copy link

When this patch will be merged?

@komali2
Copy link
Author

komali2 commented Jul 23, 2021

Uh, I dunno, is that uhhh, up to me? I think it needs approval?

@YukoOshima
Copy link

Please merge this branch~~ so that the roam feature can work. The roam feature is broken now

@komali2
Copy link
Author

komali2 commented Jul 26, 2021

@snuffop Hello, I believe I'm ready for re-review

@duianto
Copy link
Collaborator

duianto commented Jul 26, 2021

There are two org-roam fix PR's:
Rename commands for org-roam v2 compatibility #14930
Change org-roam keybindings to use new v2 format #14939

We should combine the changes into one.

A quick glance shows these differences.

  • two node find key bindings in the first PR
        "aorf" 'org-roam-node-find
        "aorn" 'org-roam-node-find

the second PR only has the first.

  • tag removal has two different key bindings
    First PR:
"aortr" 'org-roam-tag-remove

Second PR:

"aortd" 'org-roam-tag-remove
  • the function org/init-org-roam-server is removed in the second PR
(defun org/init-org-roam-server()
  (use-package org-roam-server
    :defer t
    :init
    (progn
      (spacemacs/set-leader-keys "aors" 'org-roam-server-mode)
      (spacemacs/set-leader-keys-for-major-mode 'org-mode "rs" 'org-roam-server-mode))))

@duianto
Copy link
Collaborator

duianto commented Jul 26, 2021

Let's use the first PR since it was opened first:
Rename commands for org-roam v2 compatibility #14930

@komali2 Thanks for opening this PR, we'll add a changelog entry that thanks both of you (PR authors).

@duianto
Copy link
Collaborator

duianto commented Jul 28, 2021

The other PR has been merged.
Rename commands for org-roam v2 compatibility #14930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants