New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change org-roam keybindings to use new v2 format #14939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
org-roam-find-node should be org-roam-node-find?
ecf10eb
to
2db02dc
Compare
Ah! Sorry, updated! |
The |
org-roam v2 is out, and has replaced org-roam v1 on melpa Users that update packages will be brought to org-roam v2 now, and their keybindings will refer to nonexistent functions, or depreciated functions. This change should update all functions that have v2 versions. Also, org-roam-server isn't yet supported, so I removed it.
Cheers for the shout outs, updated again! |
2db02dc
to
5c6fe7b
Compare
When this patch will be merged? |
Uh, I dunno, is that uhhh, up to me? I think it needs approval? |
Please merge this branch~~ so that the roam feature can work. The roam feature is broken now |
@snuffop Hello, I believe I'm ready for re-review |
There are two org-roam fix PR's: We should combine the changes into one. A quick glance shows these differences.
the second PR only has the first.
Second PR:
|
The other PR has been merged. |
org-roam v2 is out, and has replaced org-roam v1 on melpa
Users that update packages will be brought to org-roam v2 now, and their
keybindings will refer to nonexistent functions, or depreciated functions. This
change should update all functions that have v2 versions.
Also, org-roam-server isn't yet supported, so I removed it.
I wasn't sure how to update the changelog, but it's not too important to me. I didn't see other PRs do it, anyway :P