Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install org from ELPA instead of Org ELPA #15140

Conversation

dalanicolai
Copy link
Contributor

@dalanicolai dalanicolai commented Nov 4, 2021

From org version 9.5 org will not be distributed from Org ELPA but from
ELPA (see https://list.orgmode.org/87lfa7tc9v.fsf@gnu.org/t/). This commit makes
Spacemacs use/install org from ELPA.

Besides that, this commit removes some 'hack' that seemed to have no effect. As
org comes with Emacs, package-installed-p 'org will always return t. Also
activating org via configuration-layer//activate-package seems to have no
effect.

Finally, the package is declared including a :min-version because appending only
:location elpa seems to have no effect (this can probably be considered a
bug).
I am almost certain that the information that was added when making org install
from Org ELPA is still relevant also for installing org from ELPA so I have just
adapted the version number from 0.104 to 0.300 in the docs.

As the "org" archive has been removed, the ert-deftest for it can be removed
also.

From org version 9.5 org will not be distributed from Org ELPA but from
ELPA (see https://list.orgmode.org/87lfa7tc9v.fsf@gnu.org/t/). This commit makes
Spacemacs use/install org from ELPA.

Besides that, this commit removes some 'hack' that seemed to have no effect. As
org comes with Emacs `package-installed-p 'org` will always return t. Also
activating org via `configuration-layer//activate-package` seems to have no
effect.

Finally, the package is declared including a :min-version because appending only
`:location melpa` seems to have no effect (this can probably be considered a
bug).
I am almost certain that the information that was added when making org install
from Org ELPA is still relevant also for installing org from ELPA so I have just
adapted the version number from 0.104 to 0.300.

As the "org" archive has been removed, the `ert-deftest` for it can be removed
also.
@smile13241324 smile13241324 merged commit 548edef into syl20bnr:develop Nov 6, 2021
@smile13241324
Copy link
Collaborator

👍

@dillydogg
Copy link

dillydogg commented Nov 6, 2021

In my hands, on my Linux (openSUSE) and Win10 machines, after doing a git pull --rebase with these changes, after updating packages, restarting emacs SPC q R (or using SPC f e R) and opening a .org file, org-version still displays 9.4.6.

Specifically Org mode version 9.4.6 (9.4.6-13-g4be129-elpa @ /home/USER/.emacs.d/elpa/27.2/develop/org-20210920/).

Perhaps there are other changes that are required for this to work?

@dalanicolai
Copy link
Contributor Author

@dillydog I am not sure what is the crucial step. For me Spacemacs installed version 9.5 on a 'fresh' test install. And on my work install, I guess I just had to do SPC f e R (but maybe I had carried out some other crucial steps that I am not aware of).
I hope someone can drop-in and share his experience (the behavior of this PR on his installation).

@dalanicolai
Copy link
Contributor Author

Also I guess this PR makes org-contrib install from NonGNU ELPA, because we removed the "org" archive, and contrary to "'org", org-contrib is not included with Emacs (so it does not require the :location elpa)... however no guarantees (but, because of the README in the org-contrib directory instructing users to install from NonGNU ELPA, I guess things work correctly)

@dillydogg
Copy link

dillydogg commented Nov 6, 2021

I wanted to leave an update here. On Gitter chat @dalanicolai recommended that I either perform a fresh install or remove the org elpa directory. I performed a fresh install and this worked perfectly on my Linux isntall. On a side note, having org-contrib install from nongnu elpa is probably preferrable, as this is now the primary repo for org-contrib per https://list.orgmode.org/87a6qnixnr.fsf@gnu.org/.

I will try removing the org elpa directory from my spacemacs on my Windows 10 install and report back soon to confirm that method works as well.

@dillydogg
Copy link

This is thankfully my final comment on this PR. On my Win10 install, removing the .emacs.d/elpa/27.2/develop/org-20210920 directory before git pull --rebase worked perfectly. If possible, a PR that would remove a downloaded org-YYYYMMDD directory would bring everyone up to the latest org. Great work @dalanicolai.

@dalanicolai
Copy link
Contributor Author

dalanicolai commented Nov 20, 2021

Just for the record... fixes #15141. @dillydogg Thanks for the beer!

@chris-aeviator
Copy link

I'm getting an 'IMPORTANT: please install Org from GNU ELPA…' message when starting spacemacs...how can I change an existing installation of spacemacs to point to GNU elpa?

@dalanicolai dalanicolai deleted the update->install-org-from-elpa-instead-of-org-elpa branch November 29, 2021 15:19
@dalanicolai
Copy link
Contributor Author

@chris-aeviator First sync (git pull) Spacemacs. Then I am not sure, for me, it worked to just restart Spacemacs. Others have mentioned that they manually had to delete the org directory from their emacs..d/elpa directories, before restarting Spacemacs. Anyway, these steps should be sufficient I guess...

@Atrus7
Copy link

Atrus7 commented Dec 6, 2021

Yeah I'm got the same as @chris-aeviator comment, took me a while to track it down.

workaround for me was:
rm -rf ~/.emacs.d/elpa/develop/org-9.5.1*

@chris-aeviator
Copy link

@chris-aeviator First sync (git pull) Spacemacs. Then I am not sure, for me, it worked to just restart Spacemacs. Others have mentioned that they manually had to delete the org directory from their emacs..d/elpa directories, before restarting Spacemacs. Anyway, these steps should be sufficient I guess...

@delaanthonio thanks - can confirm git pulling master solely fixed things for me on Arch Linux 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants