New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Perspectives lazy loading #2845

Closed
wants to merge 33 commits into
base: develop
from

Conversation

Projects
None yet
@CestDiego
Contributor

CestDiego commented Sep 1, 2015

Now that I understand better lazy loading and elisp I figured I'd give
the perspectives layer another go. I try to replicate the microstate
from Eyebrowse, but still working on the custom-perspectives.

I would appreciate some feedback until this is merged

@robbyoconnor

This comment has been minimized.

Show comment
Hide comment
@robbyoconnor

robbyoconnor Sep 1, 2015

Contributor

👀 👍 👓 👀

Contributor

robbyoconnor commented Sep 1, 2015

👀 👍 👓 👀

Show outdated Hide outdated contrib/!window-management/perspectives/packages.el
(defun perspectives/init-perspective ()
(use-package perspective
:defer

This comment has been minimized.

@bmag

bmag Sep 1, 2015

Collaborator

Shouldn't it be :defer t? In any case, using :commands implies :defer t

@bmag

bmag Sep 1, 2015

Collaborator

Shouldn't it be :defer t? In any case, using :commands implies :defer t

This comment has been minimized.

@CestDiego

CestDiego Sep 1, 2015

Contributor

indeed the :defer is irrelevant

@CestDiego

CestDiego Sep 1, 2015

Contributor

indeed the :defer is irrelevant

Show outdated Hide outdated contrib/!window-management/perspectives/packages.el
;; persp-cycle-next
;; persp-cycle-prev
persp-rename
persp-switch
projectile-persp-bridge
)
projectile-persp-bridge)

This comment has been minimized.

@bmag

bmag Sep 1, 2015

Collaborator

projectile-persp-bridge is part of persp-projectile, should be under perspectives/init-persp-projectile

@bmag

bmag Sep 1, 2015

Collaborator

projectile-persp-bridge is part of persp-projectile, should be under perspectives/init-persp-projectile

This comment has been minimized.

@CestDiego

CestDiego Sep 1, 2015

Contributor

it is there, this is just variables that neaded cleaning, thanks! :)

@CestDiego

CestDiego Sep 1, 2015

Contributor

it is there, this is just variables that neaded cleaning, thanks! :)

Show outdated Hide outdated contrib/!window-management/perspectives/packages.el
:init
(progn

This comment has been minimized.

@bmag

bmag Sep 1, 2015

Collaborator

IIRC It's preferred to use a progn for the body of :init and :config. There was a discussion about in spacemacs as well as in use-package itself. I can post relevant links if you want.

@bmag

bmag Sep 1, 2015

Collaborator

IIRC It's preferred to use a progn for the body of :init and :config. There was a discussion about in spacemacs as well as in use-package itself. I can post relevant links if you want.

This comment has been minimized.

@CestDiego

CestDiego Sep 1, 2015

Contributor

I remember that using progn was optional now, and even examples in use-package page don't use it. I think maybe we could leave this convention behind? @syl20bnr

@CestDiego

CestDiego Sep 1, 2015

Contributor

I remember that using progn was optional now, and even examples in use-package page don't use it. I think maybe we could leave this convention behind? @syl20bnr

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

I'm currently working in having a way to easily add custom perspectives and even having a microstate for them so please don't merge this one yet

Contributor

CestDiego commented Sep 1, 2015

I'm currently working in having a way to easily add custom perspectives and even having a microstate for them so please don't merge this one yet

@sooheon

This comment has been minimized.

Show comment
Hide comment
@sooheon

sooheon Sep 1, 2015

Contributor

Great, I'm already enjoying the old perspectives layer, but the loading could be wonky. Curious what are the benefits of microstate over a hydra?

Contributor

sooheon commented Sep 1, 2015

Great, I'm already enjoying the old perspectives layer, but the loading could be wonky. Curious what are the benefits of microstate over a hydra?

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

for the benefits I think @syl20bnr could elaborate more on that. I'm not really that familiar with hydra either

Contributor

CestDiego commented Sep 1, 2015

for the benefits I think @syl20bnr could elaborate more on that. I'm not really that familiar with hydra either

@robbyoconnor

This comment has been minimized.

Show comment
Hide comment
@robbyoconnor

robbyoconnor Sep 1, 2015

Contributor

I like microstates personally

Contributor

robbyoconnor commented Sep 1, 2015

I like microstates personally

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Sep 1, 2015

Owner

microstates and hydra are the same thing, hydra is more powerful but:

  1. I don't like the hydra API which is not obvious
  2. we need a custom solution that better fit spacemacs need (evil-leader, vim, holy-mode etc...)

I may in the future use hydras as backend for some part of the microstates but we will always have our own macro.

Owner

syl20bnr commented Sep 1, 2015

microstates and hydra are the same thing, hydra is more powerful but:

  1. I don't like the hydra API which is not obvious
  2. we need a custom solution that better fit spacemacs need (evil-leader, vim, holy-mode etc...)

I may in the future use hydras as backend for some part of the microstates but we will always have our own macro.

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

I would love for spacemacs microstates to achieve something like this: http://emacs.stackexchange.com/a/14293

alt

Contributor

CestDiego commented Sep 1, 2015

I would love for spacemacs microstates to achieve something like this: http://emacs.stackexchange.com/a/14293

alt

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Sep 1, 2015

Owner

Hydra does not use magit-popup AFAIK.
For the API part check what the API can give: https://github.com/abo-abo/hydra/wiki/Rectangle-Operations
I find it very unintuitive and does not fit with what I want for such important part in Spacemacs.

Owner

syl20bnr commented Sep 1, 2015

Hydra does not use magit-popup AFAIK.
For the API part check what the API can give: https://github.com/abo-abo/hydra/wiki/Rectangle-Operations
I find it very unintuitive and does not fit with what I want for such important part in Spacemacs.

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Sep 1, 2015

Owner

I would love for spacemacs microstates to achieve something like this: http://emacs.stackexchange.com/a/14293

That's cool, we should be able to do this in microstates.
BTW the cote above the screenshot is very missleading, the twitter hydra is more complicated than that.

Owner

syl20bnr commented Sep 1, 2015

I would love for spacemacs microstates to achieve something like this: http://emacs.stackexchange.com/a/14293

That's cool, we should be able to do this in microstates.
BTW the cote above the screenshot is very missleading, the twitter hydra is more complicated than that.

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Sep 1, 2015

Owner

The twitter hydra is here: https://github.com/abo-abo/hydra/wiki/Twittering
It illustrates one point I don't like about hydras: it makes you write unreadable docstring in the code... this is ridiculous.
There is now a column keyword though so the point above is less a pain point, as I said I may use hydra as backend for microstate, the point is to use the powerful hydra feature but hide the awkward API.

Owner

syl20bnr commented Sep 1, 2015

The twitter hydra is here: https://github.com/abo-abo/hydra/wiki/Twittering
It illustrates one point I don't like about hydras: it makes you write unreadable docstring in the code... this is ridiculous.
There is now a column keyword though so the point above is less a pain point, as I said I may use hydra as backend for microstate, the point is to use the powerful hydra feature but hide the awkward API.

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

what could we do then? it may be unreadable but the ^ symbols have to be there for formatting I guess? ... what solution could we implement instead? I think micro-states have the potential to be one of the killer features of spacemacs, :3 but I don't undestand how they work yet :(

Contributor

CestDiego commented Sep 1, 2015

what could we do then? it may be unreadable but the ^ symbols have to be there for formatting I guess? ... what solution could we implement instead? I think micro-states have the potential to be one of the killer features of spacemacs, :3 but I don't undestand how they work yet :(

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Sep 1, 2015

Owner

They work exactly like a hydra, this is the same thing underneath (look for transient maps in Emacs doc).
You wrote several micro-states but you don't know how they work ? :-)

Owner

syl20bnr commented Sep 1, 2015

They work exactly like a hydra, this is the same thing underneath (look for transient maps in Emacs doc).
You wrote several micro-states but you don't know how they work ? :-)

@robbyoconnor

This comment has been minimized.

Show comment
Hide comment
@robbyoconnor

robbyoconnor Sep 1, 2015

Contributor

To be fair, I barely understand emacs lisp :P

On Tuesday, September 1, 2015, Sylvain Benner notifications@github.com
wrote:

They work exactly like a hydra, this is the same thing underneath (look
for transient maps in Emacs doc).
You wrote several micro-states but you don't know how they work ? :-)


Reply to this email directly or view it on GitHub
#2845 (comment).

-Rob

Contributor

robbyoconnor commented Sep 1, 2015

To be fair, I barely understand emacs lisp :P

On Tuesday, September 1, 2015, Sylvain Benner notifications@github.com
wrote:

They work exactly like a hydra, this is the same thing underneath (look
for transient maps in Emacs doc).
You wrote several micro-states but you don't know how they work ? :-)


Reply to this email directly or view it on GitHub
#2845 (comment).

-Rob

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

I'm familiar with the api and way to create ones but I mean the internals...I just look and the macro and hide on the corner scared of the backquotes and @ signs... :( I just read the docstring. I'm working on a hacky way of using micro-states for custom-perspectives, by having the create-custom-persp macro I found save items of the form ("keybinding" . function) into an alist that I will then walk to define the custom-perspectives macro...of course it would be awesome just to put an alist in the micro-states macro and it to recognize it and parse it like:

:bindings
alist-here
"h" foo-bar-function

allis-here being:

'(("l" is-for-the-way-you-look-at-me)
  ("o" is-for-all-the-only-one-I-see))
``
etc etc
Contributor

CestDiego commented Sep 1, 2015

I'm familiar with the api and way to create ones but I mean the internals...I just look and the macro and hide on the corner scared of the backquotes and @ signs... :( I just read the docstring. I'm working on a hacky way of using micro-states for custom-perspectives, by having the create-custom-persp macro I found save items of the form ("keybinding" . function) into an alist that I will then walk to define the custom-perspectives macro...of course it would be awesome just to put an alist in the micro-states macro and it to recognize it and parse it like:

:bindings
alist-here
"h" foo-bar-function

allis-here being:

'(("l" is-for-the-way-you-look-at-me)
  ("o" is-for-all-the-only-one-I-see))
``
etc etc
@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Sep 1, 2015

Owner

What do you want to achieve with the perspective micro-state ? Is it something like eyebrowse ?

Owner

syl20bnr commented Sep 1, 2015

What do you want to achieve with the perspective micro-state ? Is it something like eyebrowse ?

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

@syl20bnr yes, it is working already D:

Contributor

CestDiego commented Sep 1, 2015

@syl20bnr yes, it is working already D:

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

see above ^

Contributor

CestDiego commented Sep 1, 2015

see above ^

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Sep 1, 2015

Owner

ok so what do you want to do that does not work ?

Owner

syl20bnr commented Sep 1, 2015

ok so what do you want to do that does not work ?

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

Custom perspectives can be defined by the user, this are perspectives that are not from projectile but let's say a perspective that open Rcirc with 4 channels opened. I want all custom perspectives, created with the spacemacs/create-custom-persp macro to be added into a variable, then create a microstate with the custom-perspectives

Contributor

CestDiego commented Sep 1, 2015

Custom perspectives can be defined by the user, this are perspectives that are not from projectile but let's say a perspective that open Rcirc with 4 channels opened. I want all custom perspectives, created with the spacemacs/create-custom-persp macro to be added into a variable, then create a microstate with the custom-perspectives

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Sep 1, 2015

Owner

I see, I wonder why you need to differentiate perspecitves and custom perspectives, I don't know perpsective :-)

Owner

syl20bnr commented Sep 1, 2015

I see, I wonder why you need to differentiate perspecitves and custom perspectives, I don't know perpsective :-)

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Sep 1, 2015

Owner

Why not having both in the same micro-state ?

Owner

syl20bnr commented Sep 1, 2015

Why not having both in the same micro-state ?

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

oh...the perspectives micro-state is for changing between opened perspectives... while custom perspectives create user-defined ones.

Contributor

CestDiego commented Sep 1, 2015

oh...the perspectives micro-state is for changing between opened perspectives... while custom perspectives create user-defined ones.

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Sep 1, 2015

Owner

oh ok, you may consider renaming the micro-state to incorporate a verb then, maybe manage ?

Owner

syl20bnr commented Sep 1, 2015

oh ok, you may consider renaming the micro-state to incorporate a verb then, maybe manage ?

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

think about the normal eyebrowse like perspective being able to change between 1-9 workspaces, but then there are special perspectives you can spawn, that have a special meaning, like IRC, or Twitter, or Jabber

Contributor

CestDiego commented Sep 1, 2015

think about the normal eyebrowse like perspective being able to change between 1-9 workspaces, but then there are special perspectives you can spawn, that have a special meaning, like IRC, or Twitter, or Jabber

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

will do thanks for the suggestion. I guess I could make a youtube video explaining how to use them D:

Contributor

CestDiego commented Sep 1, 2015

will do thanks for the suggestion. I guess I could make a youtube video explaining how to use them D:

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Sep 1, 2015

Owner

OK, very much like eyebrowse then, I would put 1-9 for projectile perspectives and S-0, S-9 (shift) for custom ones.
Maybe on 2 different lines.

Owner

syl20bnr commented Sep 1, 2015

OK, very much like eyebrowse then, I would put 1-9 for projectile perspectives and S-0, S-9 (shift) for custom ones.
Maybe on 2 different lines.

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

@syl20bnr thing is perspectives orders them alphabetically... so they change each time

Contributor

CestDiego commented Sep 1, 2015

@syl20bnr thing is perspectives orders them alphabetically... so they change each time

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Sep 1, 2015

Owner

That's good to have them sorted since they are created dynamically, some order cannot hurt :-)

Owner

syl20bnr commented Sep 1, 2015

That's good to have them sorted since they are created dynamically, some order cannot hurt :-)

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

huh? well I'll try to wrap this out to review :)

Contributor

CestDiego commented Sep 1, 2015

huh? well I'll try to wrap this out to review :)

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Sep 1, 2015

Owner

I'll give it a try, I have the impression that the perfect solution would be a mix of perspective and eyebrowse.

Owner

syl20bnr commented Sep 1, 2015

I'll give it a try, I have the impression that the perfect solution would be a mix of perspective and eyebrowse.

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

I tried mixing eyebrowse and perspectives but eyebrowse doesn't obey perspectives isolation of buffers

Contributor

CestDiego commented Sep 1, 2015

I tried mixing eyebrowse and perspectives but eyebrowse doesn't obey perspectives isolation of buffers

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Sep 1, 2015

Owner

Is it possible with perspective to have SPC b b listing all the opened buffers (not scoped to the current perspective) ?

Owner

syl20bnr commented Sep 1, 2015

Is it possible with perspective to have SPC b b listing all the opened buffers (not scoped to the current perspective) ?

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

you mean SPC b b?

Contributor

CestDiego commented Sep 1, 2015

you mean SPC b b?

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Sep 1, 2015

Owner

Yes :-) I fixed it too late.

Owner

syl20bnr commented Sep 1, 2015

Yes :-) I fixed it too late.

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

I think one could advide the SPC b b to define the buffer list to the global buffer list...like C-x C-b does

Contributor

CestDiego commented Sep 1, 2015

I think one could advide the SPC b b to define the buffer list to the global buffer list...like C-x C-b does

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Sep 1, 2015

Contributor

just like I make SPC u SPC p p to open helm-projectile without changing perspectives. SPC u SPC b b could list all buffers.

Contributor

CestDiego commented Sep 1, 2015

just like I make SPC u SPC p p to open helm-projectile without changing perspectives. SPC u SPC b b could list all buffers.

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Sep 1, 2015

Owner

SPC u SPC b b then ?
I may switch to perspective if there is an easy way to choose the scope when looking for an opened buffer.

Owner

syl20bnr commented Sep 1, 2015

SPC u SPC b b then ?
I may switch to perspective if there is an easy way to choose the scope when looking for an opened buffer.

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

you !

Owner

syl20bnr commented Nov 5, 2015

you !

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

💜

Owner

syl20bnr commented Nov 5, 2015

💜

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

This

Owner

syl20bnr commented Nov 5, 2015

This

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

AWESOME

Owner

syl20bnr commented Nov 5, 2015

AWESOME

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

layer

Owner

syl20bnr commented Nov 5, 2015

layer

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr
Owner

syl20bnr commented Nov 5, 2015

is

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

now

Owner

syl20bnr commented Nov 5, 2015

now

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

merged

Owner

syl20bnr commented Nov 5, 2015

merged

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr
Owner

syl20bnr commented Nov 5, 2015

in

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

develop

Owner

syl20bnr commented Nov 5, 2015

develop

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

branch

Owner

syl20bnr commented Nov 5, 2015

branch

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr
Owner

syl20bnr commented Nov 5, 2015

so

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

everyone

Owner

syl20bnr commented Nov 5, 2015

everyone

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

can

Owner

syl20bnr commented Nov 5, 2015

can

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

now

Owner

syl20bnr commented Nov 5, 2015

now

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

test

Owner

syl20bnr commented Nov 5, 2015

test

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr
Owner

syl20bnr commented Nov 5, 2015

it

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr
Owner

syl20bnr commented Nov 5, 2015

I

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

swapped

Owner

syl20bnr commented Nov 5, 2015

swapped

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

the bindings

Owner

syl20bnr commented Nov 5, 2015

the bindings

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

for

Owner

syl20bnr commented Nov 5, 2015

for

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

avy-jump-line

Owner

syl20bnr commented Nov 5, 2015

avy-jump-line

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

and

Owner

syl20bnr commented Nov 5, 2015

and

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

perspective micro-state

Owner

syl20bnr commented Nov 5, 2015

perspective micro-state

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

because

Owner

syl20bnr commented Nov 5, 2015

because

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

scopes

Owner

syl20bnr commented Nov 5, 2015

scopes

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

have

Owner

syl20bnr commented Nov 5, 2015

have

@person808

This comment has been minimized.

Show comment
Hide comment
@person808

person808 Nov 5, 2015

Contributor

MOO

  • Interrupting cow
Contributor

person808 commented Nov 5, 2015

MOO

  • Interrupting cow
@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

lower case

Owner

syl20bnr commented Nov 5, 2015

lower case

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

keys

Owner

syl20bnr commented Nov 5, 2015

keys

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

thanks @person808 , I was going to hit 300 :-D

Thank you @CestDiego, tremendous work on this one, I hope we will be able to make it the official layout solution for Spacemacs 👍 💜

Owner

syl20bnr commented Nov 5, 2015

thanks @person808 , I was going to hit 300 :-D

Thank you @CestDiego, tremendous work on this one, I hope we will be able to make it the official layout solution for Spacemacs 👍 💜

@syl20bnr syl20bnr closed this Nov 5, 2015

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

BTW I hope I did not forget any commit, the history was indeed pretty funky :-)

Owner

syl20bnr commented Nov 5, 2015

BTW I hope I did not forget any commit, the history was indeed pretty funky :-)

@joehillen

This comment has been minimized.

Show comment
Hide comment
@joehillen

joehillen Nov 5, 2015

Contributor

😂

Contributor

joehillen commented Nov 5, 2015

😂

@dvcrn

This comment has been minimized.

Show comment
Hide comment
@dvcrn

dvcrn Nov 5, 2015

Contributor

screen shot 2015-11-05 at 2 35 45 pm

my inbox exploded

Contributor

dvcrn commented Nov 5, 2015

screen shot 2015-11-05 at 2 35 45 pm

my inbox exploded

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 5, 2015

Owner

Oops, I did not think about email spamming... my bad, sorry for this... time to go to bed I guess!

Owner

syl20bnr commented Nov 5, 2015

Oops, I did not think about email spamming... my bad, sorry for this... time to go to bed I guess!

@robbyoconnor

This comment has been minimized.

Show comment
Hide comment
@robbyoconnor

robbyoconnor Nov 5, 2015

Contributor

@syl20bnr this is okay -- Spamming is okay :)

Contributor

robbyoconnor commented Nov 5, 2015

@syl20bnr this is okay -- Spamming is okay :)

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Nov 5, 2015

Contributor

Thank you all for the work on this branch! :) @cmccloud @TheBB @syl20bnr @person808 and everyone that helped in the process.

Contributor

CestDiego commented Nov 5, 2015

Thank you all for the work on this branch! :) @cmccloud @TheBB @syl20bnr @person808 and everyone that helped in the process.

@CestDiego CestDiego deleted the CestDiego:perspectives-fix branch Nov 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment