New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New design implementation #3604

Merged
merged 63 commits into from Jan 4, 2016

Conversation

Projects
None yet
@boyanangelov
Contributor

boyanangelov commented Oct 30, 2015

Here is the new design for the website. I tried to follow the ideas shared in #1423. Would be great to get some feedback!

Live demo: http://boyanangelov.com/spacemacs/
Here are some screens:

screen shot 2015-11-05 at 16 46 37
screen shot 2015-11-12 at 09 54 52
screen shot 2015-11-12 at 09 55 00

@d12frosted

This comment has been minimized.

Show comment
Hide comment
@d12frosted

d12frosted Oct 30, 2015

Collaborator

WOW

Update Sorry for short comment - wanted to describe how much like what I see.

Collaborator

d12frosted commented Oct 30, 2015

WOW

Update Sorry for short comment - wanted to describe how much like what I see.

@cpaulik

This comment has been minimized.

Show comment
Hide comment
@cpaulik

cpaulik Oct 30, 2015

Contributor

Why share screens when the site is online at http://boyanangelov.com/spacemacs/ ?

Anyway I think it looks great although very familiar. But maybe I'm just a little bit annoyed that all the sites tend to look so similar nowadays.

Contributor

cpaulik commented Oct 30, 2015

Why share screens when the site is online at http://boyanangelov.com/spacemacs/ ?

Anyway I think it looks great although very familiar. But maybe I'm just a little bit annoyed that all the sites tend to look so similar nowadays.

@TheBB

This comment has been minimized.

Show comment
Hide comment
@TheBB

TheBB Oct 30, 2015

Collaborator

That's sexy.

What I would like to see on this page is the main documentation org files as well as the layer READMEs rendered in something like readthedocs format. Maybe using something like ReadTheOrg? How automatic can we make this?

Collaborator

TheBB commented Oct 30, 2015

That's sexy.

What I would like to see on this page is the main documentation org files as well as the layer READMEs rendered in something like readthedocs format. Maybe using something like ReadTheOrg? How automatic can we make this?

@boyanangelov

This comment has been minimized.

Show comment
Hide comment
@boyanangelov

boyanangelov Oct 30, 2015

Contributor

@d12frosted Thanks, its based on a theme (see the attributions), honestly I didn't do that much :)

@cpaulik Completely agree... Even if those designs are very minimal and work great on mobile, we should try to do something more inventive in the future, I think that would be the spacemacs way :)

@TheBB I will have a look into that.

Contributor

boyanangelov commented Oct 30, 2015

@d12frosted Thanks, its based on a theme (see the attributions), honestly I didn't do that much :)

@cpaulik Completely agree... Even if those designs are very minimal and work great on mobile, we should try to do something more inventive in the future, I think that would be the spacemacs way :)

@TheBB I will have a look into that.

@cpaulik

This comment has been minimized.

Show comment
Hide comment
@cpaulik

cpaulik Oct 30, 2015

Contributor

Could we harmonize the font/spelling of this:

Spacemacs logo

from the README with the website?

I have no opinion on which to choose but I think they should be the same.

A fixed-width font for the logo would also be fitting in my opinion.

Contributor

cpaulik commented Oct 30, 2015

Could we harmonize the font/spelling of this:

Spacemacs logo

from the README with the website?

I have no opinion on which to choose but I think they should be the same.

A fixed-width font for the logo would also be fitting in my opinion.

@robbyoconnor

This comment has been minimized.

Show comment
Hide comment
@robbyoconnor

robbyoconnor Oct 30, 2015

Contributor

I LOVE THIS!

Contributor

robbyoconnor commented Oct 30, 2015

I LOVE THIS!

@robbyoconnor

This comment has been minimized.

Show comment
Hide comment
@robbyoconnor

robbyoconnor Oct 30, 2015

Contributor

Some comments though -- maybe link to both master and develop docs :D

Contributor

robbyoconnor commented Oct 30, 2015

Some comments though -- maybe link to both master and develop docs :D

@TheBB

This comment has been minimized.

Show comment
Hide comment
@TheBB

TheBB Oct 30, 2015

Collaborator

Following up on the documentation thing. I was able to convert doc/DOCUMENATION.org into a format that enabled it to be exported to HTML. Then applying the theme was not difficult.

result

Mostly the difficulty is supporting both github and org-mode style links at the same time. I wasn't able to export until I had converted all links to org style. The disadvantage with this is that the doc files are no longer useful on github. IF we can get all of them on spacemacs.org, I think that's not necessarily a problem. We can make that the official way of accessing the docs online, and reading it in Emacs is still not a problem. The README.md file would stay and the links there could be updated to point to spacemacs.org.

Another useful side-effect is that exporting the org files is a great way to find broken links and other doc bugs that go undetected.

Thoughts?

You can see my work in my readthedocs branch. It basically consists of:

  • changing all the links
  • adding the style headers

It is of course also possible to write a spacemacs/export-documentation function that does all this automatically, to generate files that can then be pushed into the gh-pages branch. Presumably we would have to write such a function eventually anyway (to deal with all the different org files we have simultaneously), but this way strikes me as the path of least (but not little) resistance and maximal awesomeness.

Collaborator

TheBB commented Oct 30, 2015

Following up on the documentation thing. I was able to convert doc/DOCUMENATION.org into a format that enabled it to be exported to HTML. Then applying the theme was not difficult.

result

Mostly the difficulty is supporting both github and org-mode style links at the same time. I wasn't able to export until I had converted all links to org style. The disadvantage with this is that the doc files are no longer useful on github. IF we can get all of them on spacemacs.org, I think that's not necessarily a problem. We can make that the official way of accessing the docs online, and reading it in Emacs is still not a problem. The README.md file would stay and the links there could be updated to point to spacemacs.org.

Another useful side-effect is that exporting the org files is a great way to find broken links and other doc bugs that go undetected.

Thoughts?

You can see my work in my readthedocs branch. It basically consists of:

  • changing all the links
  • adding the style headers

It is of course also possible to write a spacemacs/export-documentation function that does all this automatically, to generate files that can then be pushed into the gh-pages branch. Presumably we would have to write such a function eventually anyway (to deal with all the different org files we have simultaneously), but this way strikes me as the path of least (but not little) resistance and maximal awesomeness.

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Oct 30, 2015

Owner

@bobbyangelov Thank you so much! My feedback in random order:

  • I like the layout and the straight to the point presentation.
  • I don't like so much is the gradient and the choice of colors which make the logo not very visible.
  • I like the idea of keeping the theme of space in the colors, so something more dark as a background that place the Emacs planet in context would be wonderful. I also like the "pun" with _Space_macs.

Anyway this iteration is already a huge improvement over the current broken site and we are free to tune the theme later. But if you (everybody) have some alternate propositions before we upload it, don't hesitate :-)

@cpaulik I agree, would be great to have the fonts match.

I add @nashamri in the loop who is the author of the logo.

@TheBB Excellent ! I'm for more flexibility so being stuck on the GitHub platform for the doc is not something that I'm fond of. Moving the doc to a website is an appealing option.

Owner

syl20bnr commented Oct 30, 2015

@bobbyangelov Thank you so much! My feedback in random order:

  • I like the layout and the straight to the point presentation.
  • I don't like so much is the gradient and the choice of colors which make the logo not very visible.
  • I like the idea of keeping the theme of space in the colors, so something more dark as a background that place the Emacs planet in context would be wonderful. I also like the "pun" with _Space_macs.

Anyway this iteration is already a huge improvement over the current broken site and we are free to tune the theme later. But if you (everybody) have some alternate propositions before we upload it, don't hesitate :-)

@cpaulik I agree, would be great to have the fonts match.

I add @nashamri in the loop who is the author of the logo.

@TheBB Excellent ! I'm for more flexibility so being stuck on the GitHub platform for the doc is not something that I'm fond of. Moving the doc to a website is an appealing option.

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Oct 30, 2015

Owner

Also would it be possible to try a gradient from top to bottom instead of from left to right ?

Crazy idea would be to go from space to the land of the Emacs planet, with somewhere the orbiting Evil flagship.

The horizon line the atmosphere of the planet could mark the start of the description of the feature.

Owner

syl20bnr commented Oct 30, 2015

Also would it be possible to try a gradient from top to bottom instead of from left to right ?

Crazy idea would be to go from space to the land of the Emacs planet, with somewhere the orbiting Evil flagship.

The horizon line the atmosphere of the planet could mark the start of the description of the feature.

@boyanangelov

This comment has been minimized.

Show comment
Hide comment
@boyanangelov

boyanangelov Oct 30, 2015

Contributor

@syl20bnr I have an idea about the gradient background 🎨! I will work on that, the logo and a few minor things and then submit for one more round of feedback.

@TheBB that looks very cool! I'm not sure if I can help you, but tell me if there's something I can do.

thank you @robbyoconnor :-)

Contributor

boyanangelov commented Oct 30, 2015

@syl20bnr I have an idea about the gradient background 🎨! I will work on that, the logo and a few minor things and then submit for one more round of feedback.

@TheBB that looks very cool! I'm not sure if I can help you, but tell me if there's something I can do.

thank you @robbyoconnor :-)

@TheBB

This comment has been minimized.

Show comment
Hide comment
@TheBB

TheBB Oct 30, 2015

Collaborator

@bobbyangelov It's fine. I will keep working on this and I might make a PR against your branch eventually. You don't have to wait for me though, if you finish up then I can make another PR against gh-pages later on.

Collaborator

TheBB commented Oct 30, 2015

@bobbyangelov It's fine. I will keep working on this and I might make a PR against your branch eventually. You don't have to wait for me though, if you finish up then I can make another PR against gh-pages later on.

@boyanangelov

This comment has been minimized.

Show comment
Hide comment
@boyanangelov

boyanangelov Oct 30, 2015

Contributor

Cool 👍

Contributor

boyanangelov commented Oct 30, 2015

Cool 👍

@stormpat

This comment has been minimized.

Show comment
Hide comment
@stormpat

stormpat Oct 30, 2015

Contributor

@bobbyangelov Very nice work!

Contributor

stormpat commented Oct 30, 2015

@bobbyangelov Very nice work!

@nashamri

This comment has been minimized.

Show comment
Hide comment
@nashamri

nashamri Oct 30, 2015

Contributor

That's great @bobbyangelov.

I would suggest using something like this for the gradient:
sitesuggestion

If you guys like this, I can elaborate on this idea and send it to @bobbyangelov.

Also, I noticed that the shadows are removed from the logo, I don't know if that's intentional or not, but the shadows are meant to be the letter "E" from Emacs 😄 so they are kinda important.

And yeah I'm with @cpaulik for a new font. The font that I put for the logo was almost a place holder 😄

Another note about the screenshot, please use this one
668d207
😄

Contributor

nashamri commented Oct 30, 2015

That's great @bobbyangelov.

I would suggest using something like this for the gradient:
sitesuggestion

If you guys like this, I can elaborate on this idea and send it to @bobbyangelov.

Also, I noticed that the shadows are removed from the logo, I don't know if that's intentional or not, but the shadows are meant to be the letter "E" from Emacs 😄 so they are kinda important.

And yeah I'm with @cpaulik for a new font. The font that I put for the logo was almost a place holder 😄

Another note about the screenshot, please use this one
668d207
😄

@TheBB

This comment has been minimized.

Show comment
Hide comment
@TheBB

TheBB Oct 30, 2015

Collaborator

@bobbyangelov

I can't figure out how to make a PR against your fork, but can you grab this commit from me? 91b5e1f

It includes all the org-files in the doc and layers directories in readthedocs-like format. There are some rough edges but it should be enough to get you started on figuring out how to integrate them into the rest of the site. :-)

Feel free to bring me feedback, there are many things I can change about how this is generated, but I haven't explored it all yet.

For the rest of you, if you want to have a look:

http://thebb.github.io/spacemacs/doc/doc/DOCUMENTATION.html

replace DOCUMENTATION with CONVENTIONS or VIMUSERS or whatever.

Collaborator

TheBB commented Oct 30, 2015

@bobbyangelov

I can't figure out how to make a PR against your fork, but can you grab this commit from me? 91b5e1f

It includes all the org-files in the doc and layers directories in readthedocs-like format. There are some rough edges but it should be enough to get you started on figuring out how to integrate them into the rest of the site. :-)

Feel free to bring me feedback, there are many things I can change about how this is generated, but I haven't explored it all yet.

For the rest of you, if you want to have a look:

http://thebb.github.io/spacemacs/doc/doc/DOCUMENTATION.html

replace DOCUMENTATION with CONVENTIONS or VIMUSERS or whatever.

@boyanangelov

This comment has been minimized.

Show comment
Hide comment
@boyanangelov

boyanangelov Oct 30, 2015

Contributor

@nashamri Love the new background, we should go for it! About the shadows - accidental editing on my part when creating a font logo 😐 Do you have ideas for fonts?

@TheBB Great, will merge that :-)

Contributor

boyanangelov commented Oct 30, 2015

@nashamri Love the new background, we should go for it! About the shadows - accidental editing on my part when creating a font logo 😐 Do you have ideas for fonts?

@TheBB Great, will merge that :-)

@nashamri

This comment has been minimized.

Show comment
Hide comment
@nashamri

nashamri Oct 30, 2015

Contributor

@bobbyangelov Is there a repo for the site? I'm thinking what's the best way to collab on this.

Contributor

nashamri commented Oct 30, 2015

@bobbyangelov Is there a repo for the site? I'm thinking what's the best way to collab on this.

@boyanangelov

This comment has been minimized.

Show comment
Hide comment
@boyanangelov

boyanangelov Oct 30, 2015

Contributor

@nashamri I added you as a collaborator on my fork.

Contributor

boyanangelov commented Oct 30, 2015

@nashamri I added you as a collaborator on my fork.

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Oct 30, 2015

Owner

I like this concept #3604 (comment) ❤️

@TheBB I wonder if we could already merge your changes to the documentation, it will be in develop branch only so it should not bother too much if the links are broken on GitHub while we prepare the website. It would be simpler then for the people working on the website to just take the develop branch as a reference. I'm late on the planed feature for 0.105.0 but I think we could release it combined with the new website and move some 105 items to 106.

Owner

syl20bnr commented Oct 30, 2015

I like this concept #3604 (comment) ❤️

@TheBB I wonder if we could already merge your changes to the documentation, it will be in develop branch only so it should not bother too much if the links are broken on GitHub while we prepare the website. It would be simpler then for the people working on the website to just take the develop branch as a reference. I'm late on the planed feature for 0.105.0 but I think we could release it combined with the new website and move some 105 items to 106.

@TheBB

This comment has been minimized.

Show comment
Hide comment
@TheBB

TheBB Oct 30, 2015

Collaborator

Yeah, we could do that. I already mentally signed off for tonight but I can prepare a PR tomorrow.

Collaborator

TheBB commented Oct 30, 2015

Yeah, we could do that. I already mentally signed off for tonight but I can prepare a PR tomorrow.

@boyanangelov

This comment has been minimized.

Show comment
Hide comment
@boyanangelov

boyanangelov Oct 31, 2015

Contributor

Hi everyone! I pushed the latest changes. I added the links to the documentation from @TheBB , and the background from @nashamri . What do you guys think?

Contributor

boyanangelov commented Oct 31, 2015

Hi everyone! I pushed the latest changes. I added the links to the documentation from @TheBB , and the background from @nashamri . What do you guys think?

@TheBB

This comment has been minimized.

Show comment
Hide comment
@TheBB

TheBB Oct 31, 2015

Collaborator

I left these comments on gitter, copying here for posterity.

  • I like it!
  • I feel /layers/LAYERS.html deserves a link, and possibly a better styling. (I don't know much about styling.)
  • If the quick start should get such a prominent link we should revise its contents. I can do that in #3613.
  • The links under the git clone command are a bit small, I was looking for them and they took me a while to find.
Collaborator

TheBB commented Oct 31, 2015

I left these comments on gitter, copying here for posterity.

  • I like it!
  • I feel /layers/LAYERS.html deserves a link, and possibly a better styling. (I don't know much about styling.)
  • If the quick start should get such a prominent link we should revise its contents. I can do that in #3613.
  • The links under the git clone command are a bit small, I was looking for them and they took me a while to find.
@nashamri

This comment has been minimized.

Show comment
Hide comment
@nashamri

nashamri Oct 31, 2015

Contributor

Super! I love it 👍

Contributor

nashamri commented Oct 31, 2015

Super! I love it 👍

@TheBB

This comment has been minimized.

Show comment
Hide comment
@TheBB

TheBB Oct 31, 2015

Collaborator

Did any of the images from the export make it? Can't see any.

Collaborator

TheBB commented Oct 31, 2015

Did any of the images from the export make it? Can't see any.

@a13ph

This comment has been minimized.

Show comment
Hide comment
@a13ph

a13ph Oct 31, 2015

@bobbyangelov
I like it - it's pretty and not too crowded.

However:

  • Try looking at it on smaller window sizes (emacs and tiling vms are not so rare to live together, and it's simple test for fluidness for mobile browsers too).
  • I screenshot not being displayed cause of fairly eager script blocker. Why do you even need script from ajax.google.com for a screenshot?
  • screenshot is too small and unreadable, even if I try to zoom. Showing off text editor without showing off how it displays text is questionable
  • git clone command box is scrollbarred on small window size, despite there being plenty of width to use.
  • I'm unsure about metaphors, especially "Display" for discoverability. Sure, graphics and all, but display feels way too generalized.
  • "Building blocks" at least have this common phrase going for them, even though it's not quite = consistency.
  • "Fork" is not exactly crowd-configuration symbol, but it's pretty okay with how iconic this symbol is for github collaboration of many flavors and how this (can I even call it our at this point?) project is mostly about configuration of configurations for text environment 🚰 on top of a Lisp Interpreter
  • "Keyboard" does not imply mnemonics, but It gives mental image of mnemonic keybinding layout in just a word and a symbol.
  • which leads to the point of making symbol, big text and small text being coherent in each group together
  • and probably much better if there would be consistency in how big text + small text read together - is that a sentence or being a pair of short slogans or whatever you'd call those phrases.
  • Landing page needs as little text and scrolling as possible, even for such product.
  • User focus should be guided in a most likely path, not flooded with links to various documentations.
  • No license of site or Spacemacs or Emacs anywhere on the site ®️
  • badges are distracting for such a high contrast background
  • contrast between dark and light areas should probably be reduced, page down in darkness may be pretty blinding. It's not even light backgrounds which hurt, but high contrast.
  • That doesn't mean text to background contrast should be low. "Recommend" in Slant badge is guilty of this AND of enormous contrast compared to other, more important elements - even, no, especially if spreading out word about Spacemacs is one of highest priorities.

Some of those are pretty opinionated, but I tried my best to find ways to improve that page.

a13ph commented Oct 31, 2015

@bobbyangelov
I like it - it's pretty and not too crowded.

However:

  • Try looking at it on smaller window sizes (emacs and tiling vms are not so rare to live together, and it's simple test for fluidness for mobile browsers too).
  • I screenshot not being displayed cause of fairly eager script blocker. Why do you even need script from ajax.google.com for a screenshot?
  • screenshot is too small and unreadable, even if I try to zoom. Showing off text editor without showing off how it displays text is questionable
  • git clone command box is scrollbarred on small window size, despite there being plenty of width to use.
  • I'm unsure about metaphors, especially "Display" for discoverability. Sure, graphics and all, but display feels way too generalized.
  • "Building blocks" at least have this common phrase going for them, even though it's not quite = consistency.
  • "Fork" is not exactly crowd-configuration symbol, but it's pretty okay with how iconic this symbol is for github collaboration of many flavors and how this (can I even call it our at this point?) project is mostly about configuration of configurations for text environment 🚰 on top of a Lisp Interpreter
  • "Keyboard" does not imply mnemonics, but It gives mental image of mnemonic keybinding layout in just a word and a symbol.
  • which leads to the point of making symbol, big text and small text being coherent in each group together
  • and probably much better if there would be consistency in how big text + small text read together - is that a sentence or being a pair of short slogans or whatever you'd call those phrases.
  • Landing page needs as little text and scrolling as possible, even for such product.
  • User focus should be guided in a most likely path, not flooded with links to various documentations.
  • No license of site or Spacemacs or Emacs anywhere on the site ®️
  • badges are distracting for such a high contrast background
  • contrast between dark and light areas should probably be reduced, page down in darkness may be pretty blinding. It's not even light backgrounds which hurt, but high contrast.
  • That doesn't mean text to background contrast should be low. "Recommend" in Slant badge is guilty of this AND of enormous contrast compared to other, more important elements - even, no, especially if spreading out word about Spacemacs is one of highest priorities.

Some of those are pretty opinionated, but I tried my best to find ways to improve that page.

Adjustments for mobile styles, font logo replacement, links made more
prominent, screenshot larger, darker background for readability and
other minor changes
@boyanangelov

This comment has been minimized.

Show comment
Hide comment
@boyanangelov

boyanangelov Nov 2, 2015

Contributor

I implemented a few adjustments based on feedback from @a13ph and @TheBB . @TheBB , yes, there is something wrong with the images in the documentation 😕 I hope you guys like the new background, it should make it easier for the eyes.

Contributor

boyanangelov commented Nov 2, 2015

I implemented a few adjustments based on feedback from @a13ph and @TheBB . @TheBB , yes, there is something wrong with the images in the documentation 😕 I hope you guys like the new background, it should make it easier for the eyes.

@TheBB

This comment has been minimized.

Show comment
Hide comment
@TheBB

TheBB Nov 2, 2015

Collaborator

I'll have a look-see on those images.

Collaborator

TheBB commented Nov 2, 2015

I'll have a look-see on those images.

@TheBB

This comment has been minimized.

Show comment
Hide comment
@TheBB

TheBB Nov 2, 2015

Collaborator

Oh, they literally didn't make it, as in they're not there. That should be fixable.

Collaborator

TheBB commented Nov 2, 2015

Oh, they literally didn't make it, as in they're not there. That should be fixable.

@cpaulik

This comment has been minimized.

Show comment
Hide comment
@cpaulik

cpaulik Nov 2, 2015

Contributor

Would it be over the top to theme the documentation like the spacemacs theme?

Contributor

cpaulik commented Nov 2, 2015

Would it be over the top to theme the documentation like the spacemacs theme?

@boyanangelov

This comment has been minimized.

Show comment
Hide comment
@boyanangelov

boyanangelov Nov 2, 2015

Contributor

@cpaulik I'll see what I can do 🎨

Contributor

boyanangelov commented Nov 2, 2015

@cpaulik I'll see what I can do 🎨

@StreakyCobra

This comment has been minimized.

Show comment
Hide comment
@StreakyCobra

StreakyCobra Nov 23, 2015

Contributor
Contributor

StreakyCobra commented Nov 23, 2015

@TheBB

This comment has been minimized.

Show comment
Hide comment
@TheBB

TheBB Nov 23, 2015

Collaborator

If there's a choice, please use 'and'.

Collaborator

TheBB commented Nov 23, 2015

If there's a choice, please use 'and'.

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Nov 27, 2015

Contributor

Can we have this as well somewhere? https://sidecar.gitter.im/ :P

Contributor

CestDiego commented Nov 27, 2015

Can we have this as well somewhere? https://sidecar.gitter.im/ :P

@boyanangelov

This comment has been minimized.

Show comment
Hide comment
@boyanangelov

boyanangelov Nov 28, 2015

Contributor

@CestDiego wow, that's pretty awesome. What do you guys think?

Contributor

boyanangelov commented Nov 28, 2015

@CestDiego wow, that's pretty awesome. What do you guys think?

@nashamri

This comment has been minimized.

Show comment
Hide comment
@nashamri

nashamri Nov 28, 2015

Contributor

That seems pretty cool 👍

Contributor

nashamri commented Nov 28, 2015

That seems pretty cool 👍

@nashamri

This comment has been minimized.

Show comment
Hide comment
@nashamri

nashamri Nov 28, 2015

Contributor

Should we remove the "gitter" button at the top since we have the side chat now?

Contributor

nashamri commented Nov 28, 2015

Should we remove the "gitter" button at the top since we have the side chat now?

@StreakyCobra

This comment has been minimized.

Show comment
Hide comment
@StreakyCobra

StreakyCobra Nov 29, 2015

Contributor

For me we can keep it… or remove it… it doesn't really matter :-p

Otherwise, I can't close the sidecar pane once opened, the close button doesn't seem to be accessible.

Contributor

StreakyCobra commented Nov 29, 2015

For me we can keep it… or remove it… it doesn't really matter :-p

Otherwise, I can't close the sidecar pane once opened, the close button doesn't seem to be accessible.

@nashamri

This comment has been minimized.

Show comment
Hide comment
@nashamri

nashamri Nov 29, 2015

Contributor

@StreakyCobra I've experienced some glitches with the close (X) button. But usually it takes a second or two and sometimes just scrolling the chat window then I can close the side pane.

Contributor

nashamri commented Nov 29, 2015

@StreakyCobra I've experienced some glitches with the close (X) button. But usually it takes a second or two and sometimes just scrolling the chat window then I can close the side pane.

@StreakyCobra

This comment has been minimized.

Show comment
Hide comment
@StreakyCobra

StreakyCobra Nov 29, 2015

Contributor

Ok, it's a matter of scrolling the page, not the chat. It seems that the top menu is above the chat, preventing to access the X button.

Contributor

StreakyCobra commented Nov 29, 2015

Ok, it's a matter of scrolling the page, not the chat. It seems that the top menu is above the chat, preventing to access the X button.

@nashamri

This comment has been minimized.

Show comment
Hide comment
@nashamri

nashamri Nov 29, 2015

Contributor

Seems like a bug in their code. Maybe it could be a css issue? z-index?

Contributor

nashamri commented Nov 29, 2015

Seems like a bug in their code. Maybe it could be a css issue? z-index?

@StreakyCobra

This comment has been minimized.

Show comment
Hide comment
@StreakyCobra

StreakyCobra Nov 29, 2015

Contributor

z-index

It's what I was thinking about, but I'm really not a CSS/web guy :-) If this is the problem maybe you can override it with an !important ?

Contributor

StreakyCobra commented Nov 29, 2015

z-index

It's what I was thinking about, but I'm really not a CSS/web guy :-) If this is the problem maybe you can override it with an !important ?

@boyanangelov

This comment has been minimized.

Show comment
Hide comment
@boyanangelov

boyanangelov Nov 29, 2015

Contributor

@nashamri seems fixed 👍 😀

Contributor

boyanangelov commented Nov 29, 2015

@nashamri seems fixed 👍 😀

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Nov 30, 2015

Owner

This chat sidebar is awesome ! 💜

Funny, the maybe new website for GNU Emacs is somewhat similar for our website (same kind of colors but more vivid and feature circles :-D) http://nicolas-petton.fr/ressources/emacs-website/

Owner

syl20bnr commented Nov 30, 2015

This chat sidebar is awesome ! 💜

Funny, the maybe new website for GNU Emacs is somewhat similar for our website (same kind of colors but more vivid and feature circles :-D) http://nicolas-petton.fr/ressources/emacs-website/

@TheBB TheBB assigned TheBB and unassigned TheBB Nov 30, 2015

@nashamri

This comment has been minimized.

Show comment
Hide comment
@nashamri

nashamri Nov 30, 2015

Contributor

Wow what a coincidence! or not? lol

Contributor

nashamri commented Nov 30, 2015

Wow what a coincidence! or not? lol

@d12frosted

This comment has been minimized.

Show comment
Hide comment
@d12frosted

d12frosted Dec 1, 2015

Collaborator

Wow, nice improvements! Also I like documentation pages. It's a pleasure to read them online. Really good work.

So far I don't like only one thing - how jumpy content is when you press 'install' button (to show or hide cmd).

Collaborator

d12frosted commented Dec 1, 2015

Wow, nice improvements! Also I like documentation pages. It's a pleasure to read them online. Really good work.

So far I don't like only one thing - how jumpy content is when you press 'install' button (to show or hide cmd).

@d12frosted

This comment has been minimized.

Show comment
Hide comment
@d12frosted

d12frosted Dec 1, 2015

Collaborator

Also, sometimes I don't see all round items (don't know how to call them) like in following screenshot:

screenshot 2015-12-01 09 23 56

screenshot 2015-12-01 09 25 20

It happens when I scroll softly. Usually second and forth are not seen for a while.

Update fixed screenshots

Update If you need, I can record video showing it.

Collaborator

d12frosted commented Dec 1, 2015

Also, sometimes I don't see all round items (don't know how to call them) like in following screenshot:

screenshot 2015-12-01 09 23 56

screenshot 2015-12-01 09 25 20

It happens when I scroll softly. Usually second and forth are not seen for a while.

Update fixed screenshots

Update If you need, I can record video showing it.

@CestDiego

This comment has been minimized.

Show comment
Hide comment
@CestDiego

CestDiego Dec 1, 2015

Contributor

can we have http://spacemacs.org serve this now? :(

Contributor

CestDiego commented Dec 1, 2015

can we have http://spacemacs.org serve this now? :(

@StreakyCobra

This comment has been minimized.

Show comment
Hide comment
Contributor

StreakyCobra commented Dec 1, 2015

@nashamri

This comment has been minimized.

Show comment
Hide comment
@nashamri

nashamri Dec 1, 2015

Contributor

Bugs in the docs:

Contributor

nashamri commented Dec 1, 2015

Bugs in the docs:

@TheBB

This comment has been minimized.

Show comment
Hide comment
@TheBB

TheBB Dec 1, 2015

Collaborator

Thanks. I can fix those. May have to go hard on the emojis though.

Collaborator

TheBB commented Dec 1, 2015

Thanks. I can fix those. May have to go hard on the emojis though.

@nashamri

This comment has been minimized.

Show comment
Hide comment
@nashamri

nashamri Dec 1, 2015

Contributor

Oh those emojis! lol
Maybe just create a png of them to make it consistent with the rest of the layers.

Contributor

nashamri commented Dec 1, 2015

Oh those emojis! lol
Maybe just create a png of them to make it consistent with the rest of the layers.

@TheBB

This comment has been minimized.

Show comment
Hide comment
@TheBB

TheBB Dec 2, 2015

Collaborator

Updated the docs!

Collaborator

TheBB commented Dec 2, 2015

Updated the docs!

syl20bnr added a commit that referenced this pull request Jan 4, 2016

@syl20bnr syl20bnr merged commit 3cc82af into syl20bnr:gh-pages Jan 4, 2016

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Jan 4, 2016

Owner

It's in the box, great work guys ! 💜

Owner

syl20bnr commented Jan 4, 2016

It's in the box, great work guys ! 💜

@boyanangelov

This comment has been minimized.

Show comment
Hide comment
@boyanangelov

boyanangelov Jan 4, 2016

Contributor

@syl20bnr great! I am open to start working on a dynamic version in the near future :)

Contributor

boyanangelov commented Jan 4, 2016

@syl20bnr great! I am open to start working on a dynamic version in the near future :)

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Jan 9, 2016

Owner

IMPORTANT @bobbyangelov do not delete your PR branch, I will try to keep the history in spacemacs.org repo, thanks!

Owner

syl20bnr commented Jan 9, 2016

IMPORTANT @bobbyangelov do not delete your PR branch, I will try to keep the history in spacemacs.org repo, thanks!

@boyanangelov

This comment has been minimized.

Show comment
Hide comment
@boyanangelov

boyanangelov Jan 9, 2016

Contributor

@syl20bnr Sure, I'll keep it. Great that you made a new repo, everything is much more organised.

Contributor

boyanangelov commented Jan 9, 2016

@syl20bnr Sure, I'll keep it. Great that you made a new repo, everything is much more organised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment