Skip to content

Make eyebrowse workspaces local to perspective - #4068

Closed
bmag wants to merge 1 commit into
syl20bnr:developfrom
bmag:layout-local-workspaces
Closed

bmag wants to merge 1 commit into
syl20bnr:developfrom
bmag:layout-local-workspaces

Conversation

@bmag

@bmag bmag commented Dec 5, 2015

Copy link
Copy Markdown
Contributor

Integrates persp-mode and eyebrowse, so each perspective has its own set of eyebrowse workspaces.
It works great for me, but would be nice if someone else can also confirm that it works.
This takes care of #3733.

Integrates persp-mode and eyebrowse, so each perspective has its own set
of eyebrowse workspaces.
@syl20bnr

syl20bnr commented Dec 6, 2015

Copy link
Copy Markdown
Owner

This is awesome 💜
I think we should move eyebrowse to spacemacs-layouts and add a layer variable to enable it, I'm not sure if it should be enabled by default though.

Thank you !
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Dec 6, 2015
@TheBB

TheBB commented Dec 6, 2015

Copy link
Copy Markdown
Contributor

Holy shit, you did it!

@d12frosted

Copy link
Copy Markdown
Contributor

Wow, @bmag thank you, this is exactly what I wanted! Going to use it on daily basis.
@TheBB your new key bindings are great to use!

@nixmaniack

Copy link
Copy Markdown
Contributor

This is amazing. @bmag Thanks! 👍

@bmag

bmag commented Dec 6, 2015

Copy link
Copy Markdown
Contributor Author

I think we should move eyebrowse to spacemacs-layouts

@syl20bnr Are you sure about it? Right now a user can have either of the layers or both, and the code is fairly organized.
Moving eyebrowse into spacemacs-layouts will prevent using eyebrowse without spacemacs-layouts, and require a custom way of enabling eyebrowse. What are the advantages? Are they worth it?

@syl20bnr

syl20bnr commented Dec 6, 2015

Copy link
Copy Markdown
Owner

@bmag spacemacs-layouts is part of the distribution and the default perspective does not appear in the mode-line and acts as stock Spacemacs without perspectives, so people can already have eyebrowse without perspective if they don't create any additional perspective.

@bmag

bmag commented Dec 7, 2015

Copy link
Copy Markdown
Contributor Author

OK, so the change still allows people to effectively use eyebrowse without perspectives. So the user just has to enable eyebrowse via layer variable instead of enabling an eyebrowse layer. In that case I have nothing against the change.

Furthermore, it occurred to me that using SPC l <...> just for switching layouts, and SPC b b for switching buffers, effectively means spacemacs-layouts acts the same as eyebrowse (please correct me if I'm wrong). So spacemacs-layouts acts as a superset of eyebrowse. Now we use eyebrowse for perspective-local workspaces, instead of global workspaces, so it just makes sense to move eyebrowse into spacemacs-layouts.

@rphillips

Copy link
Copy Markdown

Thank you! Been looking forward to this.

@tuhdo

tuhdo commented Dec 7, 2015

Copy link
Copy Markdown
Contributor

I really enjoy using this. Thanks.

@nwolfe

nwolfe commented Dec 7, 2015

Copy link
Copy Markdown
Contributor

👍 for combining eyebrowse and spacemacs-layouts layers, with some layer variables for configuration.

@robbyoconnor

Copy link
Copy Markdown
Contributor

drools

@zilongshanren

Copy link
Copy Markdown
Contributor

👍 Awesome!

@spacegoing

Copy link
Copy Markdown

THIS IS SUPERIOUS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.