New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make eyebrowse workspaces local to perspective #4068

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
@bmag
Collaborator

bmag commented Dec 5, 2015

Integrates persp-mode and eyebrowse, so each perspective has its own set of eyebrowse workspaces.
It works great for me, but would be nice if someone else can also confirm that it works.
This takes care of #3733.

Bar Magal
Make eyebrowse workspaces local to perspective
Integrates persp-mode and eyebrowse, so each perspective has its own set
of eyebrowse workspaces.
@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Dec 6, 2015

Owner

This is awesome 💜
I think we should move eyebrowse to spacemacs-layouts and add a layer variable to enable it, I'm not sure if it should be enabled by default though.

Thank you !
Cherry-picked into develop branch, you can safely delete your branch.

Owner

syl20bnr commented Dec 6, 2015

This is awesome 💜
I think we should move eyebrowse to spacemacs-layouts and add a layer variable to enable it, I'm not sure if it should be enabled by default though.

Thank you !
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Dec 6, 2015

@TheBB

This comment has been minimized.

Show comment
Hide comment
@TheBB

TheBB Dec 6, 2015

Collaborator

Holy shit, you did it!

Collaborator

TheBB commented Dec 6, 2015

Holy shit, you did it!

@d12frosted

This comment has been minimized.

Show comment
Hide comment
@d12frosted

d12frosted Dec 6, 2015

Collaborator

Wow, @bmag thank you, this is exactly what I wanted! Going to use it on daily basis.
@TheBB your new key bindings are great to use!

Collaborator

d12frosted commented Dec 6, 2015

Wow, @bmag thank you, this is exactly what I wanted! Going to use it on daily basis.
@TheBB your new key bindings are great to use!

@nixmaniack

This comment has been minimized.

Show comment
Hide comment
@nixmaniack

nixmaniack Dec 6, 2015

Contributor

This is amazing. @bmag Thanks! 👍

Contributor

nixmaniack commented Dec 6, 2015

This is amazing. @bmag Thanks! 👍

@bmag

This comment has been minimized.

Show comment
Hide comment
@bmag

bmag Dec 6, 2015

Collaborator

I think we should move eyebrowse to spacemacs-layouts

@syl20bnr Are you sure about it? Right now a user can have either of the layers or both, and the code is fairly organized.
Moving eyebrowse into spacemacs-layouts will prevent using eyebrowse without spacemacs-layouts, and require a custom way of enabling eyebrowse. What are the advantages? Are they worth it?

Collaborator

bmag commented Dec 6, 2015

I think we should move eyebrowse to spacemacs-layouts

@syl20bnr Are you sure about it? Right now a user can have either of the layers or both, and the code is fairly organized.
Moving eyebrowse into spacemacs-layouts will prevent using eyebrowse without spacemacs-layouts, and require a custom way of enabling eyebrowse. What are the advantages? Are they worth it?

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Dec 6, 2015

Owner

@bmag spacemacs-layouts is part of the distribution and the default perspective does not appear in the mode-line and acts as stock Spacemacs without perspectives, so people can already have eyebrowse without perspective if they don't create any additional perspective.

Owner

syl20bnr commented Dec 6, 2015

@bmag spacemacs-layouts is part of the distribution and the default perspective does not appear in the mode-line and acts as stock Spacemacs without perspectives, so people can already have eyebrowse without perspective if they don't create any additional perspective.

@bmag

This comment has been minimized.

Show comment
Hide comment
@bmag

bmag Dec 7, 2015

Collaborator

OK, so the change still allows people to effectively use eyebrowse without perspectives. So the user just has to enable eyebrowse via layer variable instead of enabling an eyebrowse layer. In that case I have nothing against the change.

Furthermore, it occurred to me that using SPC l <...> just for switching layouts, and SPC b b for switching buffers, effectively means spacemacs-layouts acts the same as eyebrowse (please correct me if I'm wrong). So spacemacs-layouts acts as a superset of eyebrowse. Now we use eyebrowse for perspective-local workspaces, instead of global workspaces, so it just makes sense to move eyebrowse into spacemacs-layouts.

Collaborator

bmag commented Dec 7, 2015

OK, so the change still allows people to effectively use eyebrowse without perspectives. So the user just has to enable eyebrowse via layer variable instead of enabling an eyebrowse layer. In that case I have nothing against the change.

Furthermore, it occurred to me that using SPC l <...> just for switching layouts, and SPC b b for switching buffers, effectively means spacemacs-layouts acts the same as eyebrowse (please correct me if I'm wrong). So spacemacs-layouts acts as a superset of eyebrowse. Now we use eyebrowse for perspective-local workspaces, instead of global workspaces, so it just makes sense to move eyebrowse into spacemacs-layouts.

@rphillips

This comment has been minimized.

Show comment
Hide comment
@rphillips

rphillips Dec 7, 2015

Contributor

Thank you! Been looking forward to this.

Contributor

rphillips commented Dec 7, 2015

Thank you! Been looking forward to this.

@tuhdo

This comment has been minimized.

Show comment
Hide comment
@tuhdo

tuhdo Dec 7, 2015

Contributor

I really enjoy using this. Thanks.

Contributor

tuhdo commented Dec 7, 2015

I really enjoy using this. Thanks.

@nwolfe

This comment has been minimized.

Show comment
Hide comment
@nwolfe

nwolfe Dec 7, 2015

Contributor

👍 for combining eyebrowse and spacemacs-layouts layers, with some layer variables for configuration.

Contributor

nwolfe commented Dec 7, 2015

👍 for combining eyebrowse and spacemacs-layouts layers, with some layer variables for configuration.

@robbyoconnor

This comment has been minimized.

Show comment
Hide comment
@robbyoconnor

robbyoconnor Dec 8, 2015

Contributor

drools

Contributor

robbyoconnor commented Dec 8, 2015

drools

@zilongshanren

This comment has been minimized.

Show comment
Hide comment
@zilongshanren

zilongshanren Jan 5, 2016

Contributor

👍 Awesome!

Contributor

zilongshanren commented Jan 5, 2016

👍 Awesome!

@spacegoing

This comment has been minimized.

Show comment
Hide comment
@spacegoing

spacegoing Feb 18, 2016

THIS IS SUPERIOUS

spacegoing commented Feb 18, 2016

THIS IS SUPERIOUS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment