Don't un-exclude an excluded package #6338

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@darkfeline
Contributor

If a layer using a package is loaded after a layer excluding it, the
exclude flag should not be overwritten.

@darkfeline
Contributor

Should the tests be fixed, or should I approach this bug from a different direction?

@TheBB TheBB added the Core label Jun 15, 2016
@darkfeline darkfeline Don't un-exclude an excluded package
If a layer using a package is loaded after a layer excluding it, the
exclude flag should not be overwritten.
f9c2190
@syl20bnr syl20bnr added Merging... Merged and removed Merging... labels Jul 3, 2016
@syl20bnr syl20bnr self-assigned this Jul 4, 2016
@syl20bnr
Owner
syl20bnr commented Jul 5, 2016

Thank you ! 💯
I fixed the tests and made them more granular in: 8549437
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Jul 5, 2016
@syl20bnr syl20bnr removed the Merged label Jul 5, 2016
@syl20bnr
Owner
syl20bnr commented Jul 5, 2016

Seems that is was the 3000th closed commit so you get the 3000th closed PR achievement!

@darkfeline darkfeline deleted the darkfeline:fix-exclude-override branch Jul 5, 2016
@aaronjensen
Contributor

This prevents explicitly including packages that have been excluded like evil-terminal-cursor-changer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment