Don't un-exclude an excluded package #6338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the tests be fixed, or should I approach this bug from a different direction? |
darkfeline
force-pushed
the
fix-exclude-override
branch
3 times, most recently
from
756a2ef
to
19a786e
Compare
If a layer using a package is loaded after a layer excluding it, the exclude flag should not be overwritten.
darkfeline
force-pushed
the
fix-exclude-override
branch
from
19a786e
to
f9c2190
Compare
|
Thank you ! 💯 |
|
Seems that is was the 3000th closed commit so you get the 3000th closed PR achievement! |
|
This prevents explicitly including packages that have been excluded like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a layer using a package is loaded after a layer excluding it, the
exclude flag should not be overwritten.