Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't un-exclude an excluded package #6338

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@darkfeline
Copy link
Contributor

darkfeline commented Jun 14, 2016

If a layer using a package is loaded after a layer excluding it, the
exclude flag should not be overwritten.

@darkfeline

This comment has been minimized.

Copy link
Contributor Author

darkfeline commented Jun 14, 2016

Should the tests be fixed, or should I approach this bug from a different direction?

@TheBB TheBB added the Core label Jun 15, 2016

@darkfeline darkfeline force-pushed the darkfeline:fix-exclude-override branch 3 times, most recently from 756a2ef to 19a786e Jun 21, 2016

Don't un-exclude an excluded package
If a layer using a package is loaded after a layer excluding it, the
exclude flag should not be overwritten.

@darkfeline darkfeline force-pushed the darkfeline:fix-exclude-override branch from 19a786e to f9c2190 Jul 1, 2016

@syl20bnr syl20bnr added Merging... Merged and removed Merging... labels Jul 3, 2016

@syl20bnr syl20bnr self-assigned this Jul 4, 2016

@syl20bnr

This comment has been minimized.

Copy link
Owner

syl20bnr commented Jul 5, 2016

Thank you ! 💯
I fixed the tests and made them more granular in: 8549437
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Jul 5, 2016

@syl20bnr syl20bnr removed the Merged label Jul 5, 2016

@syl20bnr

This comment has been minimized.

Copy link
Owner

syl20bnr commented Jul 5, 2016

Seems that is was the 3000th closed commit so you get the 3000th closed PR achievement!

@darkfeline darkfeline deleted the darkfeline:fix-exclude-override branch Jul 5, 2016

@aaronjensen

This comment has been minimized.

Copy link
Contributor

aaronjensen commented Jul 6, 2016

This prevents explicitly including packages that have been excluded like evil-terminal-cursor-changer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.