Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix break API changes for ivy 0.8 #6478

Closed

Conversation

@zilongshanren
Copy link
Contributor

@zilongshanren zilongshanren commented Jul 2, 2016

Since ivy 0.8 has some break API changes, the ivy help layer feature is broken.

This PR fix this issue.

For more about ivy 0.8 API break changes:

http://oremacs.com/2016/06/27/ivy-push-view/

@zilongshanren
Copy link
Contributor Author

@zilongshanren zilongshanren commented Jul 2, 2016

This PR also remove a duplicated function definition (defun ivy-spacemacs-help//help-action-add-layer (args) @syl20bnr

fix describe packages

refine

rename car cdr to cadr

fix SPC h l
@zilongshanren zilongshanren force-pushed the zilongshanren:tmp-fix-ivy-0.8 branch from 29b3be7 to 1ca6bab Jul 2, 2016
@@ -253,54 +253,41 @@
(re-search-forward (format "init-%s" package-str))
(beginning-of-line))))

(defun ivy-spacemacs-help//help-action-add-layer (args)

This comment has been minimized.

@zilongshanren

zilongshanren Jul 2, 2016
Author Contributor

This defun is duplicated and useless, so I remove it here.

@syl20bnr syl20bnr added Merging... Merged and removed Merging... labels Jul 3, 2016
@syl20bnr syl20bnr self-assigned this Jul 4, 2016
@syl20bnr
Copy link
Owner

@syl20bnr syl20bnr commented Jul 5, 2016

Excellent 💯
Thank you !
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Jul 5, 2016
@syl20bnr syl20bnr removed the Merged label Jul 5, 2016
@zilongshanren zilongshanren deleted the zilongshanren:tmp-fix-ivy-0.8 branch Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants