/spacemacs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix break API changes for ivy 0.8 #6478

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Reviewers
No reviews
Assignees

@syl20bnr syl20bnr

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zilongshanren @syl20bnr
@zilongshanren
Contributor

zilongshanren commented Jul 2, 2016

Since ivy 0.8 has some break API changes, the ivy help layer feature is broken.

This PR fix this issue.

For more about ivy 0.8 API break changes:

http://oremacs.com/2016/06/27/ivy-push-view/
@zilongshanren

This comment has been minimized.

Sign in to view
Contributor

zilongshanren commented Jul 2, 2016

This PR also remove a duplicated function definition (defun ivy-spacemacs-help//help-action-add-layer (args) @syl20bnr
@zilongshanren
fix break API changes for ivy 0.8 
fix describe packages

refine

rename car cdr to cadr

fix SPC h l
1ca6bab
layers/+completion/ivy/local/ivy-spacemacs-help/ivy-spacemacs-help.el
@@ -253,54 +253,41 @@
(re-search-forward (format "init-%s" package-str))
(beginning-of-line))))
(defun ivy-spacemacs-help//help-action-add-layer (args)

This comment has been minimized.

Sign in to view
Copy link
@zilongshanren

zilongshanren Jul 2, 2016

Contributor

This defun is duplicated and useless, so I remove it here.

@syl20bnr syl20bnr added Merging... Merged and removed Merging... labels Jul 3, 2016

@syl20bnr syl20bnr self-assigned this Jul 4, 2016

@syl20bnr

This comment has been minimized.

Sign in to view
Owner

syl20bnr commented Jul 5, 2016

Excellent 💯
Thank you !
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Jul 5, 2016

@syl20bnr syl20bnr removed the Merged label Jul 5, 2016

@zilongshanren zilongshanren deleted the zilongshanren:tmp-fix-ivy-0.8 branch Jul 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment