New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github layer: secure tokens, timeouts #9504

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
4 participants
@nochiel

nochiel commented Aug 28, 2017

Add:

  • Information on storing API tokens securely. (This replaces the insecure advice that was provided with the layer.)
  • Information about API timeouts and how to avoid them on slow connections.
- Storing security tokens in a world-readable `.gitconfig` is a very …
…bad idea. The emacs

way is to store secure credentials using `authinfo`. ghub.el uses `authinfo` file to
read github API tokens.

- Add information about how to avoid `magithub` timeout errors on a slow connection.
@joehillen

This comment has been minimized.

Show comment
Hide comment
@joehillen

joehillen Aug 28, 2017

Contributor

magithub was recently disabled, so this PR is moot until it's enabled.

Contributor

joehillen commented Aug 28, 2017

magithub was recently disabled, so this PR is moot until it's enabled.

@nochiel

This comment has been minimized.

Show comment
Hide comment
@nochiel

nochiel Aug 29, 2017

magithub was recently disabled, so this PR is moot until it's enabled.

Ha! It was literally disabled a day ago! Thanks for the heads up. I didn't see that commit.

nochiel commented Aug 29, 2017

magithub was recently disabled, so this PR is moot until it's enabled.

Ha! It was literally disabled a day ago! Thanks for the heads up. I didn't see that commit.

@Miciah

This comment has been minimized.

Show comment
Hide comment
@Miciah

Miciah Jun 7, 2018

Magithub has since been re-enabled (#9946), so this PR is no longer moot.

Note that upstream bumped the default timeout up to 3 (vermiculus/magithub@aa4d96a; this PR still says it is 1).

Miciah commented Jun 7, 2018

Magithub has since been re-enabled (#9946), so this PR is no longer moot.

Note that upstream bumped the default timeout up to 3 (vermiculus/magithub@aa4d96a; this PR still says it is 1).

@syl20bnr

This comment has been minimized.

Show comment
Hide comment
@syl20bnr

syl20bnr Jun 16, 2018

Owner
Owner

syl20bnr commented Jun 16, 2018

@nochiel

This comment has been minimized.

Show comment
Hide comment
@nochiel

nochiel Jun 16, 2018

Is this PR still relevant ?

I don't think so.

nochiel commented Jun 16, 2018

Is this PR still relevant ?

I don't think so.

@nochiel nochiel closed this Jun 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment