Add discussion of build context dir for Dockerfile builds #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrudg
approved these changes
Nov 10, 2023
Member
dtrudg
left a comment
dtrudg
left a comment
There was a problem hiding this comment.
LGTM. When it's explained like this I think this is the way forward, as it's the most natural w.r.t. the existing native def file build syntax that people are used to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
Adds discussion of the build context directory in Dockerfile builds, including an example of how to build from a context dir different than where the Dockerfile is located.
See: sylabs/singularity#2342
Also fixes a few extraneous non-anonymized usernames in the surrounding text.