Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using go modules #3184

Merged
merged 4 commits into from Apr 3, 2019

Conversation

Projects
None yet
3 participants
@mem
Copy link
Contributor

mem commented Apr 2, 2019

  • Add go.mod (and the corresponding go.sum)
  • Fix makeit/gengodep so that it lists all the go files that are
    needed to build a particular import path
  • Add internal/pkg/runtime/engines/singularity/plugins.go to have
    something that pulls the relevant plugin code.
  • Remove Gopkg.toml and Gopkg.lock
  • Updated vendor/ with go mod vendor
  • Make sure we are calling the same go compiler in all cases by
    resolving the absolute path only once.
  • Explicitly export GO111MODULE=on to make sure that everything is
    running with module support activated. In particular, this seems
    necessary to build the CNI plugins, as having a go.mod file and
    passing -mod=vendor in that case doesn't seem to be sufficient (go
    still fails to locate the relevant modules).
  • Replace dep with go mod

Signed-off-by: Michael Bauer bauerm@umich.edu
Signed-off-by: Marcelo E. Magallon marcelo@sylabs.io

@cclerget
Copy link
Contributor

cclerget left a comment

Also tested by removing vendor and executing go mod vendor, everything goes back without any issues. Nice work !

Show resolved Hide resolved mlocal/frags/build_network.mk Outdated
Show resolved Hide resolved internal/pkg/runtime/engines/singularity/plugins.go

@cclerget cclerget modified the milestone: Deranged Umbrella Apr 2, 2019

@mem mem force-pushed the mem:go_mod branch 7 times, most recently from d7416d9 to 40e960a Apr 2, 2019

@mem mem changed the title Introduce first iteration of Go1.12 module support Switch to using go modules Apr 2, 2019

@mem mem requested a review from cclerget Apr 2, 2019

@mem mem requested review from cclerget, bauerm97 and sylabs/singularity-maintainers Apr 3, 2019

@mem mem self-assigned this Apr 3, 2019

@mem mem added this to the Deranged Umbrella milestone Apr 3, 2019

@mem

This comment has been minimized.

Copy link
Contributor Author

mem commented Apr 3, 2019

This is connected to issue #3132 because we need some way to ensure the cobra version used when building singularity and the version used when building plugins match. Go modules provide that.

bauerm97 and others added some commits Feb 26, 2019

Switch to using go modules
- Add go.mod (and the corresponding go.sum)
- Fix makeit/gengodep so that it lists all the go files that are
  needed to build a particular import path
- Add internal/pkg/runtime/engines/singularity/plugins.go to have
  something that pulls the relevant plugin code.
- Remove Gopkg.toml and Gopkg.lock
- Updated vendor/ with go mod vendor
- Make sure we are calling the same go compiler in all cases by
  resolving the absolute path only once.
- Explicitly export GO111MODULE=on to make sure that everything is
  running with module support activated. In particular, this seems
  necessary to build the CNI plugins, as having a go.mod file and
  passing -mod=vendor in that case doesn't seem to be sufficient (go
  still fails to locate the relevant modules).
- Replace dep with go mod

Signed-off-by: Michael Bauer <bauerm@umich.edu>
Signed-off-by: Marcelo E. Magallon <marcelo@sylabs.io>
Clean up building of CNI plugins
- Remove some redundant variables and compute values from original list.
- Document the purpose and usage of
  internal/pkg/runtime/engines/singularity/plugins.go

Signed-off-by: Marcelo E. Magallon <marcelo@sylabs.io>
Update Go to 1.11.6
- Change Circle CI configuration to require Go 1.11.6
- Set required Go version to 1.11
- Remove checks that use version 1.10

Signed-off-by: Marcelo E. Magallon <marcelo@sylabs.io>
Up build verbosity in CircleCI
Signed-off-by: Marcelo E. Magallon <marcelo@sylabs.io>

@mem mem force-pushed the mem:go_mod branch from fc1bd6b to 8a4866a Apr 3, 2019

@mem mem merged commit 7af2ef6 into sylabs:master Apr 3, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@mem mem deleted the mem:go_mod branch Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.