New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking an external link in a discourse thread doesn't work the way it should #1

Closed
sylque opened this Issue Oct 31, 2018 · 2 comments

Comments

Projects
None yet
1 participant
@sylque
Copy link
Owner

sylque commented Oct 31, 2018

When clicking a link, the page tries to load but doesn’t succeed.

@sylque

This comment has been minimized.

Copy link
Owner

sylque commented Nov 2, 2018

Fixed in v1.0.2.
The fix is about monkey-patching the redirectTo() method.

@sylque sylque changed the title Clicking external links in a discourse thread confuses Docuss Clicking an external link in a discourse thread doesn't work the way it should Nov 16, 2018

@sylque

This comment has been minimized.

Copy link
Owner

sylque commented Nov 16, 2018

In this issue description, it is said that the target page tries to load but doesn’t succeed.
I believe this corresponds to the specific case where the target page had an iframe prevention scheme. For "normal" external links, I guess the page did load correctly, but within the iframe, which was not the desired behavior anyway.
The provided fix ensures the target page is loaded at the top window level, replacing the whole page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment