Skip to content

The input scitypes for trees are incorrect #28

@ablaom

Description

@ablaom

From here:

    input_scitype    = MMI.Table(MMI.Missing, MMI.Known),           # also ok: MMI.Table(Union{MMI.Missing, MMI.Known}),

What is written in the comment is correct. What is actually used is not:

julia> X = (; x=[missing, 1, 2])
(x = Union{Missing, Int64}[missing, 1, 2],)

julia> scitype(X) <: Table(Missing, Known)
false

julia> scitype(X) <: Table(Union{Missing, Known})
true

For more on the Table scitype constructor, see here.

All the tree scitypes need changing.

Sorry that I did not pick this up in my review.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions