Japanese localization #5

Merged
merged 2 commits into from Apr 3, 2012

Projects

None yet

2 participants

@katsuyoshi
Contributor

Hello sylverb.
Thanks packaging resources as bundle.
I added Japanese localization file.

And I found a issue.
The done and edit buttons in ViewBookmarkViewController was not localized in my environment.
I know it is iOS's responsibility.
I can't find out why it wasn't localized.
If you can solve it please fix it.

Owner
sylverb commented Apr 2, 2012

For the localization issue for done and edit buttons, check last files of my localization commit : 1462b88
You need to add an empty sample/CIALBrowserAsModal/CIALBrowserAsModal/ja.lproj/Localizable.strings in your demo project and everything will be localized as expected ;) Please update your pull request with this and I'll merge it.
Thanks a lot for your contribution !

Contributor

It works fine.
Thanks a lot too.

@sylverb sylverb merged commit 66a115a into sylverb:master Apr 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment