Permalink
Commits on Apr 10, 2018
  1. Merge pull request #360 from creative-commoners/pulls/5.0/update-docs

    robbieaverill committed Apr 10, 2018
    DOCS Update documentation for SS4
  2. DOCS Update documentation for SS4

    raissanorth committed Apr 10, 2018
    This includes replacing screenshots, and updating terminology where necessary as well as making the documentation more consistent as a whole.
Commits on Apr 8, 2018
  1. Merge branch '5.0'

    robbieaverill committed Apr 8, 2018
  2. FIX Update path to template

    raissanorth authored and robbieaverill committed Apr 6, 2018
  3. Merge pull request #357 from creative-commoners/pulls/5.0/update-temp…

    robbieaverill committed Apr 8, 2018
    …late-reference
    
    FIX Update path to template
  4. Update Travis configurations

    raissanorth committed Apr 8, 2018
Commits on Apr 6, 2018
  1. FIX Update path to template

    raissanorth committed Apr 6, 2018
Commits on Apr 3, 2018
  1. Update branch alias to next release target

    NightJar committed Apr 3, 2018
  2. Merge pull request #355 from creative-commoners/pulls/5.0/fix-definit…

    NightJar committed Apr 3, 2018
    …ion-export
    
    FIX Ensure workflow definition exporting works in admin
Commits on Mar 29, 2018
  1. Merge pull request #356 from creative-commoners/pulls/5.0/php-72-travis

    dhensby committed Mar 29, 2018
    Add PHP 7.2 and varying recipe versions to Travis matrix
Commits on Mar 28, 2018
  1. Update phpcs violation in line length

    robbieaverill committed Mar 28, 2018
  2. Add PHP 7.2 and varying recipe versions to Travis matrix

    robbieaverill committed Mar 28, 2018
  3. Update test assertion number of lines to match the empty line added i…

    robbieaverill committed Mar 28, 2018
    …n the template
Commits on Mar 27, 2018
  1. FIX Use correct injector and workflow class namespaces in export temp…

    robbieaverill committed Mar 27, 2018
    …late
  2. Optimise class imports

    robbieaverill committed Mar 27, 2018
  3. FIX Remove import/export CSV buttons, add export CSV action to GridFi…

    robbieaverill committed Mar 27, 2018
    …eld items, fix click handler
Commits on Mar 5, 2018
  1. Merge pull request #351 from creative-commoners/pulls/5.0/mid-flow-re…

    robbieaverill committed Mar 5, 2018
    …adonly
    
    FIX Content should be readonly while processing
  2. Merge pull request #350 from creative-commoners/pulls/5.0/fix-flow-order

    robbieaverill committed Mar 5, 2018
    FIX Set workflow defn. action/transitions order
  3. FIX Content should be readonly while processing

    NightJar committed Mar 5, 2018
    After e.g. a simple 2 step workflow of "request approval" to "publish" has
    begun, content should no longer be editable by the content author until
    the reviewer has either approved or denied the changes. This was broken by
    a bad where clause resulting in the system thinking there were no
    in-progress workflows. Fix this by escaping strings correctly for the
    active database connection (via `Convert` utility class).
Commits on Mar 4, 2018
  1. FIX Set workflow defn. action/transitions order

    NightJar committed Mar 4, 2018
    Previously broken at some point of the upgrade, workflow steps (actions or
    transitions within actions) were no longer orderable in the CMS. This was
    a javascript fault, updating hard-set classnames and correcting the map
    function see this solved.
Commits on Feb 14, 2018
  1. Merge pull request #348 from phptek/non-upgraded-call-to-db

    robbieaverill committed Feb 14, 2018
    FIX: Substituted legacy DataObject::db() for DataObject::getSchema()
  2. FIX: Substituted legacy DataObject::db() for DataObject::getSchema()

    Russell Michell
    Russell Michell committed Feb 14, 2018
Commits on Feb 6, 2018
  1. Merge pull request #345 from creative-commoners/pulls/5.0/publish_app…

    tractorcow committed Feb 6, 2018
    …lication_of_workflow
    
    FIX revert to cascading permission checks for canWorkflowPublish
Commits on Feb 5, 2018
  1. FIX: Do not allow users with only Edit permissions to publish

    raissanorth committed Feb 5, 2018
    By default the permission check on SiteTree::canPublish, which
    canWorkflowPublish uses, falls through an ADMIN check to also
    check the current user against the _edit_ permission. This has
    an unintended side effect of allowing anyone with edit permission
    to be able to publish when a workflow may be intended to prevent
    this.
  2. FIX revert to cascading permission checks for canWorkflowPublish

    raissanorth committed Feb 5, 2018
    SiteTree::canPublish leverages DataExtensions to delegate permission checking,
    and falling back to checking for administrative or canEdit priviliges when
    NULL is returned, and strictly NULL (ie. not FALSE or 0). However
    WorkflowDefinition::canWorkflowPublish short circuits this by explicitly
    returning FALSE when a NULL value is detected, meaning SiteTree's default
    fallbacks are never checked. This had an unfortunate side effect of not letting
    and user with ADMIN permissions `Save & Publish` a page while applying a workflow
    for the first time. By no longer short circuiting and re-instating the default
    cascade of checks, we resolve this fatal error.
Commits on Feb 4, 2018
  1. Merge pull request #344 from creative-commoners/pulls/5.0/update-icon

    robbieaverill committed Feb 4, 2018
    ENHANCEMENT Replace CMS graphic with font icon.
  2. ENHANCEMENT Replace CMS graphic with font icon.

    raissanorth committed Feb 4, 2018
  3. Merge pull request #343 from creative-commoners/pulls/5.0/reset-stage…

    robbieaverill committed Feb 4, 2018
    …-after-set
    
    FIX Update getTarget() function
Commits on Feb 2, 2018
  1. FIX Update getTarget() to reset the stage to the previous mode after …

    raissanorth committed Feb 2, 2018
    …it set it