Skip to content
This repository has been archived by the owner on Jun 10, 2022. It is now read-only.

Task/83 schema changes round2 #85

Merged
merged 12 commits into from
Aug 28, 2019

Conversation

rg911
Copy link
Contributor

@rg911 rg911 commented Aug 27, 2019

Schema changes

  • ModelSchema

    1. chainInfo -> chainStatistic
    2. signer -> signerPublicKey
    3. blockTransactionsHash -> transactionsHash
    4. blockReceiptsHash -> receiptsHash
    5. beneficiary -> beneficiaryPublicKey
  • ModelDescriptor

    1. MosaicDescriptor: mosaicId -> id, Added: [startHeight, ownerPublicKey, ownerAddress, revision`]
    2. MosaicDefinition.mosaicProperty: Restructured the schema (array -> object). Added [duration]
    3. HashLockInfo: account -> senderPublicKey, accountAddress -> senderAddress, mosaic -> 'mosaicId, Added amount, height->endHeight`
    4. SecretLockInfo: account -> senderPublicKey, accountAddress -> senderAddress, mosaic -> mosaicId, Added amount, height -> endHeight, Added compositeHash
    5. Multisig: account -> accountPublicKey, accountAddress -> address
    6. Namespace: owner -> ownerPublicKey
    7. Receipt: BalanceChange.account -> targetPublicKey, BalanceTransfer.sender -> senderPublicKey, BalanceTransfer.recipient -> recipientAddress
  • Transactions

    1. AccountLink: remoteAccountKey -> remotePublicKey,
    2. RegisterNamespace: namespaceId -> id
    3. MosaicDefinition: mosaicId -> id
    4. HashLock: mosaic -> 'mosaicId, Added amount`
    5. SecretLock: mosaic -> 'mosaicId, recipient -> 'recipientAddress, Added amount
    6. SecretProof: recipient -> 'recipientAddress`
    7. Transfer: recipient -> recipientAddress

Issue: #83

@coveralls
Copy link

coveralls commented Aug 27, 2019

Pull Request Test Coverage Report for Build 607

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0005%) to 99.557%

Totals Coverage Status
Change from base Build 598: 0.0005%
Covered Lines: 2748
Relevant Lines: 2753

💛 - Coveralls

catapult-sdk/src/plugins/lockHash.js Show resolved Hide resolved
catapult-sdk/src/plugins/lockSecret.js Show resolved Hide resolved
catapult-sdk/src/plugins/lockSecret.js Outdated Show resolved Hide resolved
catapult-sdk/src/plugins/mosaic.js Outdated Show resolved Hide resolved
catapult-sdk/src/plugins/mosaic.js Outdated Show resolved Hide resolved
catapult-sdk/test/plugins/aggregate_spec.js Outdated Show resolved Hide resolved
catapult-sdk/test/plugins/transfer_spec.js Outdated Show resolved Hide resolved
catapult-sdk/src/model/ModelType.js Outdated Show resolved Hide resolved
rest/src/plugins/mosaic/MosaicDb.js Show resolved Hide resolved
Copy link
Contributor

@Vektrat Vektrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with amount codec changes i think everything else is ok 👍🏼

@Vektrat Vektrat self-requested a review August 28, 2019 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants