Skip to content

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented May 1, 2019

Fixed Issue #123

Problem is in NamespaceService test class. The Before All section randomly throw exceptions. After moved the mocked service into test methods, it seems fine now. Not 100% sure how to fix it in before() but this fix works. Will look around see if there are better solutions.

@coveralls
Copy link

coveralls commented May 1, 2019

Pull Request Test Coverage Report for Build 369

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 79.712%

Totals Coverage Status
Change from base Build 352: 0.5%
Covered Lines: 1505
Relevant Lines: 1774

💛 - Coveralls

@rg911 rg911 requested a review from evias May 1, 2019 09:58
@rg911 rg911 deleted the task/g123_travis_fails branch June 4, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants