Skip to content

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Jun 12, 2019

Step 1 for applying catabuffer.
This PR merged existing flat buffer and schemas.
catabuffer will be added once ready after Library completely merged.

rg911 added 4 commits June 11, 2019 19:41
Merged encoders from Lib into SDK
Merged crypto implementation
Merged existing buffers and schemas
@coveralls
Copy link

Pull Request Test Coverage Report for Build 455

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 78.791%

Totals Coverage Status
Change from base Build 442: 0.03%
Covered Lines: 1683
Relevant Lines: 2021

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 12, 2019

Pull Request Test Coverage Report for Build 466

  • 1252 of 1293 (96.83%) changed or added relevant lines in 34 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+6.1%) to 84.903%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/format/RawUInt64.ts 33 34 97.06%
src/core/crypto/Crypto.ts 97 102 95.1%
src/core/format/Convert.ts 57 63 90.48%
src/core/format/RawAddress.ts 37 44 84.09%
src/core/crypto/Utilities.ts 110 120 91.67%
src/core/crypto/nacl_catapult.ts 676 688 98.26%
Totals Coverage Status
Change from base Build 442: 6.1%
Covered Lines: 2897
Relevant Lines: 3270

💛 - Coveralls

@rg911 rg911 requested a review from evias June 12, 2019 08:45
@rg911 rg911 force-pushed the task/g170_merge_existing_buffer_schema branch from 525e8f1 to f82c312 Compare June 12, 2019 09:09
@rg911 rg911 changed the title Issue #170 Merged existing buffers and schemas 3 - Issue #170 Merged existing buffers and schemas Jun 12, 2019
Grégory Saive and others added 7 commits June 14, 2019 15:38
1 - Issue symbol#93 Merged encoders from Lib into SDK
Merged crypto implementation
…11/nem2-sdk-typescript-javascript into task/g94_merge_crypto_implementation
…entation

2 - Issue: symbol#94 Merge crypto implementation into SDK
Merged existing buffers and schemas
…g911/nem2-sdk-typescript-javascript into task/g170_merge_existing_buffer_schema
@rg911 rg911 deleted the task/g170_merge_existing_buffer_schema branch July 8, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants