Skip to content

[Elephant 2] Mosaic Restriction #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 20, 2019
Merged

[Elephant 2] Mosaic Restriction #202

merged 5 commits into from
Jul 20, 2019

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Jul 12, 2019 •
edited
Loading

Mosaic Restriction

  • Added restrictable in MosaicProperties as a new flag
  • Added MosaicGlobalRestriction and MosaicAddressRestriction transactions
    Including Model, Schema, Buffer, Builder (Flatbuffer applied)
  • Added unit tests and e2e tests for the 2 new txs
  • Added serialization handlers (CreateFromDTO / Payload, SerializeToJSON)
  • Fixed couple of serialization bugs with MosaicId

Note

  • MosaicAddressRestrictionTransaction can only be announced with AggregateTransaction
  • Empty / Null ReferenceMosaicId should use '0' in GlobalTransaction
  • Empty / Null PreviousRestrictionValue should use FFFFFFFFFFFFFFFF in AddressRestriction but 0 in GlobalRestriction

Schema Reference

https://github.com/nemtech/catbuffer/tree/master/schemas/restriction_mosaic

Issue #166

rg911 added 2 commits July 12, 2019 14:35
@rg911
Added symbol#166 Mosaic Restriction
91227d7 
- Added `restrictable` in MosaicProperties
- Added MosaicGlobalRestriction and MosaicAddressRestriction transactions
- Added unit tests and e2e tests for the 2 new txs
- Added serialization handlers
- Fixed couple of serialization bugs with MosaicId
@rg911
Fixed typo
3026973
@coveralls
Copy link

coveralls commented Jul 12, 2019

Pull Request Test Coverage Report for Build 572

  • 453 of 631 (71.79%) changed or added relevant lines in 19 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 60.768%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/infrastructure/builders/MosaicAddressRestrictionTransaction.ts 56 58 96.55%
src/infrastructure/builders/MosaicGlobalRestrictionTransaction.ts 61 63 96.83%
src/model/transaction/MosaicAddressRestrictionTransaction.ts 14 22 63.64%
src/model/transaction/MosaicGlobalRestrictionTransaction.ts 16 26 61.54%
src/infrastructure/buffers/MosaicAddressRestrictionTransactionBuffer.ts 120 196 61.22%
src/infrastructure/buffers/MosaicGlobalRestrictionTransactionBuffer.ts 126 206 61.17%
Totals Coverage Status
Change from base Build 568: -0.02%
Covered Lines: 6359
Relevant Lines: 9032
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 12, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 577

  • 453 of 631 (71.79%) changed or added relevant lines in 19 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 60.777%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/infrastructure/builders/MosaicAddressRestrictionTransaction.ts 56 58 96.55%
src/infrastructure/builders/MosaicGlobalRestrictionTransaction.ts 61 63 96.83%
src/model/transaction/MosaicAddressRestrictionTransaction.ts 14 22 63.64%
src/model/transaction/MosaicGlobalRestrictionTransaction.ts 16 26 61.54%
src/infrastructure/buffers/MosaicAddressRestrictionTransactionBuffer.ts 120 196 61.22%
src/infrastructure/buffers/MosaicGlobalRestrictionTransactionBuffer.ts 126 206 61.17%
Totals Coverage Status
Change from base Build 568: -0.01%
Covered Lines: 6359
Relevant Lines: 9032
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 12, 2019

Pull Request Test Coverage Report for Build 572

  • 453 of 631 (71.79%) changed or added relevant lines in 19 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 60.768%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/infrastructure/builders/MosaicAddressRestrictionTransaction.ts 56 58 96.55%
src/infrastructure/builders/MosaicGlobalRestrictionTransaction.ts 61 63 96.83%
src/model/transaction/MosaicAddressRestrictionTransaction.ts 14 22 63.64%
src/model/transaction/MosaicGlobalRestrictionTransaction.ts 16 26 61.54%
src/infrastructure/buffers/MosaicAddressRestrictionTransactionBuffer.ts 120 196 61.22%
src/infrastructure/buffers/MosaicGlobalRestrictionTransactionBuffer.ts 126 206 61.17%
Totals Coverage Status
Change from base Build 568: -0.02%
Covered Lines: 6359
Relevant Lines: 9032
💛 - Coveralls

evias
evias reviewed Jul 15, 2019
View reviewed changes
evias
evias reviewed Jul 16, 2019
View reviewed changes
@rg911 rg911 deleted the task/g166_mosaic_restriction branch October 8, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@evias evias evias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rg911 @coveralls @evias