Skip to content

Conversation

@evias
Copy link
Contributor

@evias evias commented Jul 21, 2019

Reverts #201

Bugs with CLI after merge :

src/commands/account/generate.ts:128:22 - error TS2345: Argument of type 'Observable<NetworkType>' is not assignable to parameter of type 'ObservableInput<NetworkType>'.
  Type 'Observable<NetworkType>' is not assignable to type 'Subscribable<NetworkType>'.
    Types of property 'subscribe' are incompatible.
      Type '{ (observer?: NextObserver<NetworkType> | ErrorObserver<NetworkType> | CompletionObserver<NetworkType> | undefined): Subscription; (next?: ((value: NetworkType) => void) | undefined, error?: ((error: any) => void) | undefined, complete?: (() => void) | undefined): Subscription; }' is not assignable to type '{ (observer?: NextObserver<NetworkType> | ErrorObserver<NetworkType> | CompletionObserver<NetworkType> | undefined): Unsubscribable; (next: null | undefined, error: null | undefined, complete: () => void): Unsubscribable; (next: null | undefined, error: (error: any) => void, complete?: (() => void) | undefined): Uns...'.
        Types of parameters 'observer' and 'next' are incompatible.
          Type 'null | undefined' is not assignable to type 'NextObserver<NetworkType> | ErrorObserver<NetworkType> | CompletionObserver<NetworkType> | undefined'.
            Type 'null' is not assignable to type 'NextObserver<NetworkType> | ErrorObserver<NetworkType> | CompletionObserver<NetworkType> | undefined'.

128             forkJoin(networkHttp.getNetworkType(), blockHttp.getBlockByHeight(1))
                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~


src/commands/account/generate.ts:129:29 - error TS7006: Parameter 'res' implicitly has an 'any' type.

129                 .subscribe((res) => {
                                ~~~

src/commands/account/generate.ts:140:21 - error TS7006: Parameter 'err' implicitly has an 'any' type.

140                 }, (err) => {
                        ~~~

src/commands/account/info.ts:69:17 - error TS2345: Argument of type 'import("/Users/greg/Sources/nem2/nem2-cli/node_modules/rxjs/internal/types").OperatorFunction<import("/Users/greg/Sources/nem2/nem2-sdk/dist/src/model/account/AccountInfo").AccountInfo, {}>' is not assignable to parameter of type 'import("/Users/greg/Sources/nem2/nem2-sdk/node_modules/rxjs/internal/types").OperatorFunction<import("/Users/greg/Sources/nem2/nem2-sdk/dist/src/model/account/AccountInfo").AccountInfo, {}>'.
  Types of parameters 'source' and 'source' are incompatible.
    Type 'import("/Users/greg/Sources/nem2/nem2-sdk/node_modules/rxjs/internal/Observable").Observable<import("/Users/greg/Sources/nem2/nem2-sdk/dist/src/model/account/AccountInfo").AccountInfo>' is not assignable to type 'import("/Users/greg/Sources/nem2/nem2-cli/node_modules/rxjs/internal/Observable").Observable<import("/Users/greg/Sources/nem2/nem2-sdk/dist/src/model/account/AccountInfo").AccountInfo>'.
      Types of property 'source' are incompatible.
        Type 'import("/Users/greg/Sources/nem2/nem2-sdk/node_modules/rxjs/internal/Observable").Observable<any>' is not assignable to type 'import("/Users/greg/Sources/nem2/nem2-cli/node_modules/rxjs/internal/Observable").Observable<any>'.

 69                 mergeMap((accountInfo: AccountInfo) => mosaicService.mosaicsAmountViewFromAddress(address)
                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 70                     .pipe(
    ~~~~~~~~~~~~~~~~~~~~~~~~~~
... 
 74                             return {mosaics, info: accountInfo};
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 75                         }))),
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@coveralls
Copy link

coveralls commented Jul 21, 2019

Pull Request Test Coverage Report for Build 583

  • 13 of 141 (9.22%) changed or added relevant lines in 14 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 60.768%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/infrastructure/api/networkRoutesApi.ts 0 2 0.0%
src/infrastructure/NamespaceHttp.ts 2 5 40.0%
src/infrastructure/NetworkHttp.ts 3 6 50.0%
src/infrastructure/api/chainRoutesApi.ts 0 4 0.0%
src/infrastructure/api/diagnosticRoutesApi.ts 0 4 0.0%
src/infrastructure/api/nodeRoutesApi.ts 0 4 0.0%
src/infrastructure/TransactionHttp.ts 3 8 37.5%
src/infrastructure/api/mosaicRoutesApi.ts 0 6 0.0%
src/infrastructure/api/namespaceRoutesApi.ts 0 8 0.0%
src/infrastructure/api/blockRoutesApi.ts 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
src/infrastructure/NamespaceHttp.ts 2 18.0%
Totals Coverage Status
Change from base Build 581: 0.3%
Covered Lines: 6359
Relevant Lines: 9032

💛 - Coveralls

@dgarcia360 dgarcia360 deleted the revert-201-task/g195_rxjs_compatibility branch August 29, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants