From 7794317021af2278f5b5ae7dd4cfed7e2d9c67b6 Mon Sep 17 00:00:00 2001 From: Steven Liu Date: Thu, 15 Aug 2019 12:31:17 +0100 Subject: [PATCH 1/4] Removed `this.` in decodeBlock in Utilities.ts --- src/core/format/Utilities.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/format/Utilities.ts b/src/core/format/Utilities.ts index 90a2180655..332433afff 100644 --- a/src/core/format/Utilities.ts +++ b/src/core/format/Utilities.ts @@ -168,8 +168,8 @@ export const decodeChar = (c) => { }; export const decodeBlock = (input, inputOffset, output, outputOffset) => { - const bytes = new Uint8Array(this.Encoded_Block_Size); - for (let i = 0; i < this.Encoded_Block_Size; ++i) { + const bytes = new Uint8Array(Encoded_Block_Size); + for (let i = 0; i < Encoded_Block_Size; ++i) { bytes[i] = decodeChar(input[inputOffset + i]); } From 06d44ddb37816b4f2482e7c8aa734db8ef8d8553 Mon Sep 17 00:00:00 2001 From: Anthony Law Date: Tue, 20 Aug 2019 14:35:35 +0800 Subject: [PATCH 2/4] delete duplicate test. --- e2e/infrastructure/MosaicHttp.spec.ts | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/e2e/infrastructure/MosaicHttp.spec.ts b/e2e/infrastructure/MosaicHttp.spec.ts index 761065e4bd..37717636aa 100644 --- a/e2e/infrastructure/MosaicHttp.spec.ts +++ b/e2e/infrastructure/MosaicHttp.spec.ts @@ -182,19 +182,6 @@ describe('MosaicHttp', () => { }); }); - describe('getMosaics', () => { - it('should return mosaics given array of mosaicIds', (done) => { - mosaicHttp.getMosaics([mosaicId]) - .subscribe((mosaicInfos) => { - expect(mosaicInfos[0].height.lower).not.to.be.null; - expect(mosaicInfos[0].divisibility).to.be.equal(3); - expect(mosaicInfos[0].isSupplyMutable()).to.be.equal(true); - expect(mosaicInfos[0].isTransferable()).to.be.equal(true); - done(); - }); - }); - }); - describe('getMosaicsNames', () => { it('should call getMosaicsNames successfully', (done) => { mosaicHttp.getMosaicsNames([mosaicId]).subscribe((mosaicNames) => { From 9f5d96c4ba58773d8f5ac340b6b98a004a3dd1a7 Mon Sep 17 00:00:00 2001 From: Anthony Law Date: Tue, 20 Aug 2019 15:13:12 +0800 Subject: [PATCH 3/4] fix return wrong duration value Fix return wrong duration value in `getMosaic` --- src/infrastructure/MosaicHttp.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/infrastructure/MosaicHttp.ts b/src/infrastructure/MosaicHttp.ts index 104aee210b..b86fd4b730 100644 --- a/src/infrastructure/MosaicHttp.ts +++ b/src/infrastructure/MosaicHttp.ts @@ -75,7 +75,7 @@ export class MosaicHttp extends Http implements MosaicRepository { divisibility = mosaicInfoDTO.mosaic.properties[MosaicPropertyType.Divisibility].value; } if (mosaicInfoDTO.mosaic.properties[MosaicPropertyType.Duration].value) { - duration = mosaicInfoDTO.mosaic.properties[MosaicPropertyType.Divisibility].value; + duration = mosaicInfoDTO.mosaic.properties[MosaicPropertyType.Duration].value; } return new MosaicInfo( mosaicInfoDTO.meta.id, From 050bdeffe0cb9599fc8b3a059dcade2c653fca20 Mon Sep 17 00:00:00 2001 From: Steven Liu Date: Thu, 15 Aug 2019 12:31:17 +0100 Subject: [PATCH 4/4] Removed `this.` in decodeBlock in Utilities.ts --- src/core/format/Utilities.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/format/Utilities.ts b/src/core/format/Utilities.ts index 90a2180655..332433afff 100644 --- a/src/core/format/Utilities.ts +++ b/src/core/format/Utilities.ts @@ -168,8 +168,8 @@ export const decodeChar = (c) => { }; export const decodeBlock = (input, inputOffset, output, outputOffset) => { - const bytes = new Uint8Array(this.Encoded_Block_Size); - for (let i = 0; i < this.Encoded_Block_Size; ++i) { + const bytes = new Uint8Array(Encoded_Block_Size); + for (let i = 0; i < Encoded_Block_Size; ++i) { bytes[i] = decodeChar(input[inputOffset + i]); }