Skip to content

Prettier - ESLint #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from Apr 14, 2020
Merged

Prettier - ESLint #531

merged 7 commits into from Apr 14, 2020

Conversation

fboucquez
Copy link
Contributor

@fboucquez fboucquez commented Apr 13, 2020

Hi Steve,

I've been working on prettier and eslint. Trying to make them to work together.
Current problems:

  1. TSLint is deprecated and not activated in Travis.
  2. The rules are maintained one by one instead of using more standard rules.
  3. Keeping the autoformatter in the IDEs is annoying and time-consuming. It's not guaranteed that the VSCode formatter would work the same than IntelliJ or Eclipse.
  4. Not every developer would run the formatter (PRs for example) or have the right one.

In this PR:

  1. Removed TS Lint
  2. Enable Prettier
  3. Enable ESLint to work with TS. The rules are the 'recommended ones' plugin:@typescript-eslint/recommended
  4. Prettier integrated with TSLint. If there is a formatting issue (dev didn't execute prettier), eslint test will fail
  5. Removed all the tslint ignore comments. I had to add some // eslint-disable-next-line
  6. Add scripts to package.json
  • npm run prettier it reformats the code using the prettier configuration. The first commit will be big but then we shouldn't have reformatting issues.
  • npm run lint it validates the code style with eslint, it doesn't change the code
  • npm run lint:fix it fixes the code with eslint if possible
  • npm run style:fix runs both prettier and eslint --fix
  1. Reenabled Travis eslint changes with cache
  2. Add a git hook that test eslint (npm run lint)before allowing to commit. We can be sure the style is fine before committing.

TODOs:

  1. I had to warn some of the rules that I think we should fix. Eventually, I would turn them on again. I would create new tasks from them.
  2. Do we want Semicolon?, DONE: YES: we have decided to keep them
  3. The git commit hook may run npm run style:fix, so it styles the code before testing eslint, better chances of getting the modified code right.
  4. Should we use AIRBNB rules or these ones are good enough? In another PR. It seems too restricted and too many changes are required. I would keep the plugin:@typescript-eslint/recommended rules
  5. Remove // eslint-disable-next-line
  6. Migrate require types of imports like const CryptoJS = require('crypto-js'); to import from format

Fixed #407

@fboucquez fboucquez requested a review from rg911 April 13, 2020 14:32
Copy link
Contributor

@rg911 rg911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

PR looks good! I guess we can merge this one first then work on airbnb rules later on!

@rg911 rg911 merged commit bf0ba0a into symbol:master Apr 14, 2020
rg911 added a commit that referenced this pull request Apr 20, 2020
* Post Release (#519)

* v0.17.4 (#514)

* Created `network` folder for network models

* Fixed lint after files moved

* Applied openAPI 0.8.7 changes

* Added tests

* Use UInt64 in retalFees

* Fixed #455
Make namespace max depth configurable in idGenerator

* - Fixed parser bug
- Use rest json payload for unit testing

* restored removed tests to cover models

* Working on travis release process and ts-doc github deployments

* Simplfied BlockHttp
Added BlockHttp unit tests
Changed travis to just report coveralls from one job

* fixed travis

* Uploading multiple versions of ts-docs into git hub pages

* Improved ChainHttp, added unit tests

* Removed maxDepth. Let server run the validation

* Added unit tests

* FIxed #493

* Added tests

* useQuerystring on all https

* Fixed github token env variable name
Added escape skip flag to avoid republishing the same version
Added missing git commit . after version increase

* Update README links

* Update README.md

* Update release.sh

* Update README.md

* Installing typescript globally

* Improved MetadataHttp, added unit tests

* fixed #495

* Fixed #501

* fixed #503

* Refactored MosaicService unit test (#510)

* Fixed #509

* Added mosaicHttp unit tests

* Refactored mosaicHttp to use abstract caller

* Add error trapping unit test

* removed unused error catcher

* add SimpleWallet.toDTO, fixes #504 (#508)

* add SimpleWallet.toDTO, fixes #504

* add word2ua test

* Update README.md (#512)

* v0.17.4 release (#513)

* v0.17.4 release

* Updated md table header

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>

* Trigger release build

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>

* Post release (#520)

* v0.17.4 (#514)

* Created `network` folder for network models

* Fixed lint after files moved

* Applied openAPI 0.8.7 changes

* Added tests

* Use UInt64 in retalFees

* Fixed #455
Make namespace max depth configurable in idGenerator

* - Fixed parser bug
- Use rest json payload for unit testing

* restored removed tests to cover models

* Working on travis release process and ts-doc github deployments

* Simplfied BlockHttp
Added BlockHttp unit tests
Changed travis to just report coveralls from one job

* fixed travis

* Uploading multiple versions of ts-docs into git hub pages

* Improved ChainHttp, added unit tests

* Removed maxDepth. Let server run the validation

* Added unit tests

* FIxed #493

* Added tests

* useQuerystring on all https

* Fixed github token env variable name
Added escape skip flag to avoid republishing the same version
Added missing git commit . after version increase

* Update README links

* Update README.md

* Update release.sh

* Update README.md

* Installing typescript globally

* Improved MetadataHttp, added unit tests

* fixed #495

* Fixed #501

* fixed #503

* Refactored MosaicService unit test (#510)

* Fixed #509

* Added mosaicHttp unit tests

* Refactored mosaicHttp to use abstract caller

* Add error trapping unit test

* removed unused error catcher

* add SimpleWallet.toDTO, fixes #504 (#508)

* add SimpleWallet.toDTO, fixes #504

* add word2ua test

* Update README.md (#512)

* v0.17.4 release (#513)

* v0.17.4 release

* Updated md table header

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>

* Trigger release build

* Creating new version 0.17.5

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>
Co-authored-by: Travis CI User <travis@example.org>

* LockHashAlgorithm (#522)

* Fixed #518
- Added LockHashUtils
- Removed Op_Keccak_256 algorithm
- Renamed HashType to LockHashAlgorithm
- Renamed model field name to be aligned with Catbuffer

* Fixed #521

* - Added Hash method with algorithm input
- Added unit tests
- Added export

* Added networkCurrency resolver for e2e tests (#529)

* Fixed #523
- Added networkCurrency resolver for e2e tests

* trigger travis

* Removed metadata size validation (#527)

* Fixed #526
- Removed metadata size validation

* Added unit tests for coverage

* added unit tests

* improved coverage

* Added check on  Account.signData and PublicAccount.verifySignature for hexadecimal (#528)

* Fixed #252
- Added check on  Account.signData and PublicAccount.verifySignature for hexadecimal

* trigger travis

* Added isHexadecimal argument to account.signData and publicAccount.verifySignature

* Fixed #525

* Removed unused condition

* refactored signData and verifySignature

* Prettier - ESLint (#531)

* eslint and prettier

* working on eslint

* working on eslint

* fixed travis

* rolled back md changes

* Added unit tests

* improved NamespaceHttp

* Fixed eslint warnings (#538)

* Fixed #535
* Fixed #536

* maxFee in Aggregate transactions (#539)

* Fixed #533
- Added setMaxFeeForAggregate
- Changed setMaxFee for stand alone tx only
- Addes getMaxCosignatures
- Added getNetworkMaxCosignaturesPerAggregate

* Fixed typo

* Fixe typo

* Fixed PR review comments

* Added tests

* Fixed #507 (#541)

* upgrade crypto-js to v4.0.0, add AESEncryptionService and apply it to SimpleWallet, fixes  #524 (#530)

* upgrade crypto-js to v4.0.0, add AESEncryptionService and apply it to SimpleWallet, fixes  #524

* remove passwordToPrivateKey, rename toMobileKey by encryptPBKDF2

* accept string as password in AESEncryptionService

* remove unused functions in Crypto, merge AES Encryption service into Crypto

Co-authored-by: Steven Liu <xian.f.liu@gmail.com>

* Alias resolution for accountHttp (#540)

* Fixed #499
- Added AccountService

* Fixed e2e tests

* Fixed lints

* Fixed years

* another year fix

* Chaned to use address array and reduce rest calls

* handle empty array

* Fixed typos

* more typo fix

* Fixed function name

* v0.18.0 release

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>
Co-authored-by: Travis CI User <travis@example.org>
rg911 added a commit that referenced this pull request May 22, 2020
* Post Release (#519)

* v0.17.4 (#514)

* Created `network` folder for network models

* Fixed lint after files moved

* Applied openAPI 0.8.7 changes

* Added tests

* Use UInt64 in retalFees

* Fixed #455
Make namespace max depth configurable in idGenerator

* - Fixed parser bug
- Use rest json payload for unit testing

* restored removed tests to cover models

* Working on travis release process and ts-doc github deployments

* Simplfied BlockHttp
Added BlockHttp unit tests
Changed travis to just report coveralls from one job

* fixed travis

* Uploading multiple versions of ts-docs into git hub pages

* Improved ChainHttp, added unit tests

* Removed maxDepth. Let server run the validation

* Added unit tests

* FIxed #493

* Added tests

* useQuerystring on all https

* Fixed github token env variable name
Added escape skip flag to avoid republishing the same version
Added missing git commit . after version increase

* Update README links

* Update README.md

* Update release.sh

* Update README.md

* Installing typescript globally

* Improved MetadataHttp, added unit tests

* fixed #495

* Fixed #501

* fixed #503

* Refactored MosaicService unit test (#510)

* Fixed #509

* Added mosaicHttp unit tests

* Refactored mosaicHttp to use abstract caller

* Add error trapping unit test

* removed unused error catcher

* add SimpleWallet.toDTO, fixes #504 (#508)

* add SimpleWallet.toDTO, fixes #504

* add word2ua test

* Update README.md (#512)

* v0.17.4 release (#513)

* v0.17.4 release

* Updated md table header

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>

* Trigger release build

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>

* Post release (#520)

* v0.17.4 (#514)

* Created `network` folder for network models

* Fixed lint after files moved

* Applied openAPI 0.8.7 changes

* Added tests

* Use UInt64 in retalFees

* Fixed #455
Make namespace max depth configurable in idGenerator

* - Fixed parser bug
- Use rest json payload for unit testing

* restored removed tests to cover models

* Working on travis release process and ts-doc github deployments

* Simplfied BlockHttp
Added BlockHttp unit tests
Changed travis to just report coveralls from one job

* fixed travis

* Uploading multiple versions of ts-docs into git hub pages

* Improved ChainHttp, added unit tests

* Removed maxDepth. Let server run the validation

* Added unit tests

* FIxed #493

* Added tests

* useQuerystring on all https

* Fixed github token env variable name
Added escape skip flag to avoid republishing the same version
Added missing git commit . after version increase

* Update README links

* Update README.md

* Update release.sh

* Update README.md

* Installing typescript globally

* Improved MetadataHttp, added unit tests

* fixed #495

* Fixed #501

* fixed #503

* Refactored MosaicService unit test (#510)

* Fixed #509

* Added mosaicHttp unit tests

* Refactored mosaicHttp to use abstract caller

* Add error trapping unit test

* removed unused error catcher

* add SimpleWallet.toDTO, fixes #504 (#508)

* add SimpleWallet.toDTO, fixes #504

* add word2ua test

* Update README.md (#512)

* v0.17.4 release (#513)

* v0.17.4 release

* Updated md table header

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>

* Trigger release build

* Creating new version 0.17.5

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>
Co-authored-by: Travis CI User <travis@example.org>

* LockHashAlgorithm (#522)

* Fixed #518
- Added LockHashUtils
- Removed Op_Keccak_256 algorithm
- Renamed HashType to LockHashAlgorithm
- Renamed model field name to be aligned with Catbuffer

* Fixed #521

* - Added Hash method with algorithm input
- Added unit tests
- Added export

* Added networkCurrency resolver for e2e tests (#529)

* Fixed #523
- Added networkCurrency resolver for e2e tests

* trigger travis

* Removed metadata size validation (#527)

* Fixed #526
- Removed metadata size validation

* Added unit tests for coverage

* added unit tests

* improved coverage

* Added check on  Account.signData and PublicAccount.verifySignature for hexadecimal (#528)

* Fixed #252
- Added check on  Account.signData and PublicAccount.verifySignature for hexadecimal

* trigger travis

* Added isHexadecimal argument to account.signData and publicAccount.verifySignature

* Fixed #525

* Removed unused condition

* refactored signData and verifySignature

* Prettier - ESLint (#531)

* eslint and prettier

* working on eslint

* working on eslint

* fixed travis

* rolled back md changes

* Added unit tests

* improved NamespaceHttp

* Fixed eslint warnings (#538)

* Fixed #535
* Fixed #536

* maxFee in Aggregate transactions (#539)

* Fixed #533
- Added setMaxFeeForAggregate
- Changed setMaxFee for stand alone tx only
- Addes getMaxCosignatures
- Added getNetworkMaxCosignaturesPerAggregate

* Fixed typo

* Fixe typo

* Fixed PR review comments

* Added tests

* Fixed #507 (#541)

* upgrade crypto-js to v4.0.0, add AESEncryptionService and apply it to SimpleWallet, fixes  #524 (#530)

* upgrade crypto-js to v4.0.0, add AESEncryptionService and apply it to SimpleWallet, fixes  #524

* remove passwordToPrivateKey, rename toMobileKey by encryptPBKDF2

* accept string as password in AESEncryptionService

* remove unused functions in Crypto, merge AES Encryption service into Crypto

Co-authored-by: Steven Liu <xian.f.liu@gmail.com>

* Alias resolution for accountHttp (#540)

* Fixed #499
- Added AccountService

* Fixed e2e tests

* Fixed lints

* Fixed years

* another year fix

* Chaned to use address array and reduce rest calls

* handle empty array

* Fixed typos

* more typo fix

* Fixed function name

* v0.18.0 release

* Creating new version 0.18.1

* update js docs

* Return distinct cosignature count in aggregateTransactionService (#552)

* Fixed #551

* improved coverage

* added test in account service

* fix typo (#555)

Co-authored-by: Steven Liu <xian.f.liu@gmail.com>

* Gorilla 1 key link transactions and block header updates (#549)

* Applied catbuffer-typescript v0.0.12

* Added voting & vrf key link transactions

* Updated catbuffer to 0.0.13

* Applied catbuffer-typescript v0.0.12

* Added voting & vrf key link transactions

* Updated catbuffer to 0.0.13

* Fixed #556

* Updated catbuffer-typescript lib

* Fixed #558
- Added NodeLinkTransaction

* Fixed #550
- Added block header patch from gorilla 1

* Changed to use supplementalAccountKeys

* Fixed dto bug in network properties

* Fixed #565
- Added new chain properties

* Fixed #563
- Renamed AccountLinkTransaction to AccountKeyLinkTransaction

* Updated repoFactory to use node/info for generationHash

* Fixed tests

* Renamed gernationHashSeed

* - Fixed issues in e2e tests
- Removed incomingTransactionType flags in restriction

* Added shx for cross platform build purposes

* Test coverage

* 0.19.0 release (#567)

* v0.19.0 release note

* v0.19.0: Gorilla.1 schema updates

* Updated changelog

* Fixed #571 (#572)

- Added signature and signer to loadFromPayload

* Listener (WS) refactoring (#570)

* Fixed #569
- Listener filter on recipientAddress and target addresses (publicKeys)
- Now resolving alias

* Improved listener:
1) Added transaction hashes to the subscription
2) Reused methods when subscriptions are the same
3) Improved how aliases are loaded (lazy on demand)

* Refactored regard PR feedbacks

* typo fixed

* Bugs fixed to use super.isSigned

Co-authored-by: fernando <fboucquez@gmail.com>

* Patched with latest catbuffer and openAPI (#576)

* Fixed #575
- Patched with latest catbuffer and openAPI

* Fixed typo

* Split AccountRestrctionFlags into 3 specific flags (#573)

* Fixed #568
Split AccountRestrctionFlags into 3 specific flags

* Listener (WS) refactoring (#570)

* Fixed #569
- Listener filter on recipientAddress and target addresses (publicKeys)
- Now resolving alias

* Improved listener:
1) Added transaction hashes to the subscription
2) Reused methods when subscriptions are the same
3) Improved how aliases are loaded (lazy on demand)

* Refactored regard PR feedbacks

* typo fixed

* Bugs fixed to use super.isSigned

Co-authored-by: fernando <fboucquez@gmail.com>

* Patched with latest catbuffer and openAPI (#576)

* Fixed #575
- Patched with latest catbuffer and openAPI

* Fixed typo

* Fixed #568
Split AccountRestrctionFlags into 3 specific flags

* Fixed rebase conflicts

* Updated alpha version

Co-authored-by: fernando <fboucquez@gmail.com>

* 0.19.1 release (#577)

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>
Co-authored-by: Travis CI User <travis@example.org>
Co-authored-by: decentraliser <decentraliser@gmail.com>
rg911 added a commit that referenced this pull request May 22, 2020
* 0.19.1 Release (#578)

* Post Release (#519)

* v0.17.4 (#514)

* Created `network` folder for network models

* Fixed lint after files moved

* Applied openAPI 0.8.7 changes

* Added tests

* Use UInt64 in retalFees

* Fixed #455
Make namespace max depth configurable in idGenerator

* - Fixed parser bug
- Use rest json payload for unit testing

* restored removed tests to cover models

* Working on travis release process and ts-doc github deployments

* Simplfied BlockHttp
Added BlockHttp unit tests
Changed travis to just report coveralls from one job

* fixed travis

* Uploading multiple versions of ts-docs into git hub pages

* Improved ChainHttp, added unit tests

* Removed maxDepth. Let server run the validation

* Added unit tests

* FIxed #493

* Added tests

* useQuerystring on all https

* Fixed github token env variable name
Added escape skip flag to avoid republishing the same version
Added missing git commit . after version increase

* Update README links

* Update README.md

* Update release.sh

* Update README.md

* Installing typescript globally

* Improved MetadataHttp, added unit tests

* fixed #495

* Fixed #501

* fixed #503

* Refactored MosaicService unit test (#510)

* Fixed #509

* Added mosaicHttp unit tests

* Refactored mosaicHttp to use abstract caller

* Add error trapping unit test

* removed unused error catcher

* add SimpleWallet.toDTO, fixes #504 (#508)

* add SimpleWallet.toDTO, fixes #504

* add word2ua test

* Update README.md (#512)

* v0.17.4 release (#513)

* v0.17.4 release

* Updated md table header

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>

* Trigger release build

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>

* Post release (#520)

* v0.17.4 (#514)

* Created `network` folder for network models

* Fixed lint after files moved

* Applied openAPI 0.8.7 changes

* Added tests

* Use UInt64 in retalFees

* Fixed #455
Make namespace max depth configurable in idGenerator

* - Fixed parser bug
- Use rest json payload for unit testing

* restored removed tests to cover models

* Working on travis release process and ts-doc github deployments

* Simplfied BlockHttp
Added BlockHttp unit tests
Changed travis to just report coveralls from one job

* fixed travis

* Uploading multiple versions of ts-docs into git hub pages

* Improved ChainHttp, added unit tests

* Removed maxDepth. Let server run the validation

* Added unit tests

* FIxed #493

* Added tests

* useQuerystring on all https

* Fixed github token env variable name
Added escape skip flag to avoid republishing the same version
Added missing git commit . after version increase

* Update README links

* Update README.md

* Update release.sh

* Update README.md

* Installing typescript globally

* Improved MetadataHttp, added unit tests

* fixed #495

* Fixed #501

* fixed #503

* Refactored MosaicService unit test (#510)

* Fixed #509

* Added mosaicHttp unit tests

* Refactored mosaicHttp to use abstract caller

* Add error trapping unit test

* removed unused error catcher

* add SimpleWallet.toDTO, fixes #504 (#508)

* add SimpleWallet.toDTO, fixes #504

* add word2ua test

* Update README.md (#512)

* v0.17.4 release (#513)

* v0.17.4 release

* Updated md table header

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>

* Trigger release build

* Creating new version 0.17.5

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>
Co-authored-by: Travis CI User <travis@example.org>

* LockHashAlgorithm (#522)

* Fixed #518
- Added LockHashUtils
- Removed Op_Keccak_256 algorithm
- Renamed HashType to LockHashAlgorithm
- Renamed model field name to be aligned with Catbuffer

* Fixed #521

* - Added Hash method with algorithm input
- Added unit tests
- Added export

* Added networkCurrency resolver for e2e tests (#529)

* Fixed #523
- Added networkCurrency resolver for e2e tests

* trigger travis

* Removed metadata size validation (#527)

* Fixed #526
- Removed metadata size validation

* Added unit tests for coverage

* added unit tests

* improved coverage

* Added check on  Account.signData and PublicAccount.verifySignature for hexadecimal (#528)

* Fixed #252
- Added check on  Account.signData and PublicAccount.verifySignature for hexadecimal

* trigger travis

* Added isHexadecimal argument to account.signData and publicAccount.verifySignature

* Fixed #525

* Removed unused condition

* refactored signData and verifySignature

* Prettier - ESLint (#531)

* eslint and prettier

* working on eslint

* working on eslint

* fixed travis

* rolled back md changes

* Added unit tests

* improved NamespaceHttp

* Fixed eslint warnings (#538)

* Fixed #535
* Fixed #536

* maxFee in Aggregate transactions (#539)

* Fixed #533
- Added setMaxFeeForAggregate
- Changed setMaxFee for stand alone tx only
- Addes getMaxCosignatures
- Added getNetworkMaxCosignaturesPerAggregate

* Fixed typo

* Fixe typo

* Fixed PR review comments

* Added tests

* Fixed #507 (#541)

* upgrade crypto-js to v4.0.0, add AESEncryptionService and apply it to SimpleWallet, fixes  #524 (#530)

* upgrade crypto-js to v4.0.0, add AESEncryptionService and apply it to SimpleWallet, fixes  #524

* remove passwordToPrivateKey, rename toMobileKey by encryptPBKDF2

* accept string as password in AESEncryptionService

* remove unused functions in Crypto, merge AES Encryption service into Crypto

Co-authored-by: Steven Liu <xian.f.liu@gmail.com>

* Alias resolution for accountHttp (#540)

* Fixed #499
- Added AccountService

* Fixed e2e tests

* Fixed lints

* Fixed years

* another year fix

* Chaned to use address array and reduce rest calls

* handle empty array

* Fixed typos

* more typo fix

* Fixed function name

* v0.18.0 release

* Creating new version 0.18.1

* update js docs

* Return distinct cosignature count in aggregateTransactionService (#552)

* Fixed #551

* improved coverage

* added test in account service

* fix typo (#555)

Co-authored-by: Steven Liu <xian.f.liu@gmail.com>

* Gorilla 1 key link transactions and block header updates (#549)

* Applied catbuffer-typescript v0.0.12

* Added voting & vrf key link transactions

* Updated catbuffer to 0.0.13

* Applied catbuffer-typescript v0.0.12

* Added voting & vrf key link transactions

* Updated catbuffer to 0.0.13

* Fixed #556

* Updated catbuffer-typescript lib

* Fixed #558
- Added NodeLinkTransaction

* Fixed #550
- Added block header patch from gorilla 1

* Changed to use supplementalAccountKeys

* Fixed dto bug in network properties

* Fixed #565
- Added new chain properties

* Fixed #563
- Renamed AccountLinkTransaction to AccountKeyLinkTransaction

* Updated repoFactory to use node/info for generationHash

* Fixed tests

* Renamed gernationHashSeed

* - Fixed issues in e2e tests
- Removed incomingTransactionType flags in restriction

* Added shx for cross platform build purposes

* Test coverage

* 0.19.0 release (#567)

* v0.19.0 release note

* v0.19.0: Gorilla.1 schema updates

* Updated changelog

* Fixed #571 (#572)

- Added signature and signer to loadFromPayload

* Listener (WS) refactoring (#570)

* Fixed #569
- Listener filter on recipientAddress and target addresses (publicKeys)
- Now resolving alias

* Improved listener:
1) Added transaction hashes to the subscription
2) Reused methods when subscriptions are the same
3) Improved how aliases are loaded (lazy on demand)

* Refactored regard PR feedbacks

* typo fixed

* Bugs fixed to use super.isSigned

Co-authored-by: fernando <fboucquez@gmail.com>

* Patched with latest catbuffer and openAPI (#576)

* Fixed #575
- Patched with latest catbuffer and openAPI

* Fixed typo

* Split AccountRestrctionFlags into 3 specific flags (#573)

* Fixed #568
Split AccountRestrctionFlags into 3 specific flags

* Listener (WS) refactoring (#570)

* Fixed #569
- Listener filter on recipientAddress and target addresses (publicKeys)
- Now resolving alias

* Improved listener:
1) Added transaction hashes to the subscription
2) Reused methods when subscriptions are the same
3) Improved how aliases are loaded (lazy on demand)

* Refactored regard PR feedbacks

* typo fixed

* Bugs fixed to use super.isSigned

Co-authored-by: fernando <fboucquez@gmail.com>

* Patched with latest catbuffer and openAPI (#576)

* Fixed #575
- Patched with latest catbuffer and openAPI

* Fixed typo

* Fixed #568
Split AccountRestrctionFlags into 3 specific flags

* Fixed rebase conflicts

* Updated alpha version

Co-authored-by: fernando <fboucquez@gmail.com>

* 0.19.1 release (#577)

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>
Co-authored-by: Travis CI User <travis@example.org>
Co-authored-by: decentraliser <decentraliser@gmail.com>

* Creating new version 0.19.2

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>
Co-authored-by: Travis CI User <travis@example.org>
Co-authored-by: decentraliser <decentraliser@gmail.com>
rg911 added a commit that referenced this pull request May 26, 2020
* Post Release (#519)

* v0.17.4 (#514)

* Created `network` folder for network models

* Fixed lint after files moved

* Applied openAPI 0.8.7 changes

* Added tests

* Use UInt64 in retalFees

* Fixed #455
Make namespace max depth configurable in idGenerator

* - Fixed parser bug
- Use rest json payload for unit testing

* restored removed tests to cover models

* Working on travis release process and ts-doc github deployments

* Simplfied BlockHttp
Added BlockHttp unit tests
Changed travis to just report coveralls from one job

* fixed travis

* Uploading multiple versions of ts-docs into git hub pages

* Improved ChainHttp, added unit tests

* Removed maxDepth. Let server run the validation

* Added unit tests

* FIxed #493

* Added tests

* useQuerystring on all https

* Fixed github token env variable name
Added escape skip flag to avoid republishing the same version
Added missing git commit . after version increase

* Update README links

* Update README.md

* Update release.sh

* Update README.md

* Installing typescript globally

* Improved MetadataHttp, added unit tests

* fixed #495

* Fixed #501

* fixed #503

* Refactored MosaicService unit test (#510)

* Fixed #509

* Added mosaicHttp unit tests

* Refactored mosaicHttp to use abstract caller

* Add error trapping unit test

* removed unused error catcher

* add SimpleWallet.toDTO, fixes #504 (#508)

* add SimpleWallet.toDTO, fixes #504

* add word2ua test

* Update README.md (#512)

* v0.17.4 release (#513)

* v0.17.4 release

* Updated md table header

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>

* Trigger release build

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>

* Post release (#520)

* v0.17.4 (#514)

* Created `network` folder for network models

* Fixed lint after files moved

* Applied openAPI 0.8.7 changes

* Added tests

* Use UInt64 in retalFees

* Fixed #455
Make namespace max depth configurable in idGenerator

* - Fixed parser bug
- Use rest json payload for unit testing

* restored removed tests to cover models

* Working on travis release process and ts-doc github deployments

* Simplfied BlockHttp
Added BlockHttp unit tests
Changed travis to just report coveralls from one job

* fixed travis

* Uploading multiple versions of ts-docs into git hub pages

* Improved ChainHttp, added unit tests

* Removed maxDepth. Let server run the validation

* Added unit tests

* FIxed #493

* Added tests

* useQuerystring on all https

* Fixed github token env variable name
Added escape skip flag to avoid republishing the same version
Added missing git commit . after version increase

* Update README links

* Update README.md

* Update release.sh

* Update README.md

* Installing typescript globally

* Improved MetadataHttp, added unit tests

* fixed #495

* Fixed #501

* fixed #503

* Refactored MosaicService unit test (#510)

* Fixed #509

* Added mosaicHttp unit tests

* Refactored mosaicHttp to use abstract caller

* Add error trapping unit test

* removed unused error catcher

* add SimpleWallet.toDTO, fixes #504 (#508)

* add SimpleWallet.toDTO, fixes #504

* add word2ua test

* Update README.md (#512)

* v0.17.4 release (#513)

* v0.17.4 release

* Updated md table header

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>

* Trigger release build

* Creating new version 0.17.5

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>
Co-authored-by: Travis CI User <travis@example.org>

* LockHashAlgorithm (#522)

* Fixed #518
- Added LockHashUtils
- Removed Op_Keccak_256 algorithm
- Renamed HashType to LockHashAlgorithm
- Renamed model field name to be aligned with Catbuffer

* Fixed #521

* - Added Hash method with algorithm input
- Added unit tests
- Added export

* Added networkCurrency resolver for e2e tests (#529)

* Fixed #523
- Added networkCurrency resolver for e2e tests

* trigger travis

* Removed metadata size validation (#527)

* Fixed #526
- Removed metadata size validation

* Added unit tests for coverage

* added unit tests

* improved coverage

* Added check on  Account.signData and PublicAccount.verifySignature for hexadecimal (#528)

* Fixed #252
- Added check on  Account.signData and PublicAccount.verifySignature for hexadecimal

* trigger travis

* Added isHexadecimal argument to account.signData and publicAccount.verifySignature

* Fixed #525

* Removed unused condition

* refactored signData and verifySignature

* Prettier - ESLint (#531)

* eslint and prettier

* working on eslint

* working on eslint

* fixed travis

* rolled back md changes

* Added unit tests

* improved NamespaceHttp

* Fixed eslint warnings (#538)

* Fixed #535
* Fixed #536

* maxFee in Aggregate transactions (#539)

* Fixed #533
- Added setMaxFeeForAggregate
- Changed setMaxFee for stand alone tx only
- Addes getMaxCosignatures
- Added getNetworkMaxCosignaturesPerAggregate

* Fixed typo

* Fixe typo

* Fixed PR review comments

* Added tests

* Fixed #507 (#541)

* upgrade crypto-js to v4.0.0, add AESEncryptionService and apply it to SimpleWallet, fixes  #524 (#530)

* upgrade crypto-js to v4.0.0, add AESEncryptionService and apply it to SimpleWallet, fixes  #524

* remove passwordToPrivateKey, rename toMobileKey by encryptPBKDF2

* accept string as password in AESEncryptionService

* remove unused functions in Crypto, merge AES Encryption service into Crypto

Co-authored-by: Steven Liu <xian.f.liu@gmail.com>

* Alias resolution for accountHttp (#540)

* Fixed #499
- Added AccountService

* Fixed e2e tests

* Fixed lints

* Fixed years

* another year fix

* Chaned to use address array and reduce rest calls

* handle empty array

* Fixed typos

* more typo fix

* Fixed function name

* v0.18.0 release

* Creating new version 0.18.1

* update js docs

* Return distinct cosignature count in aggregateTransactionService (#552)

* Fixed #551

* improved coverage

* added test in account service

* fix typo (#555)

Co-authored-by: Steven Liu <xian.f.liu@gmail.com>

* Gorilla 1 key link transactions and block header updates (#549)

* Applied catbuffer-typescript v0.0.12

* Added voting & vrf key link transactions

* Updated catbuffer to 0.0.13

* Applied catbuffer-typescript v0.0.12

* Added voting & vrf key link transactions

* Updated catbuffer to 0.0.13

* Fixed #556

* Updated catbuffer-typescript lib

* Fixed #558
- Added NodeLinkTransaction

* Fixed #550
- Added block header patch from gorilla 1

* Changed to use supplementalAccountKeys

* Fixed dto bug in network properties

* Fixed #565
- Added new chain properties

* Fixed #563
- Renamed AccountLinkTransaction to AccountKeyLinkTransaction

* Updated repoFactory to use node/info for generationHash

* Fixed tests

* Renamed gernationHashSeed

* - Fixed issues in e2e tests
- Removed incomingTransactionType flags in restriction

* Added shx for cross platform build purposes

* Test coverage

* 0.19.0 release (#567)

* v0.19.0 release note

* v0.19.0: Gorilla.1 schema updates

* Updated changelog

* Fixed #571 (#572)

- Added signature and signer to loadFromPayload

* Listener (WS) refactoring (#570)

* Fixed #569
- Listener filter on recipientAddress and target addresses (publicKeys)
- Now resolving alias

* Improved listener:
1) Added transaction hashes to the subscription
2) Reused methods when subscriptions are the same
3) Improved how aliases are loaded (lazy on demand)

* Refactored regard PR feedbacks

* typo fixed

* Bugs fixed to use super.isSigned

Co-authored-by: fernando <fboucquez@gmail.com>

* Patched with latest catbuffer and openAPI (#576)

* Fixed #575
- Patched with latest catbuffer and openAPI

* Fixed typo

* Split AccountRestrctionFlags into 3 specific flags (#573)

* Fixed #568
Split AccountRestrctionFlags into 3 specific flags

* Listener (WS) refactoring (#570)

* Fixed #569
- Listener filter on recipientAddress and target addresses (publicKeys)
- Now resolving alias

* Improved listener:
1) Added transaction hashes to the subscription
2) Reused methods when subscriptions are the same
3) Improved how aliases are loaded (lazy on demand)

* Refactored regard PR feedbacks

* typo fixed

* Bugs fixed to use super.isSigned

Co-authored-by: fernando <fboucquez@gmail.com>

* Patched with latest catbuffer and openAPI (#576)

* Fixed #575
- Patched with latest catbuffer and openAPI

* Fixed typo

* Fixed #568
Split AccountRestrctionFlags into 3 specific flags

* Fixed rebase conflicts

* Updated alpha version

Co-authored-by: fernando <fboucquez@gmail.com>

* 0.19.1 release (#577)

Co-authored-by: Fernando Boucquez <fboucquez@gmail.com>
Co-authored-by: David Garcia <dgarcia360@outlook.com>
Co-authored-by: Decentraliser <me@decentraliser.dev>
Co-authored-by: Travis CI User <travis@example.org>
Co-authored-by: decentraliser <decentraliser@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable eslint, select the right standard for typescript and update code
2 participants