Skip to content

Fix getTransactionStatus for failed transaction (#24) #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 1, 2019
Merged

Fix getTransactionStatus for failed transaction (#24) #59

merged 13 commits into from
Mar 1, 2019

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Feb 13, 2019

Fixed the issue but unit testing on hold after nem2-lib decommissioned.

@rg911 rg911 mentioned this pull request Feb 13, 2019
Closed
@coveralls
Copy link

coveralls commented Feb 13, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 177

  • 2 of 5 (40.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 71.287%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model/transaction/SyncAnnounce.ts 1 4 25.0%
Totals Coverage Status
Change from base Build 175: -0.2%
Covered Lines: 854
Relevant Lines: 1114
💛 - Coveralls

@dgarcia360 dgarcia360 requested a review from evias February 15, 2019 16:34
evias
evias suggested changes Feb 20, 2019
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@evias evias evias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rg911 rg911

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rg911 @coveralls @evias