-
Notifications
You must be signed in to change notification settings - Fork 57
9.6.1 with pagination on Transaction/Block/Mosaic #601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Integration tests fixed - updated openAPI and catbuffer lib version
- added size to blockInfo
- Fixed e2e tests
- Split transaction search & get into 3 - Made 'group' mandatory in transactionSearchCriteria - Added transactionStatus repository
fboucquez
suggested changes
Jun 16, 2020
Contributor
fboucquez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, just a few improvements
dgarcia360
reviewed
Jun 16, 2020
dgarcia360
reviewed
Jun 16, 2020
- Removed transactionGroup from getEffectiveFees - Other PR comments fixed
dgarcia360
reviewed
Jun 16, 2020
dgarcia360
previously approved these changes
Jun 16, 2020
- More coverage improvment
- Fixed a small issues in e2e tests
fboucquez
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9.6.1 with pagination
Model property name changes
Transactions property name changes
Other changes
A, I, Q, Yallowed as the last char on a valid addressPagination
searchendpoint to TransactionHttp, BlockHttp, and MosaicHttp.TransactionSearchCriteriahas been made mandatory since rest splitgetTransactionintogetConfirmedTransaction,getUnconfirmedTransactionandgetPartialTransaction. Also same assearch transactioninto search confirmed/unconfirmed/partial transactions