Skip to content

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Jun 16, 2020

9.6.1 with pagination


Model property name changes

  • MetadataEntry: senderPublicKey: string => sourceAddress: Address; targetPublicKey: string => targetAddress: Address
  • MultisigAccountGraphInfo: multisigAccounts => multisigEntries
  • MultisigAccountInfo: account: PublicAccount => accountAddress: Address; cosignatories: PublicAccount[] => cosignatoryAddresses: Address; multisigAccounts: PublicAccount[] => multisigAddresses: Address[]
  • BlockInfo / NewBlock: beneficiaryPublicKey: PublicAccount | undefined => beneficiaryAddress: Address | undefined
  • MosaicId: owner: PublicAccount => ownerAddress: Address
  • MosaicInfo: owner: PublicAccount => ownerAddress: Address; height => startHeight
  • NamespaceInfo: owner: PublicAccount => ownerAddress: Address
  • ChainProperties: harvestNetworkFeeSinkPublicKey => harvestNetworkFeeSinkAddress
  • MosaicNetworkProperties: mosaicRentalFeeSinkPublicKey => mosaicRentalFeeSinkAddress
  • NamespaceNetworkProperties: namespaceRentalFeeSinkPublicKey => namespaceRentalFeeSinkAddress
  • NetworkProperties: publicKey => nemesisSignerPublicKey
  • BalanceChangeReceipt: targetPublicAccount: PublicAccount => targetAddress: Address
  • BalanceTransferReceipt: sender: PublicAccount => senderAddress: Address

Transactions property name changes

  • AccountMetadataTransaction: targetPublicKey: string => targetAddress: UnresolvedAddress
  • MosaicMetadataTransaction: targetPublicKey: string => targetAddress: UnresolvedAddress
  • NamespaceMetadataTransaction: targetPublicKey: string => targetAddress: UnresolvedAddress
  • MultisigAccountModificationTransaction: publicKeyAdditions: PublicAccount[] => addressAdditions: UnresolvedAddress[]; publicKeyDeletions: PublicAccount[] => addressDeletions: UnresolvedAddress[]
  • AggregateTransactionService: cosignatories: string[] => cosignatories: Address[]

Other changes

  • New types created: UnresolvedAddress, UnresolvedMosaicId
  • Address format changed from 25 bytes to 24 bytes
  • Added sanity check on the new address format: Only A, I, Q, Y allowed as the last char on a valid address
  • MosaicId creation (from Nonce) changed to use publicKey to address.
  • Added reservedfield2 in TransferTransaction
  • Added 8 bytes version in cosignature (default: 0).

Pagination

  • Removed 'get transactions' endpoints from AccountHttp and BlockHttp
  • Added search endpoint to TransactionHttp, BlockHttp, and MosaicHttp.
  • Added SearchCriteria interfaces.
  • group filter in TransactionSearchCriteria has been made mandatory since rest split getTransaction into getConfirmedTransaction, getUnconfirmedTransaction and getPartialTransaction. Also same as search transaction into search confirmed/unconfirmed/partial transactions
  • Added streamer for the 3 new search endpoints (block, mosaic, transaction).

@rg911 rg911 requested review from dgarcia360 and fboucquez June 16, 2020 12:54
Copy link
Contributor

@fboucquez fboucquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just a few improvements

- Removed transactionGroup from getEffectiveFees
- Other PR comments fixed
dgarcia360
dgarcia360 previously approved these changes Jun 16, 2020
- More coverage improvment
@rg911 rg911 requested a review from fboucquez June 18, 2020 10:06
@rg911 rg911 merged commit 4165200 into master Jun 18, 2020
@rg911 rg911 deleted the 9.6.1 branch July 2, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants