Skip to content

Conversation

@evias
Copy link
Contributor

@evias evias commented Feb 16, 2019

Added

Fixed

@coveralls
Copy link

coveralls commented Feb 16, 2019

Pull Request Test Coverage Report for Build 92

  • 14 of 17 (82.35%) changed or added relevant lines in 7 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.7%) to 70.75%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/service/MosaicAmountView.ts 0 1 0.0%
src/service/MosaicService.ts 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
src/model/namespace/NamespaceId.ts 2 66.67%
src/service/NamespaceService.ts 8 21.43%
Totals Coverage Status
Change from base Build 64: -0.7%
Covered Lines: 718
Relevant Lines: 957

💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 16, 2019

Pull Request Test Coverage Report for Build 137

  • 39 of 43 (90.7%) changed or added relevant lines in 18 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 73.114%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model/mosaic/MosaicNonce.ts 4 5 80.0%
src/service/MosaicAmountView.ts 0 1 0.0%
src/service/MosaicService.ts 2 4 50.0%
Totals Coverage Status
Change from base Build 124: 0.7%
Covered Lines: 769
Relevant Lines: 994

💛 - Coveralls

@evias
Copy link
Contributor Author

evias commented Feb 17, 2019

tests not passing until nem2-library PR#4 is merged in nem2-library.

Reason for this are changes in the MosaicDefinition DTO and API calls.

@dgarcia360 dgarcia360 removed their request for review February 19, 2019 13:03
@evias
Copy link
Contributor Author

evias commented Feb 20, 2019

tests still not passing until nem2-library PR#4 is merged in nem2-library.

Reason for this are changes in the MosaicDefinition DTO and API calls. Currently fixes are still being applied to the library, to make it cow compatible. Update here will follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Breaks compatibility with previous version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants