Skip to content

Task/g628 metadata receipt #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 23, 2020
Merged

Task/g628 metadata receipt #634

merged 18 commits into from
Jul 23, 2020

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Jul 20, 2020

Applied pagination changes for Metadata and Receipt endpoints

@fboucquez
Copy link
Contributor

fboucquez commented Jul 20, 2020

ReceiptRepository should provide 2 or 3 independent searches so the user knows exactly what are the accepted parameters and the returned types.

https://github.com/nemtech/symbol-sdk-typescript-javascript/blob/task/g628_metadata_receipt/src/infrastructure/ReceiptRepository.ts#L27

Java as an example:

https://github.com/nemtech/symbol-sdk-java/blob/metadata-receipt/sdk-core/src/main/java/io/nem/symbol/sdk/api/ReceiptRepository.java#L32

@dgarcia360 dgarcia360 changed the base branch from master to main July 22, 2020 12:52
@fboucquez fboucquez self-requested a review July 23, 2020 14:48
@rg911 rg911 merged commit 212e777 into main Jul 23, 2020
@fboucquez fboucquez deleted the task/g628_metadata_receipt branch July 23, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fboucquez fboucquez fboucquez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rg911 @fboucquez