Skip to content

removed hardcoded nemesis epoch #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 9, 2020
Merged

removed hardcoded nemesis epoch #686

merged 6 commits into from
Oct 9, 2020

Conversation

@rg911
Copy link
Contributor

@rg911 rg911 commented Oct 8, 2020 •
edited
Loading

  • removed hardcoded nemesis epoch
  • Changed Deadline.value (LocalDateTime) to Deadline.adjustedValue (number / seconds)
  • Deadline.create(...) now requires EpochAdjustment (js-joda/Duration
  • Added toLocalDatetime (with custom zone support) in Deadline class
  • Added EpochAdjustment getter in RepositoryFactory

Fixed #681

@rg911
Fixed symbol#681
01c6bba 
- removed hardcoded nemesis epoch
@rg911 rg911 requested a review from fboucquez October 8, 2020 18:52
fboucquez
fboucquez suggested changes Oct 9, 2020
View reviewed changes
@rg911 rg911 requested a review from fboucquez October 9, 2020 17:12
@fboucquez fboucquez mentioned this pull request Oct 9, 2020
Closed
@fboucquez fboucquez merged commit caaede0 into symbol:main Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fboucquez fboucquez fboucquez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nemesis epoch time is hard coded in the SDK but can change on the server side.

2 participants

@rg911 @fboucquez