Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Conda and WinRPM #34

Closed
wants to merge 8 commits into from

Conversation

Projects
None yet
3 participants
@isuruf
Copy link
Member

commented Sep 1, 2016

Depends on #32, #33

Fixes #29

@isuruf

This comment has been minimized.

Copy link
Member Author

commented Sep 1, 2016

@spencerlyon2, would you mind reviewing this PR?

end
prefix=joinpath(BinDeps.depsdir(symengine), "usr")

xx(t...) = (OS_NAME == :Windows ? t[1] : (OS_NAME == :Linux || length(t) == 2) ? t[2] : t[3])

This comment has been minimized.

Copy link
@sglyon

sglyon Sep 1, 2016

Contributor

What is xx?

This comment has been minimized.

Copy link
@isuruf

isuruf Sep 1, 2016

Author Member

It's a simple function to do different things for different OSs. It's used below. (Copied it from here, https://github.com/JuliaGraphics/Cairo.jl/blob/master/deps/build.jl#L102)

This comment has been minimized.

Copy link
@certik

certik Sep 12, 2016

Contributor

@isuruf you could add your comment as an actual comment in the file.

@@ -5,58 +5,59 @@ using Compat
group = library_group("symengine")

deps = [

This comment has been minimized.

Copy link
@sglyon

sglyon Sep 1, 2016

Contributor

This doesn't seem to be used anywhere, it is necessary?

@sglyon

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2016

The conda build seems to work for OS X if we change ccall syntax from

ccall((:fun_name, :libsymengine), ...)

to

ccall((:fun_name, symengine), ...)

Where symengine is defined in deps/deps.jl

@isuruf

This comment has been minimized.

Copy link
Member Author

commented Sep 1, 2016

Closed in favour of #35

@isuruf isuruf closed this Sep 1, 2016

@isuruf isuruf deleted the isuruf:deps2 branch Sep 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.