New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Expr Class #182

Merged
merged 1 commit into from Aug 25, 2017

Conversation

Projects
None yet
2 participants
@ShikharJ
Member

ShikharJ commented Aug 24, 2017

No description provided.

@isuruf

This comment has been minimized.

Show comment
Hide comment
@isuruf

isuruf Aug 24, 2017

Member

There are more classes like class Symbol(Basic) that needs to be fixed.

Member

isuruf commented Aug 24, 2017

There are more classes like class Symbol(Basic) that needs to be fixed.

@isuruf

This comment has been minimized.

Show comment
Hide comment
@isuruf

isuruf Aug 24, 2017

Member

Also export Expr in the main module.

Member

isuruf commented Aug 24, 2017

Also export Expr in the main module.

@ShikharJ

This comment has been minimized.

Show comment
Hide comment
@ShikharJ

ShikharJ Aug 25, 2017

Member

Ping @isuruf. For some reason, our numeric classes such as Zero and One are returning:

File "/home/shikhar/sympy/sympy/physics/quantum/tests/test_fermion.py", line 20, in test_fermionoperator
    assert AntiCommutator(c, Dagger(c)).doit() == 1
  File "/home/shikhar/sympy/sympy/physics/quantum/anticommutator.py", line 123, in doit
    return comm.doit(**hints)
TypeError: 'One' object is not callable

I want to fix that here itself, can you tell me why this is happening?

Member

ShikharJ commented Aug 25, 2017

Ping @isuruf. For some reason, our numeric classes such as Zero and One are returning:

File "/home/shikhar/sympy/sympy/physics/quantum/tests/test_fermion.py", line 20, in test_fermionoperator
    assert AntiCommutator(c, Dagger(c)).doit() == 1
  File "/home/shikhar/sympy/sympy/physics/quantum/anticommutator.py", line 123, in doit
    return comm.doit(**hints)
TypeError: 'One' object is not callable

I want to fix that here itself, can you tell me why this is happening?

@isuruf

This comment has been minimized.

Show comment
Hide comment
@isuruf

isuruf Aug 25, 2017

Member

Can you search for (Basic) and fix those please? For eg. class Boolean (Basic) needs to be fixed.

Member

isuruf commented Aug 25, 2017

Can you search for (Basic) and fix those please? For eg. class Boolean (Basic) needs to be fixed.

@isuruf isuruf merged commit 5bb89c0 into symengine:master Aug 25, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@isuruf

This comment has been minimized.

Show comment
Hide comment
@isuruf

isuruf Aug 25, 2017

Member

Thanks

Member

isuruf commented Aug 25, 2017

Thanks

@ShikharJ ShikharJ deleted the ShikharJ:Expr branch Aug 25, 2017

@isuruf

This comment has been minimized.

Show comment
Hide comment
@isuruf

isuruf Aug 27, 2017

Member

@ShikharJ, please send a PR to https://github.com/symengine/python-symengine-feedstock so that this change could be used in sympy

Member

isuruf commented Aug 27, 2017

@ShikharJ, please send a PR to https://github.com/symengine/python-symengine-feedstock so that this change could be used in sympy

@ShikharJ

This comment has been minimized.

Show comment
Hide comment
@ShikharJ

ShikharJ Aug 28, 2017

Member

@isuruf Actually, I was waiting up till the time I had pushed in all the PRs to SymPy (which should be done by tomorrow). So that I'll won't have to send PRs repeatedly to python-symengine-feedstock in order to make the minor changes (that might come up later, through discussions or otherwise) in SymEngine.py available. If its urgent, then please let me know.

Member

ShikharJ commented Aug 28, 2017

@isuruf Actually, I was waiting up till the time I had pushed in all the PRs to SymPy (which should be done by tomorrow). So that I'll won't have to send PRs repeatedly to python-symengine-feedstock in order to make the minor changes (that might come up later, through discussions or otherwise) in SymEngine.py available. If its urgent, then please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment