Changes to beginner notebook #59

merged 1 commit into from Oct 8, 2016


None yet

4 participants

rajithv commented Jul 7, 2016

No description provided.

@rajithv rajithv Changes to beginner notebook
@zverok zverok commented on the diff Jul 7, 2016
+ },
+ {
+ "cell_type": "code",
+ "execution_count": 20,
+ "metadata": {
+ "collapsed": false
+ },
+ "outputs": [
+ {
+ "data": {
+ "text/html": [
+ "1.2"
+ ],
+ "text/plain": [
+ "#<SymEngine::RealDouble(1.2)>"
+ ]
zverok Jul 7, 2016 Collaborator

Is this difference between text/html and text/plain ok? As far as I can understand, IRuby prefers to output text/html, when finds it, and it completely hides the fact that we are working with SymEngine object.

BTW, I like to do HTML representation of such kind of objects this way (look on blue-ish entities, and hover the mouse over them): basic text is as simple as possible, background+border shows "it is something more complex", tooltip shows inspect results.

isuruf Jul 7, 2016 Member

This output is because of this code,

This was done by @abinashmeher999 before inspect method showed the string representation, so that in iruby notebooks the object would print the contents instead of the memory address.
This should be changed though.

abinashmeher999 Jul 8, 2016 Contributor

I agree, the one @zverok showed is much better than the current representation and should be improved. Thanks for the suggestion.

isuruf Oct 8, 2016 Member

Opened #67 to keep track of this

@isuruf isuruf referenced this pull request Oct 8, 2016

Improve IRuby display #67

@isuruf isuruf merged commit 0caa11f into symengine:master Oct 8, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment