New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor cmake issue with setting flint=no #788

Closed
rwst opened this Issue Feb 1, 2016 · 11 comments

Comments

Projects
None yet
3 participants
@rwst
Copy link
Contributor

rwst commented Feb 1, 2016

Setting -DWITH_FLINT=no with cmake will not set it to No if WITH_ARB=yes but it should set both to No.

Discussion in #795 showed that using No as default is indistinguisable to No as commanded. I think a solution would be to set the default to Maybe.

@malayaleecoder

This comment has been minimized.

Copy link
Contributor

malayaleecoder commented Feb 3, 2016

@rwst : I would like to work on this issue. I am very new to symengine. Please guide me through.

@rwst

This comment has been minimized.

Copy link
Contributor

rwst commented Feb 3, 2016

What do you not understand?

@malayaleecoder

This comment has been minimized.

Copy link
Contributor

malayaleecoder commented Feb 3, 2016

@rwst : Which are the files to be modified with the above changes?

@rwst

This comment has been minimized.

Copy link
Contributor

rwst commented Feb 3, 2016

The files that must be modified are our cmake configuration files, see https://cmake.org/

@malayaleecoder

This comment has been minimized.

Copy link
Contributor

malayaleecoder commented Feb 4, 2016

@rwst : Very sorry that I could not understand correctly what You are trying to convey. When I run "cmake ." I see that "WITH_ARB no". Is it this what you are referring?

@rwst

This comment has been minimized.

Copy link
Contributor

rwst commented Feb 5, 2016

SymEngine optionally uses arb and flint. Arb depends on flint and includes it. So, if all is No and WITH_ARB is then set to yes, WITH_FLINT is set to Yes too. That works already. Now with both Yes WITH_FLINT is set to No (because the user deinstalled it) then WITH_ARB should also be back at No. Your task is to implement that.

@CodeMaxx

This comment has been minimized.

Copy link
Contributor

CodeMaxx commented Feb 6, 2016

@malayaleecoder are you still working on this? Otherwise I'll do it.

@malayaleecoder

This comment has been minimized.

Copy link
Contributor

malayaleecoder commented Feb 6, 2016

@CodeMaxx : No, you can go ahead with it.

@CodeMaxx

This comment has been minimized.

Copy link
Contributor

CodeMaxx commented Feb 6, 2016

@rwst is -DWITH_ARB=yes by default ?

@rwst

This comment has been minimized.

Copy link
Contributor

rwst commented Feb 7, 2016

It depends on if arb is installed on the system.

On Sat, Feb 6, 2016, 23:40 Akash Trehan notifications@github.com wrote:

@rwst https://github.com/rwst is -DWITH_ARB=yes by default ?


Reply to this email directly or view it on GitHub
#788 (comment)
.

@rwst rwst removed the Easy to fix label Feb 10, 2016

@rwst

This comment has been minimized.

Copy link
Contributor

rwst commented Feb 10, 2016

Invalid as per discussion in #795

@rwst rwst closed this Feb 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment