New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinity class #1048

Merged
merged 20 commits into from Jul 31, 2016

Conversation

Projects
None yet
3 participants
@isuruf
Copy link
Member

isuruf commented Jul 29, 2016

Replaces #916

TODO

  • Use in functions and other places in symengine

@isuruf isuruf referenced this pull request Jul 29, 2016

Closed

[WIP]Infinity Class #916

6 of 13 tasks complete
@CodeMaxx

This comment has been minimized.

Copy link
Contributor

CodeMaxx commented Jul 29, 2016

@isuruf Ping me if you get any doubts in my code. I'm sorry I couldn't complete this. I got buzy in other stuff.But I hope I've laid down a good framework. Thanks for continuing this :)

@certik

This comment has been minimized.

Copy link
Contributor

certik commented Jul 29, 2016

What are some examples where this would be used? I think we just need to use it at a few places to make sure things don't slow down and that we have implemented all important things. Then we can merge this and improve the rest in master.

@isuruf

This comment has been minimized.

Copy link
Member

isuruf commented Jul 29, 2016

This can be used in places where we now throws errors. tan(pi/2) throws an error, but we can return zoo as in SymPy

@certik

This comment has been minimized.

Copy link
Contributor

certik commented Jul 29, 2016

What does Mathematica and Maple do for tan(pi/2)?

@certik

This comment has been minimized.

Copy link
Contributor

certik commented Jul 29, 2016

I see, Mathematica returns ComplexInfinity. Yes, we should do the same.

@CodeMaxx

This comment has been minimized.

Copy link
Contributor

CodeMaxx commented Jul 29, 2016

@isuruf I think you forgot to use clangformat

@certik

This comment has been minimized.

Copy link
Contributor

certik commented Jul 31, 2016

+1 to merge.

@isuruf isuruf merged commit a5b4270 into symengine:master Jul 31, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@isuruf isuruf deleted the isuruf:inf branch Jul 31, 2016

@CodeMaxx

This comment has been minimized.

Copy link
Contributor

CodeMaxx commented Jul 31, 2016

Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment