Fixing enum issue in Exceptions #1069

Merged
merged 2 commits into from Aug 20, 2016

Projects

None yet

3 participants

@rajithv
Contributor
rajithv commented Aug 19, 2016

No description provided.

@rajithv rajithv Fixing issue with enum for error code
9280706
@isuruf isuruf commented on an outdated diff Aug 19, 2016
symengine/cwrapper.h
@@ -177,7 +177,7 @@ unsigned long integer_get_ui(const basic s);
CWRAPPER_OUTPUT_TYPE integer_get_mpz(mpz_t a, const basic s);
//! Assign to s, a rational i/j. Returns 0 if either i or j is not an integer.
-CWRAPPER_OUTPUT_TYPE rational_set(basic s, const basic i, const basic j);
+int rational_set(basic s, const basic i, const basic j);
@isuruf
isuruf Aug 19, 2016 Member

instead of 0 and 1, you can return an error code here and keep the return type CWRAPPER_OUTPUT_TYPE

@rajithv rajithv changed basic_diff and set_rational to use CWRAPPER_OUTPUT_TYPE
2129adf
@isuruf isuruf merged commit d674459 into symengine:master Aug 20, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@certik
Contributor
certik commented Aug 22, 2016

Thanks @rajithv. Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment