add asech to evaluate class #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isuruf
reviewed
Jan 24, 2017
| { | ||
| SYMENGINE_ASSERT(is_a<RealMPFR>(x)) | ||
| mpfr_srcptr x_ = down_cast<const RealMPFR &>(x).i.get_mpfr_t(); | ||
| if (mpfr_cmp_si(x_, 0) >= 0 or mpfr_cmp_si(x_, 1) <= 0) { |
There was a problem hiding this comment.
I think or should be changed to and
There was a problem hiding this comment.
yes..thanks for the catch
|
Thanks for the quick fix @ranjithkumar007 ! |
|
Ping @isuruf @jppelteret |
|
Looks pretty good @ranjithkumar007 :-) Thanks for your work on this and the comprehensive test cases! |
ranjithkumar007
force-pushed
the
asech
branch
from
01d4a61
to
72bbedf
Compare
ranjithkumar007
force-pushed
the
asech
branch
2 times, most recently
from
573ccc5
to
554f1cf
Compare
ranjithkumar007
force-pushed
the
asech
branch
from
554f1cf
to
9f4ec29
Compare
|
@isuruf @jppelteret tests have passed and finally codecov shows coverage at 71.03%(master is at 70.95) |
ranjithkumar007
pushed a commit
to ranjithkumar007/symengine
that referenced
this pull request
Jan 31, 2017
add asech to evaluate class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #1188 @jppelteret