New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system of equations #1317

Merged
merged 5 commits into from Sep 3, 2017

Conversation

Projects
None yet
4 participants
@ranjithkumar007
Contributor

ranjithkumar007 commented Aug 1, 2017

No description provided.

@ranjithkumar007

This comment has been minimized.

Show comment
Hide comment
@ranjithkumar007
Contributor

ranjithkumar007 commented Aug 12, 2017

@ranjithkumar007

This comment has been minimized.

Show comment
Hide comment
@ranjithkumar007

ranjithkumar007 Aug 17, 2017

Contributor

@srajangarg, can you review this?

Contributor

ranjithkumar007 commented Aug 17, 2017

@srajangarg, can you review this?

@srajangarg

This comment has been minimized.

Show comment
Hide comment
@srajangarg

srajangarg Aug 17, 2017

Contributor

Sorry, I am a little busy. Will look at it as soon as possible.

Contributor

srajangarg commented Aug 17, 2017

Sorry, I am a little busy. Will look at it as soon as possible.

// vector of equations as input
solns
= linsolve({add({x, mul(integer(2), y), mul(integer(3), z),
mul(integer(4), t), integer(10)}),

This comment has been minimized.

@isuruf

isuruf Aug 17, 2017

Member

x, y, z, t = 1,1,1,1 is a solution to x+2*y+3*z+4*t+10?

@isuruf

isuruf Aug 17, 2017

Member

x, y, z, t = 1,1,1,1 is a solution to x+2*y+3*z+4*t+10?

This comment has been minimized.

@ranjithkumar007

ranjithkumar007 Aug 17, 2017

Contributor

No.
Its a mistake from this line

@ranjithkumar007

ranjithkumar007 Aug 17, 2017

Contributor

No.
Its a mistake from this line

This comment has been minimized.

@ranjithkumar007

ranjithkumar007 Aug 21, 2017

Contributor

fixed this.

@ranjithkumar007

ranjithkumar007 Aug 21, 2017

Contributor

fixed this.

Show outdated Hide outdated symengine/solve.cpp
@ranjithkumar007

This comment has been minimized.

Show comment
Hide comment
@ranjithkumar007
Contributor

ranjithkumar007 commented Aug 31, 2017

ping @isuruf

@certik

This comment has been minimized.

Show comment
Hide comment
@certik

certik Sep 1, 2017

Contributor

@ranjithkumar007 I posted a comment above where Isuru is waiting for an answer from you. Please provide the answer and let's get things moving. We don't have much time left.

Contributor

certik commented Sep 1, 2017

@ranjithkumar007 I posted a comment above where Isuru is waiting for an answer from you. Please provide the answer and let's get things moving. We don't have much time left.

@certik

This comment has been minimized.

Show comment
Hide comment
@certik

certik Sep 2, 2017

Contributor

@ranjithkumar007 what is the status of this?

Contributor

certik commented Sep 2, 2017

@ranjithkumar007 what is the status of this?

@certik

certik approved these changes Sep 2, 2017

It looks good to me. There could be some improvements, but I think it's ok to merge it.

@ranjithkumar007

This comment has been minimized.

Show comment
Hide comment
@ranjithkumar007

ranjithkumar007 Sep 3, 2017

Contributor

I have updated the PR by embedding @isuruf 's suggestion.
Now, the equation is converted into MExprPoly and coefficients are extracted from it.

Contributor

ranjithkumar007 commented Sep 3, 2017

I have updated the PR by embedding @isuruf 's suggestion.
Now, the equation is converted into MExprPoly and coefficients are extracted from it.

Show outdated Hide outdated symengine/solve.cpp
@isuruf

This comment has been minimized.

Show comment
Hide comment
@isuruf

isuruf Sep 3, 2017

Member

Left one comment. Otherwise looks good to me. @certik, can you check again as the PR was rebased.

Member

isuruf commented Sep 3, 2017

Left one comment. Otherwise looks good to me. @certik, can you check again as the PR was rebased.

@certik certik merged commit 0b325d1 into symengine:master Sep 3, 2017

3 checks passed

codecov/project 83.29% (+0.02%) compared to f6549e9
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@certik

This comment has been minimized.

Show comment
Hide comment
@certik

certik Sep 3, 2017

Contributor

That looks good, thanks!

Contributor

certik commented Sep 3, 2017

That looks good, thanks!

@ranjithkumar007 ranjithkumar007 deleted the ranjithkumar007:systemofequations branch Sep 3, 2017

isuruf pushed a commit to isuruf/symengine that referenced this pull request Aug 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment