Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift Travis whitespace check to the end #767

Merged
merged 2 commits into from Jan 21, 2016
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 0 additions & 8 deletions bin/install_travis.sh
Expand Up @@ -38,14 +38,6 @@ export our_install_dir="$HOME/our_usr"
mkdir -p $our_install_dir
cd $our_install_dir

# check trailing whitespace:
if ! egrep " $" -nr --include=\*.{cpp,h,inc} --exclude-dir=*teuchos* $SOURCE_DIR ; then
echo No trailing whitespace;
else
exit -1;
fi
# TODO: Add similar grep checks for space after comma,, space after `if`, space between `)` and `{` also

if [[ "${TRAVIS_OS_NAME}" != "osx" ]]; then
if [[ "${TRAVIS}" != "true" ]]; then
sudo apt-get update
Expand Down
8 changes: 8 additions & 0 deletions bin/test_travis.sh
Expand Up @@ -97,3 +97,11 @@ fi

echo "Checking whether all header files are installed:"
python $SOURCE_DIR/symengine/utilities/tests/test_make_install.py $our_install_dir/include/symengine/ $SOURCE_DIR/symengine

# check trailing whitespace:
if ! egrep " $" -nr --include=\*.{cpp,h,inc} --exclude-dir=*teuchos* $SOURCE_DIR ; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exclude build directory as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

echo No trailing whitespace;
else
exit -1;
fi
# TODO: Add similar grep checks for space after comma,, space after `if`, space between `)` and `{` also