New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'make install' to readme #901

Merged
merged 1 commit into from Apr 3, 2016

Conversation

Projects
None yet
2 participants
@CodeMaxx
Copy link
Contributor

CodeMaxx commented Apr 1, 2016

Fixes #900

I think this can be merged without any effect on the clang format PR.
@isuruf

README.md Outdated
@@ -37,7 +37,7 @@ For RPM based systems (Fedora etc.):

yum install cmake gmp-devel

Install SymEngine:
Build SymEngine:

cmake .
make

This comment has been minimized.

@isuruf

isuruf Apr 1, 2016

Member

You can add it here

README.md Outdated
@@ -49,6 +49,12 @@ Run tests:

ctest

Install SymEngine:
```
sudo make install

This comment has been minimized.

@isuruf

isuruf Apr 1, 2016

Member

Don't use sudo

@isuruf

This comment has been minimized.

Copy link
Member

isuruf commented Apr 1, 2016

For PRs with no code changes, you can add [skip ci] to the commit message to skip travis and appveyor

@CodeMaxx CodeMaxx force-pushed the CodeMaxx:readme branch from d82b635 to ba21d16 Apr 1, 2016

@CodeMaxx

This comment has been minimized.

Copy link
Contributor

CodeMaxx commented Apr 1, 2016

Cool! I had been wondering if there was some way to do that.

README.md Outdated

This will configure and build SymEngine in the default Release mode with all
code and compiler optimizations on.
code and compiler optimizations on and then install it on your system.
SymEngine can then be imported in your programs.

This comment has been minimized.

@isuruf

isuruf Apr 1, 2016

Member

This would incorrectly imply that you don't have to link with SymEngine after installing.

This comment has been minimized.

@CodeMaxx

CodeMaxx Apr 1, 2016

Contributor

Should I add Note that you will have to link SymEngine during compilation or should I remove this line?

This comment has been minimized.

@isuruf

isuruf Apr 3, 2016

Member

Removing the line would be better

This comment has been minimized.

@CodeMaxx

CodeMaxx Apr 3, 2016

Contributor

Done

@CodeMaxx CodeMaxx force-pushed the CodeMaxx:readme branch from ba21d16 to c01c56b Apr 3, 2016

@isuruf isuruf merged commit 779d49a into symengine:master Apr 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment