New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travi-clang checks all files. Linux version error removed #904

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@CodeMaxx
Copy link
Contributor

CodeMaxx commented Apr 1, 2016

Addresses #902 #903
@certik @isuruf

@CodeMaxx CodeMaxx force-pushed the CodeMaxx:travis-clang branch 2 times, most recently from 7f4d6c9 to 91063f4 Apr 1, 2016

@@ -27,8 +27,7 @@ UnivariateIntPolynomial::UnivariateIntPolynomial(
SYMENGINE_ASSERT(is_canonical(degree_, dict_))
}

bool UnivariateIntPolynomial::is_canonical(const unsigned int &degree_,
const map_uint_mpz &dict) const
bool UnivariateIntPolynomial::is_canonical(const unsigned int &degree_, const map_uint_mpz &dict) const

This comment has been minimized.

@certik

certik Apr 5, 2016

Contributor

What caused this change?

@@ -11,7 +11,7 @@ if [[ "${TRAVIS_OS_NAME}" == "linux" ]] && \
exit 1
fi

FILES=`git diff master --name-only | grep -E "\.(cpp|h)$"`
FILES=`grep -E "\.(cpp|h)$"`

This comment has been minimized.

@abhinavagarwal07

abhinavagarwal07 Apr 7, 2016

Contributor

This is better unchanged

@CodeMaxx CodeMaxx closed this Apr 23, 2016

@CodeMaxx CodeMaxx reopened this Apr 26, 2016

@srajangarg

This comment has been minimized.

Copy link
Contributor

srajangarg commented May 17, 2016

@CodeMaxx I think this PR is not needed, the changes to clang-format have already been made.

@isuruf isuruf closed this May 17, 2016

@CodeMaxx

This comment has been minimized.

Copy link
Contributor

CodeMaxx commented May 17, 2016

@srajangarg Cool 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment