Fixes several warnings #994

Merged
merged 5 commits into from Jun 27, 2016

Projects

None yet

5 participants

@rajithv
Contributor
rajithv commented Jun 21, 2016

Fixes warnings of the sort:

warning: moving a temporary object prevents
      copy elision [-Wpessimizing-move]
    return make_rcp<const UIntPoly>(a.get_var(), std::move(res * tmp));
                                                 ^

Fixes some formatting.

rajithv added some commits Jun 21, 2016
@rajithv rajithv Fixing warnings and formatting 40081ce
@rajithv rajithv Fixed more warnings
988700c
@nishnik nishnik commented on an outdated diff Jun 21, 2016
symengine/fields.h
@@ -91,8 +91,10 @@ class GaloisFieldDict
// Returns whether polynomial is squarefield in `modulo_`
bool gf_is_sqf() const;
- // Returns the square free decomposition of polynomial's monic representation in `modulo_`
- // A vector of pair is returned where each element is a factor and each pair's first
+ // Returns the square free decomposition of polynomial's monic
+ // representation in `modulo_`
+ // A vector of pair is returned where each element is a factor and each
+ // pair's first
// raised to power of second gives the factor.
@nishnik
nishnik Jun 21, 2016 Contributor

Could you change this to
// pair's first raised to power of second gives the factor.
Looks cleaner.

@rajithv rajithv Minor fix in a comment
41ab7c7
@nishnik
Contributor
nishnik commented Jun 21, 2016

+1 for the std::move changes.

@Sumith1896
Member

@rajithv Sorry there seems to conflicts because of a recent PR merge. Could you fix that?
We can then merge this in.

@certik
Contributor
certik commented Jun 24, 2016

+1

@abhinavagarwal07
Contributor

+1

@Sumith1896
Member

@rajithv ping

@rajithv
Contributor
rajithv commented Jun 27, 2016

didn't notice.. thought this was merged. Will fix it.

rajithv added some commits Jun 27, 2016
@rajithv rajithv Merge branch 'master' of https://github.com/symengine/symengine into …
…fix_rational
ccb5ef5
@rajithv rajithv Merge branch 'fix_rational' of https://github.com/rajithv/symengine i…
…nto fix_rational
45706c3
@certik certik merged commit 317de61 into symengine:master Jun 27, 2016

4 checks passed

codecov/patch 100% of diff hit (target 68.83%)
Details
codecov/project 68.83% (+0.00%) compared to 87b3aee
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment