cleanup slideshow admin when features are implemented #38

Closed
dbu opened this Issue Mar 14, 2013 · 7 comments

Comments

Projects
None yet
3 participants
Owner

dbu commented Mar 14, 2013

#32 has a couple of open todos blocked by sonata and phpcr-odm missing features

  • the sonata admin is creating random document names. if http://www.doctrine-project.org/jira/browse/PHPCR-103 is implemented, we can use that and drop the code
  • the sonata admin is reordering the children itself. sonata_type_collection could reorder the children, or we could build a sonata_phpcr_type_collection that adds this behaviour sonata-project/SonataAdminBundle#1224
  • whether the image is required is determined by the admin class which does have a image block, but not necessarily the correct one. if we manage to do symfony-cmf/MediaBundle#8 this problem would be gone
Owner

lsmith77 commented Aug 9, 2013

ping

Owner

dbu commented Aug 9, 2013

i updated the issue yesterday, added the checklist and removed it from the 1.0 milestone. its not critical at all but notes to clean up things once we did tasks in other bundles.

Owner

lsmith77 commented Oct 11, 2013

done?

Owner

lsmith77 commented Oct 12, 2013

ok .. that sort of works as is .. so fine for me.

lsmith77 closed this Oct 12, 2013

Owner

dbu commented Oct 12, 2013

i created separate follow up tickets for the things that are still hacks. but definitely none of those blockers to release 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment