From aa0b1e2a0ed079c2681856217b085ed3fc4eb120 Mon Sep 17 00:00:00 2001 From: Maximilian Berghoff Date: Wed, 16 May 2018 04:55:57 +0200 Subject: [PATCH] Github Templates - DevKit updates (#54) * DevKit updates * Apply fixes from StyleCI (#55) [ci skip] [skip ci] --- .github/Bug_report.md | 24 +++++++++++++++++++ .github/Documentation_issue.md | 10 ++++++++ .github/Feature_request.md | 12 ++++++++++ .github/Security_issue.md | 9 +++++++ .github/Support_question.md | 15 ++++++++++++ src/Registry/RepositoryRegistry.php | 4 ++++ .../CmfResourceExtensionTest.php | 2 ++ .../Compiler/DescriptionEnhancerPassTest.php | 2 ++ .../Factory/DoctrinePhpcrOdmFactoryTest.php | 1 + .../Unit/Registry/RepositoryRegistryTest.php | 1 + tests/Unit/Twig/DescriptionExtensionTest.php | 1 + 11 files changed, 81 insertions(+) create mode 100644 .github/Bug_report.md create mode 100644 .github/Documentation_issue.md create mode 100644 .github/Feature_request.md create mode 100644 .github/Security_issue.md create mode 100644 .github/Support_question.md diff --git a/.github/Bug_report.md b/.github/Bug_report.md new file mode 100644 index 0000000..8b27ed7 --- /dev/null +++ b/.github/Bug_report.md @@ -0,0 +1,24 @@ +--- +name: Bug Report +about: Report errors and problems + +--- + + + +**Description** + + +**How to reproduce** + + +**Possible Solution** + + +**Additional context** + diff --git a/.github/Documentation_issue.md b/.github/Documentation_issue.md new file mode 100644 index 0000000..196478c --- /dev/null +++ b/.github/Documentation_issue.md @@ -0,0 +1,10 @@ +--- +name: Documentation Issue +about: Anything related to Symfony CMF Documentation + +--- + +Symfony CMF Documentation has its own dedicated repository. Please open your +documentation-related issue at https://github.com/symfony-cmf/symfony-cmf-docs/issues + +Thanks! diff --git a/.github/Feature_request.md b/.github/Feature_request.md new file mode 100644 index 0000000..db3e02c --- /dev/null +++ b/.github/Feature_request.md @@ -0,0 +1,12 @@ +--- +name: Feature Request +about: RFC and ideas for new features and improvements + +--- + +**Description** + + +**Example** + diff --git a/.github/Security_issue.md b/.github/Security_issue.md new file mode 100644 index 0000000..34be6e0 --- /dev/null +++ b/.github/Security_issue.md @@ -0,0 +1,9 @@ +--- +name: Security Issue +about: Report security-related errors + +--- + +If you have found a security issue in Symfony, please send the details to +[David](mailto:david@liip.ch) or [Maximilian](mailto:maximilian.berghoff@gmx.de) and don't disclose it publicly until we can provide a +fix for it. diff --git a/.github/Support_question.md b/.github/Support_question.md new file mode 100644 index 0000000..c128b56 --- /dev/null +++ b/.github/Support_question.md @@ -0,0 +1,15 @@ +--- +name: Support Question +about: Questions about using Symfony CMF and its components + +--- + +**Description** + + +**How to reproduce (optional)** + + +**Possible Solution** + + diff --git a/src/Registry/RepositoryRegistry.php b/src/Registry/RepositoryRegistry.php index bc7378e..c2c36ae 100644 --- a/src/Registry/RepositoryRegistry.php +++ b/src/Registry/RepositoryRegistry.php @@ -24,9 +24,13 @@ class RepositoryRegistry implements RepositoryRegistryInterface { private $container; + private $serviceMap = []; + private $typeMap = []; + private $names = []; + private $defaultRepositoryName; /** diff --git a/tests/Unit/DependencyInjection/CmfResourceExtensionTest.php b/tests/Unit/DependencyInjection/CmfResourceExtensionTest.php index be02a7f..2f433a6 100644 --- a/tests/Unit/DependencyInjection/CmfResourceExtensionTest.php +++ b/tests/Unit/DependencyInjection/CmfResourceExtensionTest.php @@ -24,7 +24,9 @@ class CmfResourceExtensionTest extends \PHPUnit_Framework_TestCase { private $container; + private $extension; + private $repositoryFactory; public function setUp() diff --git a/tests/Unit/DependencyInjection/Compiler/DescriptionEnhancerPassTest.php b/tests/Unit/DependencyInjection/Compiler/DescriptionEnhancerPassTest.php index 533241a..63eee2e 100644 --- a/tests/Unit/DependencyInjection/Compiler/DescriptionEnhancerPassTest.php +++ b/tests/Unit/DependencyInjection/Compiler/DescriptionEnhancerPassTest.php @@ -20,7 +20,9 @@ class DescriptionEnhancerPassTest extends \PHPUnit_Framework_TestCase { private $container; + private $factoryDefinition; + private $pass; public function setUp() diff --git a/tests/Unit/DependencyInjection/Repository/Factory/DoctrinePhpcrOdmFactoryTest.php b/tests/Unit/DependencyInjection/Repository/Factory/DoctrinePhpcrOdmFactoryTest.php index 54ba9cd..06f7e7a 100644 --- a/tests/Unit/DependencyInjection/Repository/Factory/DoctrinePhpcrOdmFactoryTest.php +++ b/tests/Unit/DependencyInjection/Repository/Factory/DoctrinePhpcrOdmFactoryTest.php @@ -19,6 +19,7 @@ class DoctrinePhpcrOdmFactoryTest extends FactoryTestCase { private $session; + private $manager; public function setUp() diff --git a/tests/Unit/Registry/RepositoryRegistryTest.php b/tests/Unit/Registry/RepositoryRegistryTest.php index 09f32dd..585e00a 100644 --- a/tests/Unit/Registry/RepositoryRegistryTest.php +++ b/tests/Unit/Registry/RepositoryRegistryTest.php @@ -18,6 +18,7 @@ class RepositoryRegistryTest extends \PHPUnit_Framework_TestCase { private $repository; + private $container; public function setUp() diff --git a/tests/Unit/Twig/DescriptionExtensionTest.php b/tests/Unit/Twig/DescriptionExtensionTest.php index e9f0443..13640b2 100644 --- a/tests/Unit/Twig/DescriptionExtensionTest.php +++ b/tests/Unit/Twig/DescriptionExtensionTest.php @@ -19,6 +19,7 @@ class DescriptionExtensionTest extends \PHPUnit_Framework_TestCase { private $descriptionFactory; + private $twig; public function setUp()