Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Use CMF 1.3 versions #222

Merged
merged 4 commits into from Sep 25, 2015
Merged

Use CMF 1.3 versions #222

merged 4 commits into from Sep 25, 2015

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Sep 19, 2015

Otherwise, we can't use any SonataAdminBundle version (>2.3 is not supported by the CMF and <2.3 requires SonataBlockBundle 2.2)
"doctrine/phpcr-bundle": "1.3.*",
"doctrine/phpcr-odm": "1.3.*",
"symfony-cmf/core-bundle": "1.3.*",
"symfony-cmf/content-bundle": "1.3.*",
"symfony-cmf/menu-bundle": "1.2.*",
"symfony-cmf/block-bundle": "1.2.*",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this is really causing trouble:

  • symfony-cmf/block-bundle 1.3 requires sonata-project/block-bundle: 2.3.*
  • sonata-project/admin-bundle 2.3 requires sonata-project/block-bundle: 2.2.*
  • sonata-project/admin-bundle 2.4-dev is not supported by the CMF

In other words: We can't use CmfBlockBundle 1.3 when using the SonataAdminBundle with the next CMF version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and we cannot support 2.4 until Puli is stable .. right?

@dbu
Copy link
Member

dbu commented Sep 21, 2015

ah, that will be confusing. but i assume there is no easy way to make block-bundle 1.3 work with sonata block bundle 2.2?

is the block-bundle 1.2 incompatible with php 7 / symfony 2.7? if not i guess we can live with staying at the old version for one release. otherwise we need to either port back the support or move the changes that bump the sonata version to cmf block bundle 1.4 and remove them from the 1.3 version.

@lsmith77
Copy link
Member

I guess there is no reason not to merge at least the above changes already .. right?

@wouterj
Copy link
Member Author

wouterj commented Sep 25, 2015

I believe so indeed

@wouterj
Copy link
Member Author

wouterj commented Sep 25, 2015

lsmith77 added a commit that referenced this pull request Sep 25, 2015
@lsmith77 lsmith77 merged commit b6152e1 into master Sep 25, 2015
@lsmith77 lsmith77 deleted the 1.3-versions branch September 25, 2015 07:43
@lsmith77 lsmith77 removed the review label Sep 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants