Skip to content

Conversation

@wouterj
Copy link
Contributor

@wouterj wouterj commented Nov 5, 2025

Fixes #194

@javiereguiluz this contains one change for all attribute highlighting: the whole #[...] section is now wrapped in a single .hljs-meta element. This means that everything without style now also gets the green text color on symfony.com (e.g. parenthesis and commas).

@javiereguiluz
Copy link
Collaborator

Sorry for the late reply 🙏 This is really nice and solves the reported edge-case. About the parenthesis and commas getting the same highlight as the whole .hljs-meta element, I think it's not bad at all. Thanks al ot Wouter!

@javiereguiluz javiereguiluz merged commit 1c1e16f into symfony-tools:main Nov 12, 2025
3 checks passed
@javiereguiluz
Copy link
Collaborator

javiereguiluz commented Nov 12, 2025

This was released in this new tag:
https://github.com/symfony-tools/docs-builder/releases/tag/v0.27.2

And, it's already deployed in production and the blog post shows the new behavior:
https://symfony.com/blog/new-in-symfony-7-4-improved-invokable-commands#:~:text=If%20your%20interactions%20only%20involve%20asking%20for%20missing%20argument%20or%20option%20values

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Minor highlighting issue

2 participants