Permalink
Browse files

Optimize autoload prefix in composer.json

By having more specific autoload prefixes it is possible to reduce the
number of stat calls made. Also it prevents conflicts with similar
namespaces.
  • Loading branch information...
1 parent 0be8fcc commit c1b83f1240b1fdedf6050455311aa9cdf3006e53 @Slamdunk Slamdunk committed Sep 28, 2012
Showing with 1 addition and 1 deletion.
  1. +1 −1 composer.json
View
2 composer.json
@@ -19,7 +19,7 @@
"php": ">=5.3.3"
},
"autoload": {
- "psr-0": { "Symfony\\Component\\Console": "" }
+ "psr-0": { "Symfony\\Component\\Console\\": "" }
},
"target-dir": "Symfony/Component/Console",
"minimum-stability": "dev",

5 comments on commit c1b83f1

@tiger-seo

Hi. That commit has been broken the Comsposer autoload logic. :(

@Slamdunk

What do you mean? The autoload still works as previous.

@tiger-seo

Nope, with vanila Composer autoloader was screaming that he can not find Symfony\Component\Console\Application

  [echo] Running functional tests ...
     [exec] PHP Fatal error:  Class 'Symfony\Component\Console\Application' not found in /var/lib/jenkins/jobs/API_dev/workspace/Vendor/Codeception/codecept on line 30
     [exec] PHP Stack trace:
     [exec] PHP   1. {main}() /var/lib/jenkins/jobs/API_dev/workspace/Vendor/Codeception/codecept:0

The problem had gone when we did swtich back to stable Symfony Console

@Slamdunk

Well, the PSR-0 specified is right and Composer behaves right, so the bug is not in this commit nor in Composer itself.
Try to debug vanila :\

@tiger-seo

Bug is or was in Console or Composer, and if you don't believe me then let it be, I will not argue with you :-)

Please sign in to comment.