Permalink
Commits on Sep 27, 2017
  1. Merge branch '3.4'

    fabpot committed Sep 27, 2017
    * 3.4:
      [SecurityBundle] Add missing AclSchemaListener deprecation
      deprecate relative paths in makePathRelative()
Commits on Sep 26, 2017
Commits on Sep 18, 2017
Commits on Sep 17, 2017
  1. bug #22321 [Filesystem] Fixed makePathRelative (ausi)

    fabpot committed Sep 17, 2017
    This PR was squashed before being merged into the 2.7 branch (closes #22321).
    
    Discussion
    ----------
    
    [Filesystem] Fixed makePathRelative
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Updating to Symfony 3.2.7 @agoat noticed a bug with `Filesystem::makePathRelative()` in contao/core-bundle#751:
    
    - In Symfony 3.2.6 `makePathRelative('aa/cc', 'bb/cc')` returned correctly `../../aa/cc`
    - In Symfony 3.2.7 the same method call returns `./`
    
    I think this issue was introduced with #22133.
    
    While working on the fix I noticed some other issues too:
    
    - An unnecessary if construct that did nothing, fc745f45949fdb8d5aa590618ec73537721f99b4
    - Missing normalization of `./` path segments, 15982d4b083723555cfa149368eaaae9609d0e22
    - `../` got ignored at the beginning of relative paths, 9586e880d69f613b10e23dd53cea877e622b221a
    - The documentation of the method only allowed absolute paths, but there are already unit tests ([FilesystemTest.php:1097](https://github.com/symfony/symfony/blob/ab93feae3f9a16c4f18c5736435d18fa36338d2c/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php#L1097)) that test the behavior of relative paths, cec473eeb099c074b5883e7187f74663402f9d87
    
    This pull request fixes all these issues and adds tests for them.
    
    Commits
    -------
    
    2bc11505f4 [Filesystem] Fixed makePathRelative
  2. [Filesystem] Fixed makePathRelative

    ausi committed with fabpot Apr 6, 2017
Commits on Sep 15, 2017
  1. Merge branch '3.4'

    nicolas-grekas committed Sep 15, 2017
    * 3.4:
      [CS][2.7] yoda_style, no_unneeded_curly_braces, no_unneeded_final_method, semicolon_after_instruction
      Reset stopwatch.
      [Filesystem] mirror - fix copying content with same name as source/target.
      Removed unnecessary getDefinition() call.
      .php_cs.dist - simplify config
      [WebProfilerBundle] fixed TemplateManager when using Twig 2 without compat interfaces
  2. Merge branch '3.3' into 3.4

    nicolas-grekas committed Sep 15, 2017
    * 3.3:
      [CS][2.7] yoda_style, no_unneeded_curly_braces, no_unneeded_final_method, semicolon_after_instruction
      [Filesystem] mirror - fix copying content with same name as source/target.
      Removed unnecessary getDefinition() call.
      .php_cs.dist - simplify config
      [WebProfilerBundle] fixed TemplateManager when using Twig 2 without compat interfaces
  3. Merge branch '2.8' into 3.3

    nicolas-grekas committed Sep 15, 2017
    * 2.8:
      [CS][2.7] yoda_style, no_unneeded_curly_braces, no_unneeded_final_method, semicolon_after_instruction
      [Filesystem] mirror - fix copying content with same name as source/target.
      .php_cs.dist - simplify config
      [WebProfilerBundle] fixed TemplateManager when using Twig 2 without compat interfaces
  4. Merge branch '2.7' into 2.8

    nicolas-grekas committed Sep 15, 2017
    * 2.7:
      [CS][2.7] yoda_style, no_unneeded_curly_braces, no_unneeded_final_method, semicolon_after_instruction
  5. [CS][2.7] yoda_style, no_unneeded_curly_braces, no_unneeded_final_met…

    SpacePossum committed with nicolas-grekas Sep 7, 2017
    …hod, semicolon_after_instruction
  6. Merge branch '2.7' into 2.8

    nicolas-grekas committed Sep 15, 2017
    * 2.7:
      [Filesystem] mirror - fix copying content with same name as source/target.
      .php_cs.dist - simplify config
      [WebProfilerBundle] fixed TemplateManager when using Twig 2 without compat interfaces
Commits on Sep 13, 2017
  1. bug #23473 [Filesystem] mirror - fix copying content with same name a…

    fabpot committed Sep 13, 2017
    …s source/target. (gitlost)
    
    This PR was squashed before being merged into the 2.7 branch (closes #23473).
    
    Discussion
    ----------
    
    [Filesystem] mirror - fix copying content with same name as source/target.
    
    | Q             | A
    | ------------- | ---
    | Branch?       |  2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #23472
    | License       | MIT
    | Doc PR        |
    
    Uses `substr()` and lengths in `Filesystem::mirror()` rather than `str_replace()` to avoid multiple replacements.
    
    Commits
    -------
    
    b524c84ce1 [Filesystem] mirror - fix copying content with same name as source/target.
Commits on Sep 11, 2017
  1. Merge branch '3.4'

    fabpot committed Sep 11, 2017
    * 3.4:
      [CS] Apply phpdoc_annotation_without_dot
      bumped Symfony version to 3.3.10
      updated VERSION for 3.3.9
      updated CHANGELOG for 3.3.9
      [DomCrawler] Fix conversion to int on GetPhpFiles
      Remove `protected_to_private` rule.
      Filtering empty uuids in ORMQueryBuilderLoader.
  2. Merge branch '3.3' into 3.4

    fabpot committed Sep 11, 2017
    * 3.3:
      [CS] Apply phpdoc_annotation_without_dot
      bumped Symfony version to 3.3.10
      updated VERSION for 3.3.9
      updated CHANGELOG for 3.3.9
      [DomCrawler] Fix conversion to int on GetPhpFiles
      Remove `protected_to_private` rule.
      Filtering empty uuids in ORMQueryBuilderLoader.
  3. Merge branch '2.8' into 3.3

    fabpot committed Sep 11, 2017
    * 2.8:
      [CS] Apply phpdoc_annotation_without_dot
  4. Merge branch '2.7' into 2.8

    fabpot committed Sep 11, 2017
    * 2.7:
      [CS] Apply phpdoc_annotation_without_dot
Commits on Sep 9, 2017
  1. Revert "bug #24105 [Filesystem] check permissions if dump target dir …

    fabpot committed Sep 9, 2017
    …is missing (xabbuh)"
    
    This reverts commit d74144fc0b588bb8d7e0f73e6063e4022946f8e5, reversing
    changes made to 2b79f484058bd3265a39709e97a8787044b2ae7d.
Commits on Sep 8, 2017
Commits on Sep 6, 2017
  1. check permissions if dump target dir is missing

    xabbuh committed Sep 5, 2017
    `is_dir()` returns `false` if the parent directory misses the executable
    bit even when the directory itself is present.
Commits on Aug 3, 2017
  1. Merge branch '3.3' into 3.4

    nicolas-grekas committed Aug 3, 2017
    * 3.3:
      Removed useless argument $definition
      Fix comment
      [Config] Fix checking class existence freshness
      bumped Symfony version to 3.3.7
      updated VERSION for 3.3.6
      updated CHANGELOG for 3.3.6
      Bump minimal PHP version to ^5.5.9|>=7.0.8
Commits on Aug 2, 2017
  1. Remove Filesystem\LockHandler

    jderusse committed Aug 2, 2017
Commits on Jul 31, 2017
Commits on Jul 29, 2017
Commits on Jul 11, 2017
  1. Merge branch '3.4'

    nicolas-grekas committed Jul 11, 2017
    * 3.4: (23 commits)
      Don't display the Symfony debug toolbar when printing the page
      [Routing] also add matched params for redirect due to trailing slash
      do not wire namespaces for the ArrayAdapter
      check _controller attribute is a string before parsing it
      [Cache] Added test for ApcuAdapter when using in CLI
      [Validator] sync upgrade file with latest code changes
      allow to configure custom formats in XML configs
      [HttpKernel] fix DumpDataCollector tests
      [FrameworkBundle] fix changelog
      [WebProfilerBundle] Cleanup profiler leftover
      [Routing] Add matched and default parameters to redirect responses
      [DotEnv] Fix variable substitution
      require the XML PHP extension
      Fix phpdoc for serializer normalizers exceptions
      Fixed absolute url generation for query strings and hash urls
      bumped Symfony version to 2.8.25
      updated VERSION for 2.8.24
      updated CHANGELOG for 2.8.24
      bumped Symfony version to 2.7.32
      [Filesystem] Dont copy perms when origin is remote
      ...
  2. Merge branch '3.3' into 3.4

    nicolas-grekas committed Jul 11, 2017
    * 3.3:
      Don't display the Symfony debug toolbar when printing the page
      do not wire namespaces for the ArrayAdapter
      check _controller attribute is a string before parsing it
      [Cache] Added test for ApcuAdapter when using in CLI
      allow to configure custom formats in XML configs
      [HttpKernel] fix DumpDataCollector tests
      [FrameworkBundle] fix changelog
      [WebProfilerBundle] Cleanup profiler leftover
      [DotEnv] Fix variable substitution
      require the XML PHP extension
      Fix phpdoc for serializer normalizers exceptions
      Fixed absolute url generation for query strings and hash urls
      bumped Symfony version to 2.8.25
      updated VERSION for 2.8.24
      updated CHANGELOG for 2.8.24
      bumped Symfony version to 2.7.32
      [Filesystem] Dont copy perms when origin is remote
      updated VERSION for 2.7.31
      update CONTRIBUTORS for 2.7.31
      updated CHANGELOG for 2.7.31
  3. Merge branch '3.2' into 3.3

    nicolas-grekas committed Jul 11, 2017
    * 3.2:
      Don't display the Symfony debug toolbar when printing the page
      do not wire namespaces for the ArrayAdapter
      [Cache] Added test for ApcuAdapter when using in CLI
      allow to configure custom formats in XML configs
      [HttpKernel] fix DumpDataCollector tests
      [FrameworkBundle] fix changelog
      [WebProfilerBundle] Cleanup profiler leftover
      require the XML PHP extension
      Fix phpdoc for serializer normalizers exceptions
      Fixed absolute url generation for query strings and hash urls
      bumped Symfony version to 2.8.25
      updated VERSION for 2.8.24
      updated CHANGELOG for 2.8.24
      bumped Symfony version to 2.7.32
      [Filesystem] Dont copy perms when origin is remote
      updated VERSION for 2.7.31
      update CONTRIBUTORS for 2.7.31
      updated CHANGELOG for 2.7.31
  4. Merge branch '2.8' into 3.2

    nicolas-grekas committed Jul 11, 2017
    * 2.8:
      Don't display the Symfony debug toolbar when printing the page
      allow to configure custom formats in XML configs
      require the XML PHP extension
      Fixed absolute url generation for query strings and hash urls
      bumped Symfony version to 2.8.25
      updated VERSION for 2.8.24
      updated CHANGELOG for 2.8.24
      bumped Symfony version to 2.7.32
      [Filesystem] Dont copy perms when origin is remote
      updated VERSION for 2.7.31
      update CONTRIBUTORS for 2.7.31
      updated CHANGELOG for 2.7.31
  5. Merge branch '2.7' into 2.8

    nicolas-grekas committed Jul 11, 2017
    * 2.7:
      allow to configure custom formats in XML configs
      require the XML PHP extension
      Fixed absolute url generation for query strings and hash urls
      bumped Symfony version to 2.7.32
      [Filesystem] Dont copy perms when origin is remote
      updated VERSION for 2.7.31
      update CONTRIBUTORS for 2.7.31
      updated CHANGELOG for 2.7.31
Commits on Jul 5, 2017
Commits on Jun 24, 2017
  1. Merge branch '3.4'

    xabbuh committed Jun 24, 2017
    * 3.4: (83 commits)
      add missing version attribute
      Show exception is checked twice in ExceptionController of twig
      allow SSI fragments configuration in XML files
      Display a better error message when the toolbar cannot be displayed
      [SecurityBundle] Add user impersonation info and exit action to the profiler
      render hidden _method field in form_rest()
      Add Doctrine Cache to dev dependencies to fix failing unit tests.
      return fallback locales whenever possible
      Fix Predis client cluster with pipeline
      [Dotenv] Test load() with multiple paths
      [Console] Fix catching exception type in QuestionHelper
      Improved the exception page when there is no message
      [WebProfilerBundle] Eliminate line wrap on count columnt (routing)
      [Profiler][Validator] Add a validator panel in profiler
      [Validator] replace hardcoded service id
      [Routing] Fix XmlFileLoader exception message
      Remove duplicate changelog entries
      [DI] Dedup tags when using instanceof/autoconfigure
      [Translation] Fix FileLoader::loadResource() php doc
      [Serializer] Fix workaround min php version
      ...
  2. Merge branch '3.3' into 3.4

    xabbuh committed Jun 24, 2017
    * 3.3: (64 commits)
      Show exception is checked twice in ExceptionController of twig
      allow SSI fragments configuration in XML files
      Display a better error message when the toolbar cannot be displayed
      render hidden _method field in form_rest()
      Add Doctrine Cache to dev dependencies to fix failing unit tests.
      return fallback locales whenever possible
      Fix Predis client cluster with pipeline
      [Dotenv] Test load() with multiple paths
      [Console] Fix catching exception type in QuestionHelper
      Improved the exception page when there is no message
      [WebProfilerBundle] Eliminate line wrap on count columnt (routing)
      [Validator] replace hardcoded service id
      [Routing] Fix XmlFileLoader exception message
      [DI] Dedup tags when using instanceof/autoconfigure
      [Translation] Fix FileLoader::loadResource() php doc
      Sessions: configurable "use_strict_mode" option for NativeSessionStorage
      [FrameworkBundle] [Command] Clean bundle directory, fixes #23177
      fixed CS
      [WebProfilerBundle] Fix the icon for the Cache panel
      [WebServerBundle] Fix router script path and check existence
      ...
  3. Merge branch '3.2' into 3.3

    xabbuh committed Jun 24, 2017
    * 3.2: (42 commits)
      Show exception is checked twice in ExceptionController of twig
      allow SSI fragments configuration in XML files
      Display a better error message when the toolbar cannot be displayed
      render hidden _method field in form_rest()
      Add Doctrine Cache to dev dependencies to fix failing unit tests.
      return fallback locales whenever possible
      [Console] Fix catching exception type in QuestionHelper
      [WebProfilerBundle] Eliminate line wrap on count columnt (routing)
      [Routing] Fix XmlFileLoader exception message
      [Translation] Fix FileLoader::loadResource() php doc
      Sessions: configurable "use_strict_mode" option for NativeSessionStorage
      [FrameworkBundle] [Command] Clean bundle directory, fixes #23177
      Reset redirectCount when throwing exception
      [TwigBundle] Remove template.xml services when templating is disabled
      add content-type header on exception response
      Embedding a response that combines expiration and validation, that should not defeat expiration on the combined response
      fixed bad merge
      Fix two edge cases in ResponseCacheStrategy
      [Routing] Expose request in route conditions, if needed and possible
      [Routing] Expose request in route conditions, if needed and possible
      ...
Commits on Jun 23, 2017
  1. Merge branch '2.8' into 3.2

    xabbuh committed Jun 23, 2017
    * 2.8: (40 commits)
      Show exception is checked twice in ExceptionController of twig
      allow SSI fragments configuration in XML files
      Display a better error message when the toolbar cannot be displayed
      render hidden _method field in form_rest()
      return fallback locales whenever possible
      [Console] Fix catching exception type in QuestionHelper
      [WebProfilerBundle] Eliminate line wrap on count columnt (routing)
      [Routing] Fix XmlFileLoader exception message
      [Translation] Fix FileLoader::loadResource() php doc
      Sessions: configurable "use_strict_mode" option for NativeSessionStorage
      [FrameworkBundle] [Command] Clean bundle directory, fixes #23177
      Reset redirectCount when throwing exception
      [TwigBundle] Remove template.xml services when templating is disabled
      add content-type header on exception response
      Embedding a response that combines expiration and validation, that should not defeat expiration on the combined response
      Fix two edge cases in ResponseCacheStrategy
      [Routing] Expose request in route conditions, if needed and possible
      [Routing] Expose request in route conditions, if needed and possible
      [Translation][FrameworkBundle] Fix resource loading order inconsistency reported in #23034
      [Filesystem] added workaround in Filesystem::rename for PHP bug
      ...