Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Jul 20, 2012
  1. @Slamdunk

    Late static factory method

    Slamdunk authored
Commits on Jul 9, 2012
  1. @fabpot

    fixed CS

    fabpot authored
Commits on May 18, 2012
  1. @fabpot

    merged branch jocl/master (PR #4211)

    fabpot authored
    Commits
    -------
    
    d3fee9b [Finder] ignoreDotFiles(true) filter does not match (issue #4106)
    
    Discussion
    ----------
    
    Fix for issue #4106 [Finder] ignoreDotFiles(true) filter does not match
    
    I added new dot test files:
     * .bar
     * .foo/
     * .foo/.bar
    
    Changed the tests and made a fix to finder that seems to okay for me.
    
    I hope my first PR is well arranged ;-)
    If not I will be pleased to get feedback...
    
    ---------------------------------------------------------------------------
    
    by vicb at 2012-05-11T10:20:51Z
    
    Could you squash you commits ?
    
    There is also an issue when `ignoreDotFiles(false)` is called twice, could you add a failing TC and fix the code ?
    `$this->ignore = $this->ignore ^ static::IGNORE_DOT_FILES;` should be `$this->ignore = $this->ignore & ~static::IGNORE_DOT_FILES;`
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-11T12:43:53Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1304510) (merged 72c320bc into ff7c4757).
    
    ---------------------------------------------------------------------------
    
    by vicb at 2012-05-11T13:09:32Z
    
    You need to:
    
    - tackle the related issue I have mentioned,
    - squash the commit,
    - rebase,
    - force push to your branch.
    
    http://symfony.com/doc/current/contributing/code/patches.html has some more info.
    
    As a fix, did you consider sending it to the 2.0 branch - your mention it as a BC in the commit comment but it really is a bug fix.
    
    ---------------------------------------------------------------------------
    
    by jocl at 2012-05-11T13:33:30Z
    
    Thank you. I will try it.
    
    Hasn't ```ignoreVCS(false)``` the same twice calling problem with
    ```$this->ignore = $this->ignore ^ static::IGNORE_VCS_FILES;```?
    
    ---------------------------------------------------------------------------
    
    by vicb at 2012-05-11T13:36:22Z
    
    yep, good catch !
    
    ---------------------------------------------------------------------------
    
    by jocl at 2012-05-12T10:32:06Z
    
    I mentioned it as BC, since I found no place in documentation with the information that dotFiles are ignored by default. I was also wondering that it is default behavior.
    
    But if I only read the code, it is a 100% bug.
    
    As soon as the PR is merged, I think we should also add a little notice in documentation like it is for ignoreVCS():
    http://symfony.com/doc/master/components/finder.html#files-or-directories
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-05-15T05:47:49Z
    
    I think you should keep these changes on master. Last thing before I can merge: can you squash your commits as explained by @vicb?
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-15T08:20:04Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1334337) (merged 525919fa into ff7c4757).
    
    ---------------------------------------------------------------------------
    
    by jocl at 2012-05-15T08:23:24Z
    
    I am sorry, of wasting your time... totally confused about using git. I feel a little bit squashed :-) of a the possible actions.
    I hope it is squashed now. And next time I will use the issue/ticket branch I made.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-05-15T08:35:59Z
    
    That's still not good. Squashing is explained here: http://symfony.com/doc/current/contributing/code/patches.html#rework-your-patch
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-15T20:44:14Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1339390) (merged d3fee9b2 into 03d4b026).
Commits on May 15, 2012
  1. @fabpot

    fixed phpdoc @param alignment

    fabpot authored
  2. @jocl

    [Finder] ignoreDotFiles(true) filter does not match (issue #4106)

    jocl authored
    Added new dot files/folder:
     * .bar
     * .foo/
     * .foo/.bar
    
    Adapted unit tests to the new test directory structure.
    Possible patch to fix Finder to ignore dot files.
    
    And fixed issue if ignoreDotFiles(false) and ignoreVCS(false) is called twice.
    Added 2 asserts to FinderTest.
  3. @fabpot

    merged 2.0

    fabpot authored
  4. @fabpot
Commits on May 1, 2012
  1. @fabpot

    fixed CS

    fabpot authored
Commits on Apr 22, 2012
  1. @ManuelAC

    Implement Countable

    ManuelAC authored
Commits on Apr 19, 2012
  1. @gajdaw
  2. @gajdaw
Commits on Mar 31, 2012
  1. @ruimarinho
Commits on Feb 26, 2012
  1. @fabpot

    merged 2.0

    fabpot authored
Commits on Feb 24, 2012
  1. @pcampr

    fixed coding standards

    pcampr authored
  2. @pcampr
Commits on Aug 9, 2011
  1. @brikou
Commits on Jun 14, 2011
  1. @fabpot
Commits on May 23, 2011
  1. @fabpot
Commits on Apr 26, 2011
  1. @vicb
Commits on Mar 25, 2011
  1. @fabpot

    [Finder] added Finder::append() method to be able to combine several …

    fabpot authored
    …Finder instances into one
Commits on Mar 24, 2011
  1. @fabpot
Commits on Mar 8, 2011
  1. @fabpot
Commits on Mar 6, 2011
  1. @fabpot
Commits on Feb 17, 2011
  1. @vicb @fabpot

    [Finder] Add support for relative path

    vicb authored fabpot committed
Commits on Feb 16, 2011
  1. @vicb @fabpot

    [Finder] tweak code

    vicb authored fabpot committed
Commits on Jan 18, 2011
  1. @blue-eyes @fabpot

    normalized license messages in PHP files

    blue-eyes authored fabpot committed
Commits on Oct 18, 2010
  1. @kriswallsmith @fabpot
Commits on Aug 20, 2010
  1. @fabpot
Something went wrong with that request. Please try again.