Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Mar 30, 2015
  1. @fabpot

    Merge branch '2.3' into 2.6

    fabpot authored
    * 2.3:
      [Validator] Add missing pt_BR translations
      Add parsing of hexadecimal strings for PHP 7
      [Configuration] improve description for ignoreExtraKeys on ArrayNodeDefinition
      [Validator] Added missing Hungarian translation
      [Validator] Fixed grammar in Hungarian translation
      CS: Unary operators should be placed adjacent to their operands
      CS: Binary operators should be arounded by at least one space
      remove useless tests that fail in php 7
      [Translator] fix test for php 7 compatibility
      Update phpdoc of ProcessBuilder#setPrefix()
    
    Conflicts:
    	src/Symfony/Component/HttpFoundation/Session/Attribute/NamespacedAttributeBag.php
    	src/Symfony/Component/PropertyAccess/PropertyAccessor.php
    	src/Symfony/Component/Validator/Resources/translations/validators.pt_BR.xlf
    	src/Symfony/Component/Yaml/Parser.php
Commits on Mar 27, 2015
  1. @keradus
Commits on Dec 11, 2014
  1. @fabpot

    Merge branch '2.3' into 2.5

    fabpot authored
    * 2.3:
      Revert "[DependencyInjection] backport perf optim"
      [WebProfilerBundle] replaced pattern to path attribute in routes definitions.
      [FrameworkBundle][Template name] avoid  error message for the shortcut notation.
      [DependencyInjection] perf optim: call dirname() at most 5x
      [DependencyInjection] backport perf optim
      [2.3] Remove possible call_user_func()
    
    Conflicts:
    	src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
    	src/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services10.php
    	src/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services11.php
    	src/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services9_compiled.php
Commits on Nov 21, 2014
  1. @nicolas-grekas
Commits on Oct 26, 2014
  1. @fabpot

    Merge branch '2.3' into 2.5

    fabpot authored
    * 2.3:
      Remove aligned '=>' and '='
      Break infinite loop while resolving aliases
      [Security][listener] change priority of switchuser
      Improved the phpdoc for security token classes
      bumped Symfony version to 2.3.22
      updated VERSION for 2.3.21
      update CONTRIBUTORS for 2.3.21
      updated CHANGELOG for 2.3.21
    
    Conflicts:
    	src/Symfony/Bridge/Propel1/Form/ChoiceList/ModelChoiceList.php
    	src/Symfony/Bridge/Propel1/Form/Type/ModelType.php
    	src/Symfony/Bridge/Propel1/Logger/PropelLogger.php
    	src/Symfony/Bridge/Propel1/Tests/Fixtures/ItemQuery.php
    	src/Symfony/Bundle/FrameworkBundle/Command/RouterDebugCommand.php
    	src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/ConfigurationTest.php
    	src/Symfony/Bundle/FrameworkBundle/Translation/Translator.php
    	src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php
    	src/Symfony/Bundle/SecurityBundle/Tests/Functional/Bundle/FormLoginBundle/Controller/LocalizedController.php
    	src/Symfony/Bundle/SecurityBundle/Tests/Functional/Bundle/FormLoginBundle/Controller/LoginController.php
    	src/Symfony/Component/Console/Descriptor/JsonDescriptor.php
    	src/Symfony/Component/Console/Formatter/OutputFormatterStyle.php
    	src/Symfony/Component/Console/Helper/ProgressHelper.php
    	src/Symfony/Component/Debug/ErrorHandler.php
    	src/Symfony/Component/DependencyInjection/Container.php
    	src/Symfony/Component/Finder/Shell/Command.php
    	src/Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php
    	src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php
    	src/Symfony/Component/Form/Extension/Core/Type/FormType.php
    	src/Symfony/Component/Form/Extension/Core/Type/IntegerType.php
    	src/Symfony/Component/Form/Extension/Core/Type/NumberType.php
    	src/Symfony/Component/Form/Extension/Csrf/Type/FormTypeCsrfExtension.php
    	src/Symfony/Component/HttpFoundation/File/UploadedFile.php
    	src/Symfony/Component/HttpKernel/DataCollector/LoggerDataCollector.php
    	src/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php
    	src/Symfony/Component/HttpKernel/EventListener/ExceptionListener.php
    	src/Symfony/Component/HttpKernel/Kernel.php
    	src/Symfony/Component/HttpKernel/Tests/EventListener/TestSessionListenerTest.php
    	src/Symfony/Component/HttpKernel/Tests/HttpCache/TestMultipleHttpKernel.php
    	src/Symfony/Component/Intl/NumberFormatter/NumberFormatter.php
    	src/Symfony/Component/Routing/Loader/AnnotationClassLoader.php
    	src/Symfony/Component/Routing/Route.php
    	src/Symfony/Component/Routing/Tests/Loader/AnnotationClassLoaderTest.php
    	src/Symfony/Component/Security/Tests/Core/Validator/Constraints/UserPasswordValidatorTest.php
    	src/Symfony/Component/Templating/PhpEngine.php
    	src/Symfony/Component/Validator/Constraints/ImageValidator.php
    	src/Symfony/Component/Validator/Constraints/TypeValidator.php
  2. @disquedur @fabpot

    Remove aligned '=>' and '='

    disquedur authored fabpot committed
Commits on Aug 8, 2014
  1. @fabpot

    Merge branch '2.3' into 2.4

    fabpot authored
    * 2.3:
      [HttpKernel] added an analyze of environment parameters for built-in server.
      change command to which available under most unix systems
      add way to test command under windows
      fix shell command injection
      [Form] allowed CallbackTransformer to use callable
      [Process] Added process synchronization to the incremental output tests
Commits on Aug 7, 2014
  1. @gimler

    change command to which available under most unix systems

    gimler authored Gordon Franke committed
    agree i will change it which is available under suse, ubuntu, debian, fedora, bsd
  2. add way to test command under windows

    Gordon Franke authored
  3. fix shell command injection

    Gordon Franke authored
Commits on Apr 16, 2014
  1. @fabpot

    Merge branch '2.3' into 2.4

    fabpot authored
    * 2.3:
      made {@inheritdoc} annotations consistent across the board
      fixed types in phpdocs
      made phpdoc types consistent with those defined in Hack
      Add support Thai translations
      made types consistent with those defined in Hack
      removed extra/unsupported arguments
      [HttpKernel] fixed an error message
      [TwigBundle] removed undefined argument
      [Translation] Make IcuDatFileLoader/IcuResFileLoader::load invalid resource compatible with HHVM.
    
    Conflicts:
    	src/Symfony/Bridge/ProxyManager/Tests/LazyProxy/Fixtures/php/lazy_service.php
    	src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
    	src/Symfony/Bundle/FrameworkBundle/Templating/Loader/FilesystemLoader.php
    	src/Symfony/Bundle/WebProfilerBundle/EventListener/WebDebugToolbarListener.php
    	src/Symfony/Component/Config/Definition/ReferenceDumper.php
    	src/Symfony/Component/Console/Helper/DescriptorHelper.php
    	src/Symfony/Component/Debug/ErrorHandler.php
    	src/Symfony/Component/Finder/Tests/Iterator/RecursiveDirectoryIteratorTest.php
    	src/Symfony/Component/Form/Extension/Core/DataTransformer/IntegerToLocalizedStringTransformer.php
    	src/Symfony/Component/Form/Tests/Extension/Core/DataMapper/PropertyPathMapperTest.php
    	src/Symfony/Component/HttpFoundation/Response.php
    	src/Symfony/Component/HttpFoundation/StreamedResponse.php
    	src/Symfony/Component/HttpKernel/Debug/TraceableEventDispatcher.php
    	src/Symfony/Component/HttpKernel/EventListener/ProfilerListener.php
    	src/Symfony/Component/HttpKernel/Fragment/FragmentHandler.php
    	src/Symfony/Component/HttpKernel/Fragment/RoutableFragmentRenderer.php
    	src/Symfony/Component/HttpKernel/Kernel.php
    	src/Symfony/Component/HttpKernel/Tests/Fixtures/KernelForTest.php
    	src/Symfony/Component/Intl/NumberFormatter/NumberFormatter.php
    	src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php
    	src/Symfony/Component/Stopwatch/StopwatchPeriod.php
    	src/Symfony/Component/Translation/TranslatorInterface.php
    	src/Symfony/Component/Validator/ConstraintValidatorFactory.php
Commits on Apr 15, 2014
  1. @fabpot
Commits on Dec 28, 2013
  1. @fabpot

    Merge branch '2.3' into 2.4

    fabpot authored
    * 2.3:
      fixed a typo
      fixed CS for lambdas
      [Yaml] fixed some license headers
      Fixes message value for objects
      Check for hour, minute & second validity
      fixed various typos
      [Filesystem] Fixed mirror for symlinks
      [Validator] Removed duplicated test for IBAN in data provider
    
    Conflicts:
    	src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
    	src/Symfony/Component/Console/Application.php
    	src/Symfony/Component/Debug/Tests/ErrorHandlerTest.php
    	src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
    	src/Symfony/Component/HttpKernel/Tests/DependencyInjection/ContainerAwareHttpKernelTest.php
  2. @fabpot

    fixed CS for lambdas

    fabpot authored
Commits on Dec 27, 2013
  1. @fabpot

    fixed various typos

    fabpot authored
Commits on Nov 22, 2013
  1. @fabpot

    minor #9487 unify constructor initialization style throughout symfony…

    fabpot authored
    … (Tobion)
    
    This PR was merged into the master branch.
    
    Discussion
    ----------
    
    unify constructor initialization style throughout symfony
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | n/a
    
    In almost all classes symfony uses property initialization when the value is static. Constructor initialization is only used for things that actually have logic, like passed parameters or dynamic values. IMHO it makes the code much more readable because property definition, phpdoc and default value is in one place. Also one can easily see what the constructor implements for logic like overridden default value of a parent class. Otherwise the real deal is just hidden behind 10 property initializations. One more advantage is that it requires less code. As you can see, the code was almost cut in half (210 additions and 395 deletions).
    I unified it accordingly across symfony. Sometimes it was [not even consistent within one class](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Config/Definition/BaseNode.php#L32). At the same time I recognized some errors like missing parent constructor call, or undefined properties or private properties that are not even used.
    
    I then realized that a few Kernel tests were not passing because they were deeply implementation specific like modifying booted flag with a custom `KernelForTest->setIsBooted();`. I improved and refactored the kernel tests in the __second commit__.
    
    __Third commit__ unifies short ternary operator, e.g. `$foo ?: new Foo()`. __Forth commit__ unifies missing parentheses, e.g. `new Foo()`.
    
    Commits
    -------
    
    077a089 unify missing parentheses
    2888594 unify short ternary operator
    2a9daff [HttpKernel] better written kernel tests
    111ac18 unify constructor initialization style throughout symfony
Commits on Nov 20, 2013
  1. @Tobion
Commits on Nov 11, 2013
  1. @Tobion
Commits on Aug 13, 2013
  1. @fabpot

    Merge branch '2.2' into 2.3

    fabpot authored
    * 2.2:
      corrected English grammar (s/does not exists/does not exist)
      [Process] Add more precision to Process::stop timeout
      [Process] Avoid zombie process in case of unit tests failure
      [Process] Fix #8739
      [Process] Add failing test for #8739
      [Process] Fix CS
      Fixed documentation grammar for AuthenticationManagerInterface::authenticate()
      [Validator] fixed the wrong isAbstract() check against the class (fixed #8589)
      [TwigBridge] Prevent code extension to display warning
      Use strstr instead of strpos
    
    Conflicts:
    	src/Symfony/Component/Finder/Shell/Command.php
    	src/Symfony/Component/Process/Process.php
  2. @shieldo
Commits on Apr 11, 2013
  1. @dantleech @fabpot

    Enforce sprintf for exceptions

    dantleech authored fabpot committed
Commits on Mar 22, 2013
  1. @jfsimon

    [finder] Introduced AccessDeniedException

    jfsimon authored
    This exception is thrown when trying to open a non-readable directory.
    
    Squashed commits:
    [Finder] Fixed small errors
    [Finder] small changes about AccessDeniedException
    [Finder] removed unnecessary comment
    [Finder] added access denied exception test
    [Finder] Updated AccessDeniedException base class
    [Finder] fixed access denied exception test
    [Finder] native adapters now throw AccessDeniedException on stderr
Commits on Feb 4, 2013
  1. @fabpot

    fixed regression in the Finder component (it was possible to use it w…

    fabpot authored
    …ithout using exec before, closes #6357)
Commits on Jan 11, 2013
  1. @pborreli

    Fixed PHPDoc

    pborreli authored
Commits on Jan 9, 2013
  1. @pborreli

    Fixed typos

    pborreli authored
Commits on Dec 20, 2012
  1. @fabpot

    fixed CS

    fabpot authored
  2. @mmenozzi

    [Finder] Re-enable BsdFindAdapter for Darwin shells and fix it

    mmenozzi authored
    BSD find command needs "-E" switch to evaluate POSIX regex.
    Added the ability to Command to insert bits at a given index.
    
    On some systems (Mac OS X for example) php's function
    sys_get_temp_dir() returns a directory that is a symlink.
    This causes tests failures because expected paths are different
    from path returned by the adapter. So, has been added a realpath.
    
    The building of sorting command has been totally moved on the adapter so
    the sorting command for BsdFindAdapter has been fixed.
    
    The building of content filtering command has been moved on the adapter.
    In BsdFindAdapter version, -r switch has been replaced with initial grep
    that srips out blank lines, this way is compatible with BSD shell.
Commits on Dec 19, 2012
  1. @dlsniper @fabpot

    Fixed most of the docblocks/unused namespaces

    dlsniper authored fabpot committed
Commits on Oct 4, 2012
  1. @fabpot
  2. @jfsimon @fabpot

    [2.2] [WIP] [Finder] Adding native finders implementations

    jfsimon authored fabpot committed
Something went wrong with that request. Please try again.