Permalink
Commits on Aug 22, 2012
Commits on Aug 15, 2012
  1. fix CS into Finder

    fix CS into Finder
    ruian committed Aug 15, 2012
Commits on Jul 28, 2012
  1. Fixed typos

    pborreli committed Jul 28, 2012
Commits on Jul 27, 2012
  1. merged branch alebo/ticket_4922 (PR #4993)

    Commits
    -------
    
    ae6016c [Finder] Workaround for FilterIterator-FilesystemIterator-rewind issue
    
    Discussion
    ----------
    
    [Finder] Workaround for the problem with rewind of FilterIterator with inner FilesystemIterator.
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #4922
    Todo: -
    License of the code: MIT
    Documentation PR: -
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-07-20T10:28:05Z
    
    Please add some tests
    
    ---------------------------------------------------------------------------
    
    by alebo at 2012-07-24T09:50:36Z
    
    Any feedback yet? The new commit includes tests.
    fabpot committed Jul 27, 2012
Commits on Jul 20, 2012
  1. Late static factory method

    Slamdunk committed Jul 20, 2012
Commits on Jul 15, 2012
  1. Revert "raised the minimum version of PHP to 5.3.4 (closes #3856)"

    This reverts commit 2dcc44897ef1ceec2721bbf616c4744131340657.
    fabpot committed Jul 15, 2012
Commits on Jul 13, 2012
  1. raised the minimum version of PHP to 5.3.4 (closes #3856)

    We've raised the minimum version of PHP because of a PHP
    bug before 5.3.4:
    
    https://bugs.php.net/bug.php?id=52083
    https://bugs.php.net/bug.php?id=50027
    fabpot committed Jul 13, 2012
Commits on Jul 9, 2012
  1. fixed CS

    fabpot committed Jul 9, 2012
  2. merged branch gajdaw/finder_splfileinfo_fpassthu (PR #4751)

    Commits
    -------
    
    b4d7a7e [Component][Finder][SplFileInfo] file_get_contents=>fpassthru
    
    Discussion
    ----------
    
    [Component][Finder][SplFileInfo] file_get_contents=>fpassthru
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: https://github.com/symfony/symfony/pull/4335/files#r1016152
    Todo: -
    License of the code: MIT
    Documentation PR: -
    fabpot committed Jul 9, 2012
  3. fixed CS

    fabpot committed Jul 9, 2012
Commits on Jul 4, 2012
Commits on Jul 2, 2012
  1. [Finder] '*' and '?' are considered are glob pattern rather than deli…

    …miters (fix #4664)
    vicb committed Jul 2, 2012
Commits on Jun 19, 2012
  1. merged branch gajdaw/finder_current_fix (PR #4335)

    Commits
    -------
    
    3eb67fc [2.1][Component][Finder] $this->current() fix
    
    Discussion
    ----------
    
    [2.1][Component][Finder] $this->current() fix
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: [![Build Status](https://secure.travis-ci.org/gajdaw/symfony.png?branch=master)](http://travis-ci.org/gajdaw/symfony)
    Fixes the following tickets: -
    Todo: -
    License of the code: MIT
    
    One method to resolve `->in("ftp://...")` problem is to create `RecursiveDirectoryFtpIterator`.
    (Details: [issue 3585](symfony/symfony#3585))
    
    I think that all filters should access the information about current item calling `current()` or `getInnerIterator()`. Otherwise it will not work if we replace `RecursiveDirectoryIterator` with ftp iterator inside `Finder`.
    
    I'm not sure if that should go to 2.0 or 2.1 branch.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-19T09:20:19Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1373361) (merged 9f247921 into 58b92453).
    
    ---------------------------------------------------------------------------
    
    by gajdaw at 2012-05-19T10:51:10Z
    
    Probably it should go to master branch, because it improves commit done to master:
    
    symfony/symfony@f2fea97
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-19T11:26:14Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1373982) (merged f9d1db8c into 58b92453).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-19T11:51:25Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1374031) (merged f1b4b4f7 into 58b92453).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-19T12:48:17Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1374303) (merged b6d073da into 58b92453).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-19T13:28:18Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1374568) (merged fd144c96 into 58b92453).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-19T13:35:38Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1374609) (merged 89a8d851 into 58b92453).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-21T04:31:46Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1385764) (merged 0d5b8322 into 58b92453).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-21T07:21:56Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1386545) (merged 3eb67fca into 1407f112).
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-06-09T13:24:14Z
    
    seems good
    fabpot committed Jun 19, 2012
Commits on May 21, 2012
  1. fixed CS

    fabpot committed May 21, 2012
Commits on May 18, 2012
  1. fixed CS

    fabpot committed May 18, 2012
  2. merged branch jocl/master (PR #4211)

    Commits
    -------
    
    d3fee9b [Finder] ignoreDotFiles(true) filter does not match (issue #4106)
    
    Discussion
    ----------
    
    Fix for issue #4106 [Finder] ignoreDotFiles(true) filter does not match
    
    I added new dot test files:
     * .bar
     * .foo/
     * .foo/.bar
    
    Changed the tests and made a fix to finder that seems to okay for me.
    
    I hope my first PR is well arranged ;-)
    If not I will be pleased to get feedback...
    
    ---------------------------------------------------------------------------
    
    by vicb at 2012-05-11T10:20:51Z
    
    Could you squash you commits ?
    
    There is also an issue when `ignoreDotFiles(false)` is called twice, could you add a failing TC and fix the code ?
    `$this->ignore = $this->ignore ^ static::IGNORE_DOT_FILES;` should be `$this->ignore = $this->ignore & ~static::IGNORE_DOT_FILES;`
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-11T12:43:53Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1304510) (merged 72c320bc into ff7c4757).
    
    ---------------------------------------------------------------------------
    
    by vicb at 2012-05-11T13:09:32Z
    
    You need to:
    
    - tackle the related issue I have mentioned,
    - squash the commit,
    - rebase,
    - force push to your branch.
    
    http://symfony.com/doc/current/contributing/code/patches.html has some more info.
    
    As a fix, did you consider sending it to the 2.0 branch - your mention it as a BC in the commit comment but it really is a bug fix.
    
    ---------------------------------------------------------------------------
    
    by jocl at 2012-05-11T13:33:30Z
    
    Thank you. I will try it.
    
    Hasn't ```ignoreVCS(false)``` the same twice calling problem with
    ```$this->ignore = $this->ignore ^ static::IGNORE_VCS_FILES;```?
    
    ---------------------------------------------------------------------------
    
    by vicb at 2012-05-11T13:36:22Z
    
    yep, good catch !
    
    ---------------------------------------------------------------------------
    
    by jocl at 2012-05-12T10:32:06Z
    
    I mentioned it as BC, since I found no place in documentation with the information that dotFiles are ignored by default. I was also wondering that it is default behavior.
    
    But if I only read the code, it is a 100% bug.
    
    As soon as the PR is merged, I think we should also add a little notice in documentation like it is for ignoreVCS():
    http://symfony.com/doc/master/components/finder.html#files-or-directories
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-05-15T05:47:49Z
    
    I think you should keep these changes on master. Last thing before I can merge: can you squash your commits as explained by @vicb?
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-15T08:20:04Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1334337) (merged 525919fa into ff7c4757).
    
    ---------------------------------------------------------------------------
    
    by jocl at 2012-05-15T08:23:24Z
    
    I am sorry, of wasting your time... totally confused about using git. I feel a little bit squashed :-) of a the possible actions.
    I hope it is squashed now. And next time I will use the issue/ticket branch I made.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-05-15T08:35:59Z
    
    That's still not good. Squashing is explained here: http://symfony.com/doc/current/contributing/code/patches.html#rework-your-patch
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-15T20:44:14Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1339390) (merged d3fee9b2 into 03d4b026).
    fabpot committed May 18, 2012
Commits on May 15, 2012
  1. fixed phpdoc @param alignment

    fabpot committed May 15, 2012
  2. [Finder] ignoreDotFiles(true) filter does not match (issue #4106)

    Added new dot files/folder:
     * .bar
     * .foo/
     * .foo/.bar
    
    Adapted unit tests to the new test directory structure.
    Possible patch to fix Finder to ignore dot files.
    
    And fixed issue if ignoreDotFiles(false) and ignoreVCS(false) is called twice.
    Added 2 asserts to FinderTest.
    jocl committed May 6, 2012
  3. merged 2.0

    fabpot committed May 15, 2012
  4. fixed CS

    fabpot committed May 15, 2012
Commits on May 11, 2012
  1. merged branch gajdaw/finder_contains_exception_test (PR #4056)

    Commits
    -------
    
    f2fea97 [Component][Finder] tests and condition: contains() used on dir
    
    Discussion
    ----------
    
    [Component][Finder] tests and condition: contains() used on dir
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    
    `Finder::contains()` and `Finder::notContains()` can't be used on directories.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-08T06:33:11Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1273818) (merged f2fea974 into 919604ab).
    fabpot committed May 11, 2012
Commits on May 7, 2012
  1. updated minimum PHP version to 5.3.3

    5.3.3 has some interesting fixes and this is the version used by
    Redhat 6 and Debian 6
    fabpot committed May 7, 2012
Commits on May 3, 2012
  1. Fix some cs

    stephpy committed May 3, 2012
Commits on May 1, 2012
  1. merged branch willdurand/fix-components (PR #4155)

    Commits
    -------
    
    c195957 [Components] Tests/Autoloading fixes
    
    Discussion
    ----------
    
    Fix components
    
    See #4141
    
    ----
    This PR:
    
    * configures each component to use composer to manage "dev" dependencies instead of env variables;
    * adds phpunit configuration file on Filesystem component;
    * fixes READMEs.
    
    It's mergeable without any problems, but I would recommend to wait a fix in Composer in order to use `self.version` in `require`/`require-dev` sections.
    
    Note: I kept `suggest` sections because it makes sense but this PR doesn't aim to provide useful explanations for each entry. It could be another PR, not that one.
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2012-04-30T20:43:13Z
    
    @fabpot I reviewed each component, one by one. Now `phpunit` always works, even if tests are skipped. A simple `composer install --dev` allows to run the complete test suite. Each commit is well separated from the others. I guess, everything is ok now.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-04-30T20:47:00Z
    
    Please squash, as it makes no sense to have the same commit for each component.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-05-01T14:26:11Z
    
    Can you squash your commits before I merge? Thanks.
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2012-05-01T14:29:38Z
    
    done
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-05-01T15:48:25Z
    
    It does not seem that the commits are squashed.
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2012-05-01T15:54:08Z
    
    done
    fabpot committed May 1, 2012
  2. [Components] Tests/Autoloading fixes

    * Switched to Composer to manage "dev" dependencies
    * Fixed READMEs
    * Excluded vendor in phpunit.xml.dist files
    * Fixed message in bootstrap.php files
    * Added autoloader for the component itself
    willdurand committed Apr 27, 2012
  3. fixed CS

    fabpot committed May 1, 2012
Commits on Apr 27, 2012
  1. Revert "merged branch Seldaek/master (PR #4133)"

    This reverts commit 00e7a94a8c761a3e10c388e4d06cb3ce4cd04ad7, reversing
    changes made to a01dec00f4e8de357cce5fdf121ac98729f7f8ff.
    fabpot committed Apr 27, 2012
  2. Update branch aliases

    Seldaek committed Apr 27, 2012
Commits on Apr 26, 2012
  1. [Finder] added CHANGELOG

    fabpot committed Apr 26, 2012
Commits on Apr 24, 2012
Commits on Apr 22, 2012
  1. Implement Countable

    ManuelAC committed Apr 22, 2012