Permalink
Commits on Mar 16, 2012
  1. Changed instances of \DateTimeZone::UTC to 'UTC' as the constant is n…

    Drew Butler committed Mar 16, 2012
    …ot valid a produces this error when DateTimeZone is instantiated: DateTimeZone::__construct() [<a href='datetimezone.--construct'>datetimezone.--construct</a>]: Unknown or bad timezone (1024)
Commits on Mar 15, 2012
  1. Revert "Throw exception when "date_widget" option is not equal to "ti…

    xavierbriand committed Mar 15, 2012
    …me_widget""
    
    This reverts commit 3c2539f.
    
    Conflicts:
    
    	tests/Symfony/Tests/Component/Form/Extension/Core/Type/DateTimeTypeTest.php
Commits on Mar 12, 2012
Commits on Mar 11, 2012
  1. [Form] Moved the Validator component to the suggest section

    stof committed Mar 11, 2012
    There is no hard dependency to the Validator component.
Commits on Feb 22, 2012
  1. Updated LICENSE files copyright

    marc.weistroff committed Feb 22, 2012
Commits on Jan 26, 2012
  1. [FormType] Fixed broken MoneyType regexp for JPY

    manuelkiessling committed Jan 17, 2012
    The regexp in MoneyType doesn't work if currency format has no decimal
    (like JPY) and doesn't work either if the currency symbol is unicode
    
    This change fixes both issues and adds a unit test
Commits on Jan 18, 2012
  1. fixed CS

    fabpot committed Jan 18, 2012
Commits on Jan 11, 2012
  1. fixed some phpdoc

    fabpot committed Jan 11, 2012
Commits on Jan 10, 2012
Commits on Jan 5, 2012
Commits on Dec 18, 2011
  1. fixed CS

    fabpot committed Dec 18, 2011
  2. tweaked the README files

    fabpot committed Dec 18, 2011
  3. merged branch lsmith77/component_readmes (PR #2561)

    fabpot committed Dec 18, 2011
    Commits
    -------
    
    1e370d7 typo fix
    93d8d44 added some more infos about Config
    27efd59 added READMEs for the bridges
    34fc866 cosmetic tweaks
    d6af3f1 fixed README for Console
    6a72b8c added basic README files for all components
    
    Discussion
    ----------
    
    added basic README files for all components and bridges
    
    heavily based on http://fabien.potencier.org/article/49/what-is-symfony2 and the official Symfony2 documentation
    
    ---------------------------------------------------------------------------
    
    by jmikola at 2011/11/03 13:36:07 -0700
    
    Great work. For syntax highlighting on the PHP snippets, you could add "php" after the three backticks.
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/03 13:41:29 -0700
    
    done
    
    ---------------------------------------------------------------------------
    
    by stealth35 at 2011/11/03 13:49:31 -0700
    
    Nice job, but you also need to add `<?php`
    
    ex :
    
    ``` php
    <?php
    use Symfony\Component\DomCrawler\Crawler;
    
    $crawler = new Crawler();
    $crawler->addContent('<html><body><p>Hello World!</p></body></html>');
    
    print $crawler->filter('body > p')->text();
    ```
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/03 13:56:57 -0700
    
    done
    
    ---------------------------------------------------------------------------
    
    by ericclemmons at 2011/11/03 19:57:57 -0700
    
    @lsmith77 Well done!  This makes consumption of individual components that much easier, *especially* now that `composer.json` files have been added.
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/04 01:18:23 -0700
    
    ok .. fixed the issues you mentioned @fabpot
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/11 15:00:27 -0800
    
    @fabpot anything else left? seems like an easy merge .. and imho there is considerable benefit for our efforts to spread the word about the components with this PR merged.
    
    ---------------------------------------------------------------------------
    
    by drak at 2011/11/11 18:54:13 -0800
    
    You know, it might be a nice idea to put a link to the documentation for each component if there is some at symfony.com
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/12 00:59:14 -0800
    
    i did that in some. but i might have missed a few places.
    On 12.11.2011, at 03:54, Drak <reply@reply.github.com> wrote:
    
    > You know, it might be a nice idea to put a link to the documentation for each component if there is some at symfony.com
    >
    > ---
    > Reply to this email directly or view it on GitHub:
    > symfony/symfony#2561 (comment)
    
    ---------------------------------------------------------------------------
    
    by breerly at 2011/11/21 10:28:36 -0800
    
    Pretty excited with this.
    
    ---------------------------------------------------------------------------
    
    by dbu at 2011/11/24 00:02:50 -0800
    
    is there anything we can help with to make this ready to be merged?
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/12/18 02:39:23 -0800
    
    @fabpot: seriously .. if you are not going to deliver something "better" and don't provide a reason what is wrong with this .. then its beyond frustrating. i obviously do not claim that these README's are perfect (and certainly still no replacement for proper documentation), but I do claim that in their current form they are a radical step forward to potential users of the Symfony2 components.
Commits on Dec 15, 2011
Commits on Dec 13, 2011
  1. [DoctrineBridge] fixed some CS

    fabpot committed Dec 13, 2011
Commits on Nov 23, 2011
Commits on Nov 22, 2011
  1. merged branch hlecorche/valid-form-w3c (PR #2676)

    fabpot committed Nov 22, 2011
    Commits
    -------
    
    78e9b2f [Form] Fixed textarea_widget (W3C standards)
    
    Discussion
    ----------
    
    [Form] Fixed textarea_widget (W3C standards)
    
    Textarea widget included the "pattern" attribute but is not valid by W3C standards.
    
    (See PR 2666 - New PR because rebase inside the 2.0 branch)
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/11/18 09:01:41 -0800
    
    @hlecorche: Thanks for your work on this issue. Can you update the unit tests to be sure that this case is covered? If you're not comfortable with this, just tell me and I will do it myself
    
    ---------------------------------------------------------------------------
    
    by hlecorche at 2011/11/19 02:51:06 -0800
    
    @fabpot: I did'nt commited because I am not sure. I changed the "tests/Symfony/Tests/Component/Form/AbstractLayoutTest.php" file :
    
        public function testTextarea()
        {
            $form = $this->factory->createNamed('textarea', 'na&me', 'foo&bar', array(
                'property_path' => 'name',
                'pattern' => 'foo',
            ));
    
            $this->assertWidgetMatchesXpath($form->createView(), array(),
        '/textarea
        [@name="na&me"]
        [not(@pattern)]
        [.="foo&bar"]
        '
            );
        }
    
    Is it correct?
  2. merged branch canni/throw_exception_on_form_name_circulal_ref (PR #2675)

    fabpot committed Nov 22, 2011
    Commits
    -------
    
    36cebf0 Fix infinite loop on circullar reference in form factory
    
    Discussion
    ----------
    
    [BugFix][Form]Throw exception on form name circulal ref
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Closes: #2673
    
    When FormType method `getName()` returns the same value as `getParent()` we're asking about trouble, and land into infinite loop.
  3. merged branch willdurand/undefined-value-property-path (PR #2266)

    fabpot committed Nov 22, 2011
    Commits
    -------
    
    57e1aeb Fixed undefined index notice in readProperty() method (PropertyPath)
    
    Discussion
    ----------
    
    Fixed undefined index notice in readProperty() method (PropertyPath)
    
    Hi,
    
    For some reasons, I get `notice` errors on `readProperty()` with Propel:
    
        Notice: Undefined index: 0 in /Users/william/projects/Propel/testProjects/symfony2/vendor/symfony/src/Symfony/Component/Form/Util/PropertyPath.php line 284
    
    The `PropelObjectCollection` implements `ArrayAccess`, the `readProperty()` method does not check if the given `index` exists so the `notice` error is thrown. I suppose to check whether the index exists or not has to be added.
    
    Regards,
    William
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/09/27 23:42:07 -0700
    
    The patch is probably not what we want to do. First, I suppose that you are not creating the propertyPath by hand. If that is the case, we need to understand why the property path does not exist. Then, even if we might want to check the existence of the index, if it does not exist, we should probably throw an exception instead of just ignoring the problem.
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2011/09/28 01:14:49 -0700
    
    My bad. This is a Propel bug due to `ArrayObject`. It throws a notice error if the index is not found in `offsetGet()` which is wrong according to the `ArrayAccess` interface. If the index is not found, we have to return `null`.
    
    @fabpot Are you agree with that (for the `null` value) ?
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/09/28 01:17:09 -0700
    
    My point is that it should never happen under normal circumstances.
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2011/09/28 01:23:55 -0700
    
    @fabpot Not sure to get it.
    
    The fact is that it tries to get the value (`getValue()`) of a fresh object, just added to the `collection` when I'm submitting a form with a `CollectionType` and a new entry in it.
    I mean it tries to get this new object (not yet persisted, not yet in the collection) in the collection (`getValue()` -> `readProperty()`) which implements `ArrayAccess` but this object cannot be in the collection at this time.
    
    Am I wrong ?
    
    And, without this notice error thrown by Propel, I probably never opened this issue...
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2011/09/29 06:40:34 -0700
    
    @fabpot: you can try this example: http://www.propelorm.org/cookbook/symfony2/mastering-symfony2-forms-with-propel.html#manytomany_relations in order to make your own tests. Will it be enough?
    As I said, it throws a weird notice for the reasons above.
    
    ---------------------------------------------------------------------------
    
    by jaugustin at 2011/10/04 12:58:10 -0700
    
    any news on this ?
    @fabpot did you have time to look at the test case ?
    
    ---------------------------------------------------------------------------
    
    by cedriclombardot at 2011/11/09 14:29:42 -0800
    
    @fabpot: can we have news about this ?
Commits on Nov 18, 2011
  1. Fix infinite loop on circullar reference in form factory

    canni committed Nov 18, 2011
    When `->getName()` returns the same as `getParent()` we're going to infinite loop.
Commits on Nov 17, 2011
  1. merged branch kriswallsmith/form/checkbox-view (PR #2661)

    fabpot committed Nov 17, 2011
    Commits
    -------
    
    79ae3fc [Form] fixed radio and checkbox when data is not bool
    
    Discussion
    ----------
    
    [Form] fixed checkbox view
    
    The checkbox view was being built based on app data, not client data. This fixes it.
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/11/16 13:31:09 -0800
    
    `RadioType` suffers from the same problem, no?
    
    ---------------------------------------------------------------------------
    
    by kriswallsmith at 2011/11/16 13:32:50 -0800
    
    Yeah, I'll fix that too.
    
    ---------------------------------------------------------------------------
    
    by kriswallsmith at 2011/11/16 13:43:29 -0800
    
    Updated to include `RadioType`.
Commits on Nov 16, 2011
Commits on Nov 11, 2011
  1. [Form] Replace `an` with `is`

    ManuelAC committed Nov 11, 2011
  2. [Form] fixed previous merge

    fabpot committed Nov 11, 2011
  3. [Form] simplified previous merge

    fabpot committed Nov 11, 2011
  4. Added check for array fields to be integers in reverseTransform metho…

    ondrowan committed Nov 11, 2011
    …d. This prevents checkdate from getting strings as arguments and throwing incorrect ErrorException when submitting form with malformed (string) data in, for example, Date field. #2609
Commits on Nov 3, 2011
  1. added basic README files for all components

    lsmith77 committed Nov 3, 2011
        heavily inspired by http://fabien.potencier.org/article/49/what-is-symfony2 and the official Symfony2 documentation
Commits on Nov 2, 2011
  1. merged branch mrtorrent/integer_transformer_cast_fix (PR #2520)

    fabpot committed Nov 2, 2011
    Commits
    -------
    
    c9d05d7 Let NumberFormatter handle integer type casting
    
    Discussion
    ----------
    
    Let NumberFormatter handle integer type casting
    
    The integer to localised string transformer is currently casting everything it gets to an integer, even if it is not a number. This responsibility should be passed off to NumberFormatter.
    
    Partially addresses #2389 by not mistakenly typecasting a boolean false into an integer 0
    
    ---------------------------------------------------------------------------
    
    by mrtorrent at 2011/10/30 15:04:28 -0700
    
    Apologies, forgot the template:
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #2389 (partial)